Revert bash sandbox via bubblewrap (#58)#59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #58 (
30e1237), which installed bubblewrap/socat and added a runtime probe +PI_REQUIRE_BASH_SANDBOXswitch to confine the bash tool via nested user/mount namespaces.The bubblewrap approach did not work in the OCD container environment: even with
userns/relaxed seccomp, the nested namespace sandbox failed to engage, so bash kept falling back to unsandboxed (now loudly logged, but still no real isolation) while the container hardening was weakened with no benefit.This restores the three files to their pre-#58 state:
server/Dockerfile— drops the bubblewrap + socat apt packages.server/lib/pi/extensions/project-sandbox/index.ts— back to the SandboxManager fail-open path, no probe / noPI_REQUIRE_BASH_SANDBOX/ no loud logging.server/.ocd-deploy.json— drops"userns": true.The per-project-UID approach will replace this for real bash isolation.
Pairs with the one-click-deploy
revert/userns-featurePR that removes the platform-sideusernsplumbing.Leaving open for manual review/merge.