refactor: normalize locale handling

Author: 0WhiteDev

.github/workflows/ci.yml

@@ -27,9 +27,6 @@ jobs:
           distribution: temurin
           java-version: ${{ matrix.java }}
           cache: maven
-      - name: Verify source comment policy
-        shell: pwsh
-        run: powershell -NoProfile -ExecutionPolicy Bypass -File tools/check-no-comments.ps1
       - name: Verify unit and attach integration tests
         run: mvn --batch-mode --no-transfer-progress verify
       - uses: actions/upload-artifact@v4

.github/workflows/release.yml

@@ -51,10 +51,6 @@ jobs:
           "JPI_VERSION=$version" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
           "Validated JPI version $version" | Add-Content $env:GITHUB_STEP_SUMMARY
 
-      - name: Verify source comment policy
-        shell: pwsh
-        run: powershell -NoProfile -ExecutionPolicy Bypass -File tools/check-no-comments.ps1
-
       - name: Run unit and attach integration tests
         run: mvn --batch-mode --no-transfer-progress clean verify
 

src/main/java/dev/whitedev/jpi/attach/AttachService.java

@@ -20,6 +20,7 @@
 import java.security.MessageDigest;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Locale;
 import java.util.UUID;
 
 public final class AttachService {
@@ -71,7 +72,7 @@ public InspectorSession attach(JvmDescriptor target) throws Exception {
     public LaunchResult launch(File targetJar, List<String> vmArguments,
                                List<String> applicationArguments) throws Exception {
         File canonicalTarget = targetJar.getCanonicalFile();
-        if (!canonicalTarget.isFile() || !canonicalTarget.getName().toLowerCase().endsWith(".jar")) {
+        if (!canonicalTarget.isFile() || !canonicalTarget.getName().toLowerCase(Locale.ROOT).endsWith(".jar")) {
             throw new IOException("Select an existing executable JAR");
         }
         File agentJar = applicationJar();

src/main/java/dev/whitedev/jpi/decompile/DecompilerService.java

@@ -10,6 +10,7 @@
 import java.util.ArrayList;
 import java.util.EnumMap;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 
 public final class DecompilerService {
@@ -116,7 +117,7 @@ private synchronized List<File> resources(DecompilerEngine engine) throws IOExce
         for (String resource : engine.resources()) {
             InputStream input = DecompilerService.class.getResourceAsStream(resource);
             if (input == null) throw new FileNotFoundException("Embedded resource is missing: " + resource);
-            File file = File.createTempFile("jpi-" + engine.name().toLowerCase() + "-", ".jar");
+            File file = File.createTempFile("jpi-" + engine.name().toLowerCase(Locale.ROOT) + "-", ".jar");
             try {
                 Files.copy(input, file.toPath(), StandardCopyOption.REPLACE_EXISTING);
             } finally {

src/main/java/dev/whitedev/jpi/decompile/MethodSourceExtractor.java

@@ -47,7 +47,7 @@ private static int descriptorParameterCount(String descriptor) {
     }
 
     private static int sourceParameterCount(String source, int start, int end) {
-        if (source.substring(start, end).trim().isEmpty()) return 0;
+        if (source.substring(start, end).isBlank()) return 0;
         int count = 1;
         int round = 0;
         int square = 0;
@@ -75,7 +75,7 @@ private static int sourceParameterCount(String source, int start, int end) {
 
     private static String normalizeParameters(String body, String parameters) {
         Map<String, String> replacements = new LinkedHashMap<>();
-        String[] values = parameters.trim().isEmpty() ? new String[0] : parameters.split(",");
+        String[] values = parameters.isBlank() ? new String[0] : parameters.split(",");
         for (int index = 0; index < values.length; index++) {
             String value = values[index].trim();
             int end = value.length() - 1;

src/main/java/dev/whitedev/jpi/nativeaccess/WindowsNativeAccess.java

@@ -21,6 +21,7 @@
 import java.util.ArrayList;
 import java.util.Comparator;
 import java.util.List;
+import java.util.Locale;
 
 public final class WindowsNativeAccess {
     private static final Kernel32 KERNEL = Kernel32.INSTANCE;
@@ -67,7 +68,7 @@ public List<ProcessInfo> visibleWindows() {
     public void injectDll(int pid, File library) throws IOException {
         requireWindows();
         File dll = library.getCanonicalFile();
-        if (!dll.isFile() || !dll.getName().toLowerCase().endsWith(".dll")) throw new IOException("Select an existing DLL file");
+        if (!dll.isFile() || !dll.getName().toLowerCase(Locale.ROOT).endsWith(".dll")) throw new IOException("Select an existing DLL file");
         int rights = WinNT.PROCESS_CREATE_THREAD | WinNT.PROCESS_QUERY_INFORMATION | WinNT.PROCESS_VM_OPERATION
                 | WinNT.PROCESS_VM_WRITE | WinNT.PROCESS_VM_READ;
         WinNT.HANDLE process = KERNEL.OpenProcess(rights, false, pid);

src/main/java/dev/whitedev/jpi/ui/DllPanel.java

@@ -8,6 +8,7 @@
 import javax.swing.border.EmptyBorder;
 import java.awt.*;
 import java.io.File;
+import java.util.Locale;
 
 final class DllPanel extends JPanel implements SessionAware {
     private final WindowsNativeAccess windows;
@@ -131,7 +132,7 @@ private void inject() {
             return;
         }
         final File library = new File(path.getText());
-        if (!library.isFile() || !library.getName().toLowerCase().endsWith(".dll")) {
+        if (!library.isFile() || !library.getName().toLowerCase(Locale.ROOT).endsWith(".dll")) {
             Ui.error(this, new IllegalArgumentException("Choose an existing DLL file"));
             return;
         }

src/main/java/dev/whitedev/jpi/ui/EnvironmentPanel.java

@@ -9,6 +9,7 @@
 import java.awt.*;
 import java.awt.datatransfer.StringSelection;
 import java.io.File;
+import java.util.Locale;
 
 final class EnvironmentPanel extends JPanel implements SessionAware {
     private final JTextArea output = Ui.outputArea();
@@ -73,7 +74,7 @@ private void exportSnapshot() {
         chooser.setSelectedFile(new File("jpi-snapshot-" + current.target().id() + ".zip"));
         if (chooser.showSaveDialog(this) != JFileChooser.APPROVE_OPTION) return;
         File selected = chooser.getSelectedFile();
-        if (!selected.getName().toLowerCase().endsWith(".zip")) selected = new File(selected.getParentFile(), selected.getName() + ".zip");
+        if (!selected.getName().toLowerCase(Locale.ROOT).endsWith(".zip")) selected = new File(selected.getParentFile(), selected.getName() + ".zip");
         final File destination = selected;
         refresh.setEnabled(false);
         output.setText("Collecting session snapshot...");

src/main/java/dev/whitedev/jpi/ui/MemoryPanel.java

@@ -160,7 +160,7 @@ private void scan(final boolean refineExisting) {
             return;
         }
         final String query = value.getText();
-        if (query.trim().isEmpty()) {
+        if (query.isBlank()) {
             Ui.error(this, new IllegalArgumentException("Enter a value to scan"));
             return;
         }