Added tests that confirm that the WaaS API (and our C# ethereum library) can handle encoding functions with underscores '_' in their names -> motivated by a client issue that seemed like it may be having an issue with this (#173)

Author: BellringerQuinn

Assets/SequenceSDK/WaaS/Tests/WalletInteractionsTests.cs

@@ -426,5 +426,75 @@ public async Task TestFeeOptionsAndSend()
 
             await tcs.Task;
         }
+
+        [Test]
+        public async Task TestInteractingWithContractFunctionsInSnakeCase_LocalABIEncoding()
+        {
+            WaaSEndToEndTestConfig config = WaaSEndToEndTestConfig.GetConfig();
+            var tcs = new TaskCompletionSource<bool>();
+            EndToEndTestHarness testHarness = new EndToEndTestHarness();
+            Contract testUnderscores = new Contract("0x8f408550720b268b0ea0969c527ac997d969a638");
+
+            testHarness.Login(async wallet =>
+            {
+                try
+                {
+                    TransactionReturn transactionReturn = await wallet.SendTransaction(_chain,
+                        new Transaction[]
+                        {
+                            new RawTransaction(testUnderscores.GetAddress(), "0", 
+                                testUnderscores.CallFunction("test_function_name_with_underscores(uint256)", BigInteger.One).CallData)
+                        });
+                    Assert.IsNotNull(transactionReturn);
+                    Assert.IsTrue(transactionReturn is SuccessfulTransactionReturn);
+                    
+                    tcs.TrySetResult(true);
+                }
+                catch (System.Exception e)
+                {
+                    tcs.TrySetException(e);
+                }
+            }, (error, method, email, methods) =>
+            {
+                tcs.TrySetException(new Exception(error));
+            });
+
+            await tcs.Task;
+        }
+
+        [Test]
+        public async Task TestInteractingWithContractFunctionsInSnakeCase_DelayedServerSideABIEncoding()
+        {
+            WaaSEndToEndTestConfig config = WaaSEndToEndTestConfig.GetConfig();
+            var tcs = new TaskCompletionSource<bool>();
+            EndToEndTestHarness testHarness = new EndToEndTestHarness();
+            Contract testUnderscores = new Contract("0x8f408550720b268b0ea0969c527ac997d969a638");
+
+            testHarness.Login(async wallet =>
+            {
+                try
+                {
+                    TransactionReturn transactionReturn = await wallet.SendTransaction(_chain,
+                        new Transaction[]
+                        {
+                            new DelayedEncode(testUnderscores.GetAddress(), "0",
+                                new DelayedEncodeData("test_function_name_with_underscores(uint256)", new object[] { "1" }, "test_function_name_with_underscores"))
+                        });
+                    Assert.IsNotNull(transactionReturn);
+                    Assert.IsTrue(transactionReturn is SuccessfulTransactionReturn);
+                    
+                    tcs.TrySetResult(true);
+                }
+                catch (System.Exception e)
+                {
+                    tcs.TrySetException(e);
+                }
+            }, (error, method, email, methods) =>
+            {
+                tcs.TrySetException(new Exception(error));
+            });
+
+            await tcs.Task;
+        }
     }
 }

testchain/artifacts/contracts/TestUnderscores.sol/TestUnderscores.dbg.json

@@ -0,0 +1,4 @@
+{
+  "_format": "hh-sol-dbg-1",
+  "buildInfo": "../../build-info/bb4208cd93884725284d631e62444e66.json"
+}

testchain/artifacts/contracts/TestUnderscores.sol/TestUnderscores.json

@@ -0,0 +1,26 @@
+{
+  "abi": [
+    {
+      "inputs": [
+        {
+          "internalType": "uint256",
+          "name": "number_with_underscore",
+          "type": "uint256"
+        }
+      ],
+      "name": "test_function_name_with_underscores",
+      "outputs": [
+        {
+          "internalType": "uint256",
+          "name": "",
+          "type": "uint256"
+        }
+      ],
+      "stateMutability": "nonpayable",
+      "type": "function"
+    }
+  ],
+  "bytecode": {
+    "object": "0x608060405234801561001057600080fd5b5061011b806100206000396000f3fe6080604052348015600f57600080fd5b506004361060285760003560e01c80632fd628e514602d575b600080fd5b60436004803603810190603f91906097565b6057565b604051604e919060cc565b60405180910390f35b6000819050919050565b600080fd5b6000819050919050565b6077816066565b8114608157600080fd5b50565b6000813590506091816070565b92915050565b60006020828403121560aa5760a96061565b5b600060b6848285016084565b91505092915050565b60c6816066565b82525050565b600060208201905060df600083018460bf565b9291505056fea2646970667358221220f0bd4ad9f5930efb3a5f117265fcc59cfa61bd68f3923c4666e7291e4d28307a64736f6c63430008110033"
+  }
+}

testchain/contracts/TestUnderscores.sol

@@ -0,0 +1,9 @@
+pragma solidity ^0.8.9;
+
+contract TestUnderscores {
+    function test_function_name_with_underscores(
+        uint256 number_with_underscore
+    ) public returns (uint256) {
+        return (number_with_underscore);
+    }
+}