Merge pull request #268 from 0xsequence/Fix/fetchTimeShiftFromAPI

Fetch timeshift from Sequence API when creating the RPC manager. Use …

Author: andygruening

Plugins/SequencePlugin/Source/SequencePlugin/Private/SequenceRPCManager.cpp

@@ -5,6 +5,7 @@
 #include "SequenceAuthenticator.h"
 #include "RequestHandler.h"
 #include "ConfigFetcher.h"
+#include "HttpModule.h"
 #include "Interfaces/IHttpResponse.h"
 #include "Types/BinaryData.h"
 #include "Misc/Base64.h"
@@ -15,7 +16,7 @@
 
 template<typename T> FString USequenceRPCManager::GenerateIntent(T Data, TOptional<int64> CurrentTime) const
 {
-	const int64 Issued = CurrentTime.IsSet() ? CurrentTime.GetValue() : FDateTime::UtcNow().ToUnixTimestamp() - 30;
+	const int64 Issued = CurrentTime.IsSet() ? CurrentTime.GetValue() : (FDateTime::UtcNow() + TimeShift).ToUnixTimestamp() - 30;
 	const int64 Expires = Issued + 86400;
 	FGenericData * LocalDataPtr = &Data;
 	const FString Operation = LocalDataPtr->Operation;
@@ -269,26 +270,36 @@ void USequenceRPCManager::UpdateWithStoredSessionWallet()
 
 USequenceRPCManager* USequenceRPCManager::Make(const bool UseStoredSessionId)
 {
+	USequenceRPCManager* Manager = nullptr;
+	
 	if (UseStoredSessionId)
 	{
-		const USequenceAuthenticator * Authenticator = NewObject<USequenceAuthenticator>();
+		const USequenceAuthenticator* Authenticator = NewObject<USequenceAuthenticator>();
 		if (FStoredCredentials_BE StoredCredentials = Authenticator->GetStoredCredentials(); StoredCredentials.GetValid())
 		{
-			return Make(StoredCredentials.GetCredentials().GetSessionWallet());
+			Manager = Make(StoredCredentials.GetCredentials().GetSessionWallet());
 		}
 	}
-	return Make(UCryptoWallet::Make());
+	
+	if (!Manager)
+	{
+		Manager = Make(UCryptoWallet::Make());
+	}
+	
+	return Manager;
 }
 
 USequenceRPCManager* USequenceRPCManager::Make(UCryptoWallet* SessionWalletIn)
 {
-	USequenceRPCManager * SequenceRPCManager = NewObject<USequenceRPCManager>();
+	USequenceRPCManager* SequenceRPCManager = NewObject<USequenceRPCManager>();
 	SequenceRPCManager->SessionWallet = SessionWalletIn;
 	SequenceRPCManager->Validator = NewObject<UResponseSignatureValidator>();
 	FString ParsedJwt;
-	FBase64::Decode(UConfigFetcher::GetConfigVar(UConfigFetcher::WaaSConfigKey),ParsedJwt);
+	FBase64::Decode(UConfigFetcher::GetConfigVar(UConfigFetcher::WaaSConfigKey), ParsedJwt);
 	SequenceRPCManager->WaaSSettings = USequenceSupport::JSONStringToStruct<FWaasJWT>(ParsedJwt);
 	SequenceRPCManager->Cached_ProjectAccessKey = UConfigFetcher::GetConfigVar(UConfigFetcher::ProjectAccessKey);
+	
+	SequenceRPCManager->InitializeTimeShift();
 	return SequenceRPCManager;
 }
 
@@ -1088,3 +1099,50 @@ void USequenceRPCManager::FederateSessionInUse(const FString& WalletIn, const TF
 		return this->BuildFederateAccountIntent(FederateAccountData, CurrentTime);
 	}, OnFederateResponse, OnFailure);
 }
+
+void USequenceRPCManager::InitializeTimeShift()
+{
+	const FString WaasUrl = this->WaaSSettings.GetRPCServer();
+	const FString StatusUrl = WaasUrl.EndsWith(TEXT("/")) ? WaasUrl + TEXT("status") : WaasUrl + TEXT("/status");
+
+	TSharedRef<IHttpRequest, ESPMode::ThreadSafe> HttpRequest = FHttpModule::Get().CreateRequest();
+	HttpRequest->SetVerb(TEXT("GET"));
+	HttpRequest->SetURL(StatusUrl);
+	
+	HttpRequest->OnProcessRequestComplete().BindLambda([this](FHttpRequestPtr Request, FHttpResponsePtr Response, bool bSuccess)
+	{
+		if (bSuccess && Response.IsValid())
+		{
+			const FString DateHeader = Response->GetHeader(TEXT("date"));
+			if (!DateHeader.IsEmpty())
+			{
+				TimeShift = GetTimeShiftFromResponse(DateHeader);
+			}
+			else
+			{
+				UE_LOG(LogTemp, Warning, TEXT("No date header in response from status endpoint"));
+				TimeShift = FTimespan::Zero();
+			}
+		}
+		else
+		{
+			UE_LOG(LogTemp, Warning, TEXT("Failed to get server time for time shift calculation"));
+			TimeShift = FTimespan::Zero();
+		}
+	});
+
+	HttpRequest->ProcessRequest();
+}
+
+FTimespan USequenceRPCManager::GetTimeShiftFromResponse(const FString& DateHeader)
+{
+	FDateTime ServerTime;
+	if (FDateTime::ParseHttpDate(DateHeader, ServerTime))
+	{
+		const FDateTime LocalTime = FDateTime::UtcNow();
+		return ServerTime - LocalTime;
+	}
+	
+	UE_LOG(LogTemp, Warning, TEXT("Failed to parse server time from date header: %s"), *DateHeader);
+	return FTimespan::Zero();
+}

Plugins/SequencePlugin/Source/SequencePlugin/Private/SequenceRPCManager.h

@@ -119,6 +119,11 @@ class SEQUENCEPLUGIN_API USequenceRPCManager : public UObject
 	 */
 	void UpdateWithStoredSessionWallet();
 
+	FTimespan TimeShift;
+	
+	void InitializeTimeShift();
+	static FTimespan GetTimeShiftFromResponse(const FString& DateHeader);
+
 public:
 
 	UResponseSignatureValidator* Validator;