Skip to content

Commit b8dfba9

Browse files
committed
nullptr issue should be resolved when getting plugin version
1 parent b7d54df commit b8dfba9

2 files changed

Lines changed: 18 additions & 9 deletions

File tree

Plugins/SequencePlugin/Source/SequencePlugin/Private/SequenceRPCManager.cpp

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -100,16 +100,25 @@ void USequenceRPCManager::SendIntent(const FString& Url, TFunction<FString(TOpti
100100

101101
FString USequenceRPCManager::GetPluginVersion()
102102
{
103-
const TSharedPtr<IPlugin> Plugin = IPluginManager::Get().FindPlugin(TEXT("SequencePlugin"));
104-
if (Plugin.IsValid())
105-
{
106-
return Plugin->GetDescriptor().VersionName;
107-
}
108-
else
103+
// Get the PluginManager instance
104+
IPluginManager& PluginManager = IPluginManager::Get();
105+
106+
// Find the plugin by name
107+
TSharedPtr<IPlugin> SequencePlugin = PluginManager.FindPlugin(TEXT("SequencePlugin"));
108+
109+
// Check if the plugin was found
110+
if (SequencePlugin.IsValid())
109111
{
110-
UE_LOG(LogTemp, Error, TEXT("[Failed to find Sequence Plugin, Unknown version]"));
111-
return FString("UNKNOWN");
112+
// Retrieve the descriptor, which includes metadata such as the version
113+
const FPluginDescriptor& Descriptor = SequencePlugin->GetDescriptor();
114+
115+
// Return the version string
116+
return Descriptor.VersionName;
112117
}
118+
119+
// Return a default value if the plugin is not found
120+
UE_LOG(LogTemp, Error, TEXT("[Failed to find Sequence Plugin, Unknown version]"));
121+
return TEXT("Plugin not found");
113122
}
114123

115124
FString USequenceRPCManager::BuildGetFeeOptionsIntent(const FCredentials_BE& Credentials, const TArray<TransactionUnion>& Transactions, TOptional<int64> CurrentTime) const

Plugins/SequencePlugin/Source/SequencePlugin/Private/SequenceRPCManager.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ class SEQUENCEPLUGIN_API USequenceRPCManager : public UObject
5151
*/
5252
bool PreserveSessionWallet = false;
5353

54-
inline const static FString WaaSVersion = FString(TEXT("1.0.0 (Unreal ")).Append(USequenceRPCManager::GetPluginVersion()).Append(TEXT(")"));
54+
inline const static FString WaaSVersion = FString(TEXT("1.0.0 (Unreal ")).Append(GetPluginVersion()).Append(TEXT(")"));
5555

5656
inline const static FString WaaSAuthenticatorIntentsUrlPath = TEXT("/rpc/WaasAuthenticator/SendIntent");
5757
inline const static FString WaaSAuthenticatorRegisterUrlPath = TEXT("/rpc/WaasAuthenticator/RegisterSession");

0 commit comments

Comments
 (0)