Remove hasPermission. Check signer is in topology only

Author: ScreamingHawk

packages/wallet/dapp-client/src/ChainSessionManager.ts

@@ -696,38 +696,20 @@ export class ChainSessionManager {
   }
 
   /**
-   * Checks if the current session has permission to execute a set of transactions.
-   * @param transactions The transactions to check permissions for.
-   * @returns A promise that resolves to true if the session has permission, false otherwise.
+   * Checks if the current session has a valid signer.
+   * @returns A promise that resolves to true if the session has a valid signer, false otherwise.
    */
-  async hasPermission(transactions: Transaction[]): Promise<boolean> {
+  async hasValidSigner(): Promise<boolean> {
     if (!this.wallet || !this.sessionManager || !this.provider || !this.isInitialized) {
       return false
     }
 
-    try {
-      const calls: Payload.Call[] = transactions.map((tx) => ({
-        to: tx.to,
-        value: tx.value ?? 0n,
-        data: tx.data ?? '0x',
-        gasLimit: tx.gasLimit ?? 0n,
-        delegateCall: tx.delegateCall ?? false,
-        onlyFallback: tx.onlyFallback ?? false,
-        behaviorOnError: tx.behaviorOnError ?? ('revert' as const),
-      }))
-
-      // Directly check if there are signers with the necessary permissions for all calls.
-      // This will throw an error if any call is not supported.
-      await this.sessionManager.findSignersForCalls(this.wallet.address, this.chainId, calls)
+    const signerValidity = await this.sessionManager.listSignerValidity(this.chainId)
+    if (signerValidity.some((s) => s.isValid)) {
       return true
-    } catch (error) {
-      // An error from findSignersForCalls indicates a permission failure.
-      console.warn(
-        `Permission check failed for chain ${this.chainId}:`,
-        error instanceof Error ? error.message : String(error),
-      )
-      return false
     }
+    // SessionSignerInvalidReason available here
+    return false
   }
 
   /**

packages/wallet/dapp-client/src/DappClient.ts

@@ -544,17 +544,16 @@ export class DappClient {
   }
 
   /**
-   * Checks if the current session has permission to execute a set of transactions on a specific chain.
-   * @param chainId The chain ID on which to check the permissions.
-   * @param transactions An array of transactions to check permissions for.
-   * @returns A promise that resolves to true if the session has permission, otherwise false.
+   * Checks if the current session has a valid signer.
+   * @param chainId The chain ID on which to check the signer.
+   * @returns A promise that resolves to true if the session has a valid signer, otherwise false.
    */
-  async hasPermission(chainId: number, transactions: Transaction[]): Promise<boolean> {
+  async hasValidSigner(chainId: number): Promise<boolean> {
     const chainSessionManager = this.chainSessionManagers.get(chainId)
     if (!chainSessionManager || !chainSessionManager.isInitialized) {
       return false
     }
-    return await chainSessionManager.hasPermission(transactions)
+    return await chainSessionManager.hasValidSigner()
   }
 
   /**