Skip to content

Commit 3b6b3ba

Browse files
phrwlkoleonardolima
authored andcommitted
fix(esplora): deduplicate missing txids in fetch_txs_with_outpoints
1 parent bbe22de commit 3b6b3ba

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

crates/esplora/src/async_ext.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -501,7 +501,7 @@ where
501501

502502
// get outpoint spend-statuses
503503
let mut outpoints = outpoints.into_iter();
504-
let mut missing_txs = Vec::<Txid>::with_capacity(outpoints.len());
504+
let mut missing_txs = HashSet::<Txid>::with_capacity(outpoints.len());
505505
loop {
506506
let handles = outpoints
507507
.by_ref()
@@ -522,7 +522,7 @@ where
522522
None => continue,
523523
};
524524
if !inserted_txs.contains(&spend_txid) {
525-
missing_txs.push(spend_txid);
525+
missing_txs.insert(spend_txid);
526526
}
527527
if let Some(spend_status) = op_status.status {
528528
insert_anchor_or_seen_at_from_status(

crates/esplora/src/blocking_ext.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -457,7 +457,7 @@ fn fetch_txs_with_outpoints<I: IntoIterator<Item = OutPoint>>(
457457

458458
// get outpoint spend-statuses
459459
let mut outpoints = outpoints.into_iter();
460-
let mut missing_txs = Vec::<Txid>::with_capacity(outpoints.len());
460+
let mut missing_txs = HashSet::<Txid>::with_capacity(outpoints.len());
461461
loop {
462462
let handles = outpoints
463463
.by_ref()
@@ -483,7 +483,7 @@ fn fetch_txs_with_outpoints<I: IntoIterator<Item = OutPoint>>(
483483
None => continue,
484484
};
485485
if !inserted_txs.contains(&spend_txid) {
486-
missing_txs.push(spend_txid);
486+
missing_txs.insert(spend_txid);
487487
}
488488
if let Some(spend_status) = op_status.status {
489489
insert_anchor_or_seen_at_from_status(

0 commit comments

Comments
 (0)