Skip to content

Commit 0903bac

Browse files
Check Create_At in the test
1 parent 32360d8 commit 0903bac

1 file changed

Lines changed: 17 additions & 9 deletions

File tree

pkg/onepassword/client/sdk/sdk_test.go

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"context"
55
"errors"
66
"testing"
7+
"time"
78

89
"github.com/stretchr/testify/mock"
910
"github.com/stretchr/testify/require"
@@ -191,8 +192,8 @@ func TestSDK_GetFileContent(t *testing.T) {
191192
}
192193
}
193194

194-
// TODO: check CreatedAt as soon as a new SDK version returns it
195195
func TestSDK_GetVaultsByTitle(t *testing.T) {
196+
now := time.Now()
196197
testCases := map[string]struct {
197198
mockVaultAPI func() *clientmock.VaultAPIMock
198199
check func(t *testing.T, vaults []model.Vault, err error)
@@ -202,12 +203,14 @@ func TestSDK_GetVaultsByTitle(t *testing.T) {
202203
m := &clientmock.VaultAPIMock{}
203204
m.On("List", context.Background()).Return([]sdk.VaultOverview{
204205
{
205-
ID: "test-id",
206-
Title: VaultTitleEmployee,
206+
ID: "test-id",
207+
Title: VaultTitleEmployee,
208+
CreatedAt: now,
207209
},
208210
{
209-
ID: "test-id-2",
210-
Title: "Some other vault",
211+
ID: "test-id-2",
212+
Title: "Some other vault",
213+
CreatedAt: now,
211214
},
212215
}, nil)
213216
return m
@@ -216,19 +219,22 @@ func TestSDK_GetVaultsByTitle(t *testing.T) {
216219
require.NoError(t, err)
217220
require.Len(t, vaults, 1)
218221
require.Equal(t, "test-id", vaults[0].ID)
222+
require.Equal(t, now, vaults[0].CreatedAt)
219223
},
220224
},
221225
"should return a two vaults": {
222226
mockVaultAPI: func() *clientmock.VaultAPIMock {
223227
m := &clientmock.VaultAPIMock{}
224228
m.On("List", context.Background()).Return([]sdk.VaultOverview{
225229
{
226-
ID: "test-id",
227-
Title: VaultTitleEmployee,
230+
ID: "test-id",
231+
Title: VaultTitleEmployee,
232+
CreatedAt: now,
228233
},
229234
{
230-
ID: "test-id-2",
231-
Title: VaultTitleEmployee,
235+
ID: "test-id-2",
236+
Title: VaultTitleEmployee,
237+
CreatedAt: now,
232238
},
233239
}, nil)
234240
return m
@@ -238,8 +244,10 @@ func TestSDK_GetVaultsByTitle(t *testing.T) {
238244
require.Len(t, vaults, 2)
239245
// Check the first vault
240246
require.Equal(t, "test-id", vaults[0].ID)
247+
require.Equal(t, now, vaults[0].CreatedAt)
241248
// Check the second vault
242249
require.Equal(t, "test-id-2", vaults[1].ID)
250+
require.Equal(t, now, vaults[1].CreatedAt)
243251
},
244252
},
245253
"should return an error": {

0 commit comments

Comments
 (0)