more robust add_actor_component()

Roberto De Ioris · Roberto De Ioris · commit 6b508d536a48 · 2017-07-07T19:36:05.000+02:00
diff --git a/Source/UnrealEnginePython/Private/UObject/UEPyActor.cpp b/Source/UnrealEnginePython/Private/UObject/UEPyActor.cpp
@@ -336,6 +336,12 @@ PyObject *py_ue_add_actor_component(ue_PyUObject * self, PyObject * args) {
 		return PyErr_Format(PyExc_Exception, "argument is not a UClass");
 	}
 
+	UClass *u_class = (UClass *)py_obj->ue_object;
+
+	if (!u_class->IsChildOf<UActorComponent>()) {
+		return PyErr_Format(PyExc_Exception, "argument is not a UClass derived from AActor");
+	}
+
 	USceneComponent *parent_component = nullptr;
 
 	if (py_parent) {
@@ -345,7 +351,7 @@ PyObject *py_ue_add_actor_component(ue_PyUObject * self, PyObject * args) {
 		}
 	}
 
-	UActorComponent *component = NewObject<UActorComponent>(actor, (UClass *)py_obj->ue_object, FName(UTF8_TO_TCHAR(name)));
+	UActorComponent *component = NewObject<UActorComponent>(actor, u_class, FName(UTF8_TO_TCHAR(name)));
 	if (!component)
 		return PyErr_Format(PyExc_Exception, "unable to create component");
 

Original file line number	Diff line number	Diff line change
`@@ -336,6 +336,12 @@ PyObject py_ue_add_actor_component(ue_PyUObject self, PyObject * args) {`
`336`	`336`	`return PyErr_Format(PyExc_Exception, "argument is not a UClass");`
`337`	`337`	`}`
`338`	`338`
	`339`	`+ UClass u_class = (UClass )py_obj->ue_object;`
	`340`	`+`
	`341`	`+ if (!u_class->IsChildOf<UActorComponent>()) {`
	`342`	`+ return PyErr_Format(PyExc_Exception, "argument is not a UClass derived from AActor");`
	`343`	`+ }`
	`344`	`+`
`339`	`345`	`USceneComponent *parent_component = nullptr;`
`340`	`346`
`341`	`347`	`if (py_parent) {`
`@@ -345,7 +351,7 @@ PyObject py_ue_add_actor_component(ue_PyUObject self, PyObject * args) {`
`345`	`351`	`}`
`346`	`352`	`}`
`347`	`353`
`348`		`- UActorComponent component = NewObject<UActorComponent>(actor, (UClass )py_obj->ue_object, FName(UTF8_TO_TCHAR(name)));`
	`354`	`+ UActorComponent *component = NewObject<UActorComponent>(actor, u_class, FName(UTF8_TO_TCHAR(name)));`
`349`	`355`	`if (!component)`
`350`	`356`	`return PyErr_Format(PyExc_Exception, "unable to create component");`
`351`	`357`