Fix all CI lint errors, critical bugs, and deprecation warnings

- Fix unused imports across client.py, handler.py, gui.py, config.py, main.py, logger.py, web/gui.py
- Fix unused variables (key, model_str, thinking_msg, bs) in handler.py and web/gui.py
- Fix line length violations (>120 chars) in handler.py and gui.py
- Fix import sorting (I001) and collections.abc imports (UP035)
- Replace try-except-pass with contextlib.suppress (SIM105)
- Fix file handle leaks with proper context managers (SIM115)
- Replace deprecated datetime.utcnow() with datetime.now(timezone.utc)
- Fix double ApplicationBuilder bug in main.py
- Fix stdout pipe deadlock risk in server.py (DEVNULL instead of PIPE)
- Fix wrong cache key (all -> providers) in handler.py
- Replace blocking time.sleep() with non-blocking Tkinter after() in gui.py

Author: 2241812

src/opencode_telegram_bot/api/client.py

@@ -2,7 +2,8 @@
 
 import json
 import logging
-from typing import Any, AsyncGenerator
+from collections.abc import AsyncGenerator
+from typing import Any
 
 import httpx
 

src/opencode_telegram_bot/api/server.py

@@ -35,7 +35,7 @@ def start(self, port: int = 4096) -> None:
         self._process = subprocess.Popen(
             [self.command, "serve", "--port", str(port)],
             cwd=self.work_dir,
-            stdout=subprocess.PIPE,
+            stdout=subprocess.DEVNULL,
             stderr=subprocess.STDOUT,
             text=True,
         )

src/opencode_telegram_bot/bot/handler.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import asyncio
+import contextlib
 import logging
 import os
 import tempfile
@@ -15,11 +16,7 @@
     Update,
 )
 from telegram.ext import (
-    CallbackQueryHandler,
-    CommandHandler,
     ContextTypes,
-    MessageHandler,
-    filters,
 )
 
 from opencode_telegram_bot.api import OpenCodeClient, OpenCodeServer
@@ -146,21 +143,15 @@ async def _ensure_session(self) -> str:
 
     async def _cache_metadata(self) -> None:
         if not self._cached_providers:
-            try:
+            with contextlib.suppress(Exception):
                 providers_data = await self.client.get_providers()
-                self._cached_providers = providers_data.get("all", [])
-            except Exception:
-                pass
+                self._cached_providers = providers_data.get("providers", [])
         if not self._cached_agents:
-            try:
+            with contextlib.suppress(Exception):
                 self._cached_agents = await self.client.get_agents()
-            except Exception:
-                pass
         if not self._cached_commands:
-            try:
+            with contextlib.suppress(Exception):
                 self._cached_commands = await self.client.get_commands()
-            except Exception:
-                pass
 
     async def cmd_start(self, update: Update, context: ContextTypes.DEFAULT_TYPE) -> None:
         if not self._is_authorized(update.effective_user.id):
@@ -296,7 +287,6 @@ async def cmd_mode(self, update: Update, context: ContextTypes.DEFAULT_TYPE) ->
         current = self.bot_settings.get("agent_mode", "build")
         new_mode = "plan" if current == "build" else "build"
         self.bot_settings.set("agent_mode", new_mode)
-        key = "mode_plan" if new_mode == "plan" else "mode_build"
         await update.message.reply_text(t("mode_switched", locale=self._locale(), mode=new_mode.capitalize()))
 
     async def cmd_models(self, update: Update, context: ContextTypes.DEFAULT_TYPE) -> None:
@@ -410,8 +400,11 @@ async def callback_handler(self, update: Update, context: ContextTypes.DEFAULT_T
             parts = data.split(":", 2)
             provider = parts[1]
             model_id = parts[2]
-            model_str = f"{provider}/{model_id}" if model_id else provider
-            await self._send(context, chat_id, t("model_switched", locale=self._locale(), provider=provider, model=model_id or "default"))
+            await self._send(
+                context, chat_id,
+                t("model_switched", locale=self._locale(),
+                  provider=provider, model=model_id or "default"),
+            )
 
         elif data.startswith("runcmd:"):
             command = data.split(":", 1)[1]
@@ -498,7 +491,7 @@ async def _process_prompt(
             await self._send(context, chat_id, t("error", locale=self._locale(), message=str(e)))
             return
 
-        thinking_msg = await self._send(context, chat_id, t("thinking", locale=self._locale()))
+        await self._send(context, chat_id, t("thinking", locale=self._locale()))
 
         try:
             agent_mode = self.bot_settings.get("agent_mode", "build")
@@ -517,25 +510,34 @@ async def _process_prompt(
 
             if response_text:
                 if len(response_text) > 4000:
-                    with tempfile.NamedTemporaryFile(suffix=".txt", delete=False, mode="w", encoding="utf-8") as f:
+                    with tempfile.NamedTemporaryFile(
+                        suffix=".txt", delete=False, mode="w", encoding="utf-8",
+                    ) as f:
                         f.write(response_text)
                         f.flush()
-                    await context.bot.send_document(
-                        chat_id=chat_id,
-                        document=open(f.name, "rb"),
-                        filename="response.txt",
-                    )
-                    os.unlink(f.name)
+                        tmp_path = f.name
+                    with open(tmp_path, "rb") as doc:
+                        await context.bot.send_document(
+                            chat_id=chat_id,
+                            document=doc,
+                            filename="response.txt",
+                        )
+                    os.unlink(tmp_path)
                 else:
                     await self._send(context, chat_id, response_text)
 
                 if self.bot_settings.tts_enabled and self.tts.is_configured:
                     audio = await self.tts.synthesize(response_text[:4000])
                     if audio:
-                        with tempfile.NamedTemporaryFile(suffix=".mp3", delete=False) as f:
+                        with tempfile.NamedTemporaryFile(
+                            suffix=".mp3", delete=False,
+                        ) as f:
                             f.write(audio)
                             audio_path = f.name
-                        await context.bot.send_voice(chat_id=chat_id, voice=open(audio_path, "rb"))
+                        with open(audio_path, "rb") as voice_file:
+                            await context.bot.send_voice(
+                                chat_id=chat_id, voice=voice_file,
+                            )
                         os.unlink(audio_path)
             else:
                 raw = str(response)[:4000]

src/opencode_telegram_bot/core/__init__.py

@@ -1,4 +1,4 @@
-from .config import Settings, BotSettings
+from .config import BotSettings, Settings
 from .session import SessionManager
 
 __all__ = ["Settings", "BotSettings", "SessionManager"]

src/opencode_telegram_bot/core/config.py

@@ -5,7 +5,6 @@
 from pathlib import Path
 from typing import Any
 
-from pydantic import BaseModel, Field
 from pydantic_settings import BaseSettings, SettingsConfigDict
 
 logger = logging.getLogger(__name__)

src/opencode_telegram_bot/core/session.py

@@ -2,7 +2,7 @@
 
 import json
 import logging
-from datetime import datetime
+from datetime import datetime, timezone
 from pathlib import Path
 from typing import Any
 
@@ -30,17 +30,18 @@ def _save(self) -> None:
         self._file.write_text(json.dumps(self._sessions, indent=2), encoding="utf-8")
 
     def add(self, session_id: str, metadata: dict[str, Any]) -> None:
+        now = datetime.now(timezone.utc).isoformat()
         self._sessions[session_id] = {
             **metadata,
-            "created_at": datetime.utcnow().isoformat(),
-            "updated_at": datetime.utcnow().isoformat(),
+            "created_at": now,
+            "updated_at": now,
         }
         self._save()
 
     def update(self, session_id: str, metadata: dict[str, Any]) -> None:
         if session_id in self._sessions:
             self._sessions[session_id].update(metadata)
-            self._sessions[session_id]["updated_at"] = datetime.utcnow().isoformat()
+            self._sessions[session_id]["updated_at"] = datetime.now(timezone.utc).isoformat()
             self._save()
 
     def remove(self, session_id: str) -> None: