Add webpack 5 support; fixes #92 (#97)

* Add webpack 5 support; fixes #92

* Re-record test fixtures; test both versions 4 and 5 to ensure backwards compatibility

Co-authored-by: Zach Schneider <zach@schneider.dev>

Author: MayaWolf

.tav.yml

@@ -0,0 +1,9 @@
+webpack-4:
+  name: webpack
+  versions: 4.41.6
+  commands: jest
+
+webpack-5:
+  name: webpack
+  versions: 5.0.0-beta.13
+  commands: jest

.travis.yml

@@ -3,4 +3,4 @@ node_js:
   - "node"
 script:
   - yarn lint
-  - yarn test
+  - yarn test:tav

package-scripts.js

@@ -27,6 +27,15 @@ module.exports = {
     'test:record': {
       description: 'Run tests + regenerate fixtures with real Sentry instance',
       script: 'rm ./test/fixtures/replayer/* && VCR_MODE=record jest'
+    },
+    'test:tav': {
+      description: 'Run tests against all supported major versions',
+      script: 'VCR_MODE=playback tav'
+    },
+    'test:tav:record': {
+      description:
+        'Run tests against all supported major versions + regenerate fixtures',
+      script: 'VCR_MODE=record tav'
     }
   }
 }

package.json

@@ -21,6 +21,8 @@
     "lint": "nps lint",
     "test": "nps test",
     "test:record": "nps test:record",
+    "test:tav": "nps test:tav",
+    "test:tav:record": "nps test:tav:record",
     "validate": "nps validate",
     "prepublish": "nps prepublish",
     "precommit": "opt --in pre-commit --exec \"nps format lint\"",
@@ -62,7 +64,8 @@
     "prettier": "^1.11.1",
     "prettier-eslint-cli": "^4.7.1",
     "replayer": "^2.2.3",
-    "webpack": "^4.5.0"
+    "test-all-versions": "^4.1.1",
+    "webpack": "^5.0.0-beta.13"
   },
   "peerDependencies": {
     "webpack": "^4 || ^5.0.0-alpha.11"

src/index.js

@@ -1,5 +1,6 @@
 import request from 'request-promise'
 import fs from 'fs'
+import path from 'path'
 import PromisePool from 'es6-promise-pool'
 
 const BASE_SENTRY_URL = 'https://sentry.io/api/0'
@@ -146,11 +147,19 @@ module.exports = class SentryPlugin {
     }
   }
 
+  // eslint-disable-next-line class-methods-use-this
+  getAssetPath(compilation, name) {
+    return path.join(
+      compilation.getPath(compilation.compiler.outputPath),
+      name.split('?')[0]
+    )
+  }
+
   getFiles(compilation) {
     return Object.keys(compilation.assets)
       .map((name) => {
         if (this.isIncludeOrExclude(name)) {
-          return { name, filePath: compilation.assets[name].existsAt }
+          return { name, filePath: this.getAssetPath(compilation, name) }
         }
         return null
       })
@@ -238,7 +247,7 @@ module.exports = class SentryPlugin {
     Object.keys(stats.compilation.assets)
       .filter(name => this.deleteRegex.test(name))
       .forEach((name) => {
-        const filePath = stats.compilation.assets[name].existsAt
+        const filePath = this.getAssetPath(stats.compilation, name)
         if (filePath) {
           fs.unlinkSync(filePath)
         }

test/errors.test.js

@@ -1,3 +1,4 @@
+import { expectWebpackError } from './helpers/assertion'
 import { createWebpackConfig, runWebpack } from './helpers/webpack'
 
 jest.mock('request-promise')
@@ -6,7 +7,8 @@ it('adds error if Sentry organization slug is missing', () =>
   runWebpack(createWebpackConfig({ organization: null })).catch(
     ({ errors }) => {
       expect(errors).toHaveLength(1)
-      expect(errors[0]).toEqual(
+      expectWebpackError(
+        errors[0],
         'Sentry Plugin: Error: Must provide organization'
       )
     }
@@ -15,19 +17,20 @@ it('adds error if Sentry organization slug is missing', () =>
 it('adds error if Sentry project name is missing', () =>
   runWebpack(createWebpackConfig({ project: null })).catch(({ errors }) => {
     expect(errors).toHaveLength(1)
-    expect(errors[0]).toEqual('Sentry Plugin: Error: Must provide project')
+    expectWebpackError(errors[0], 'Sentry Plugin: Error: Must provide project')
   }))
 
 it('adds error if Sentry api key is missing', () =>
   runWebpack(createWebpackConfig({ apiKey: null })).catch(({ errors }) => {
     expect(errors).toHaveLength(1)
-    expect(errors[0]).toEqual('Sentry Plugin: Error: Must provide api key')
+    expectWebpackError(errors[0], 'Sentry Plugin: Error: Must provide api key')
   }))
 
 it('adds error if release version is missing', () =>
   runWebpack(createWebpackConfig()).catch(({ errors }) => {
     expect(errors).toHaveLength(1)
-    expect(errors[0]).toEqual(
+    expectWebpackError(
+      errors[0],
       'Sentry Plugin: Error: Must provide release version'
     )
   }))
@@ -36,14 +39,20 @@ it('adds release error to compilation', () =>
   runWebpack(createWebpackConfig({ release: 'bad-release' })).catch(
     ({ errors }) => {
       expect(errors).toHaveLength(1)
-      expect(errors[0]).toEqual('Sentry Plugin: Error: Release request error')
+      expectWebpackError(
+        errors[0],
+        'Sentry Plugin: Error: Release request error'
+      )
     }
   ))
 
 it('adds upload error to compilation', () =>
   runWebpack(createWebpackConfig({ release: 'bad-upload' })).catch(
     ({ errors }) => {
       expect(errors).toHaveLength(1)
-      expect(errors[0]).toEqual('Sentry Plugin: Error: Upload request error')
+      expectWebpackError(
+        errors[0],
+        'Sentry Plugin: Error: Upload request error'
+      )
     }
   ))