Skip to content

Commit 53efc7d

Browse files
committed
♻️ Change reference to HttpHeaders to be fully qualified
This is preparation for adding an HttpHeaders class to RestClient interface.
1 parent e0de5b1 commit 53efc7d

2 files changed

Lines changed: 10 additions & 13 deletions

File tree

  • rest-services/jersey-client/src/main/java/com/_4point/aem/docservices/rest_services/client/jersey
  • spring/fluentforms-spring-boot-autoconfigure/src/main/java/com/_4point/aem/fluentforms/spring/rest_services/client

rest-services/jersey-client/src/main/java/com/_4point/aem/docservices/rest_services/client/jersey/JerseyRestClient.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import jakarta.ws.rs.client.ClientBuilder;
2323
import jakarta.ws.rs.client.Entity;
2424
import jakarta.ws.rs.client.WebTarget;
25-
import jakarta.ws.rs.core.HttpHeaders;
2625
import jakarta.ws.rs.core.MediaType;
2726
import jakarta.ws.rs.core.Response.Status;
2827
import jakarta.ws.rs.core.Response.Status.Family;
@@ -122,7 +121,7 @@ private static Optional<Response> processResponse(jakarta.ws.rs.core.Response re
122121
throw new RestClientException("Call to server succeeded but server failed to return content. This should never happen.");
123122
}
124123

125-
String responseContentType = response.getHeaderString(HttpHeaders.CONTENT_TYPE);
124+
String responseContentType = response.getHeaderString(jakarta.ws.rs.core.HttpHeaders.CONTENT_TYPE);
126125
if ( responseContentType == null || !expectedMediaType.isCompatible(MediaType.valueOf(responseContentType))) {
127126
String msg = "Response from AEM server was not of expected type (" + expectedMediaType.toString() + "). " + (responseContentType != null ? "content-type='" + responseContentType + "'" : "content-type was null") + ".";
128127
InputStream entityStream = (InputStream) response.getEntity();

spring/fluentforms-spring-boot-autoconfigure/src/main/java/com/_4point/aem/fluentforms/spring/rest_services/client/SpringRestClientRestClient.java

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import org.springframework.core.io.ByteArrayResource;
1414
import org.springframework.core.io.InputStreamResource;
1515
import org.springframework.http.HttpEntity;
16-
import org.springframework.http.HttpHeaders;
1716
import org.springframework.http.HttpStatus;
1817
import org.springframework.http.MediaType;
1918
import org.springframework.http.ResponseEntity;
@@ -87,7 +86,7 @@ private static String getTarget(AemConfig aemConfig, String additionalPath) {
8786

8887
private abstract class SpringClientRequestBuilder {
8988
protected Function<UriBuilder, UriBuilder> uriBuilder = Function.identity();
90-
protected Consumer<HttpHeaders> headerBuilder = correlationIdFn != null ? h->h.put(RestClient.CORRELATION_ID_HTTP_HDR, List.of(correlationIdFn.get()))
89+
protected Consumer<org.springframework.http.HttpHeaders> headerBuilder = correlationIdFn != null ? h->h.put(RestClient.CORRELATION_ID_HTTP_HDR, List.of(correlationIdFn.get()))
9190
: __->{}; // if correlationIdFn is available, use it as the base headerBuilder function.
9291

9392
public void addQueryParam(String name, String value) {
@@ -101,9 +100,9 @@ public void addHeaderValue(String name, String value) {
101100

102101
private abstract static class SpringClientRequest {
103102
private final Function<UriBuilder, UriBuilder> uriBuilder;
104-
private final Consumer<HttpHeaders> headerBuilder;
103+
private final Consumer<org.springframework.http.HttpHeaders> headerBuilder;
105104

106-
protected SpringClientRequest(Function<UriBuilder, UriBuilder> uriBuilder, Consumer<HttpHeaders> headerBuilder) {
105+
protected SpringClientRequest(Function<UriBuilder, UriBuilder> uriBuilder, Consumer<org.springframework.http.HttpHeaders> headerBuilder) {
107106
this.uriBuilder = uriBuilder;
108107
this.headerBuilder = headerBuilder;
109108
}
@@ -137,13 +136,13 @@ protected Optional<Response> processRequest(RequestHeadersSpec<?> request, Conte
137136

138137
private static class SpringClientResponse implements RestClient.Response {
139138
private final ResponseEntity<byte[]> responseEntity;
140-
private final HttpHeaders headers;
139+
private final org.springframework.http.HttpHeaders headers;
141140

142141
private SpringClientResponse(ResponseEntity<byte[]> responseEntity) {
143142
this(responseEntity, responseEntity.getHeaders());
144143
}
145144

146-
private SpringClientResponse(ResponseEntity<byte[]> responseEntity, HttpHeaders headers) {
145+
private SpringClientResponse(ResponseEntity<byte[]> responseEntity, org.springframework.http.HttpHeaders headers) {
147146
this.responseEntity = responseEntity;
148147
this.headers = headers;
149148
}
@@ -177,7 +176,7 @@ private static MediaType toMediaType(ContentType contentType) {
177176
public final class SpringRestClientMultipartPayload extends SpringClientRequest implements MultipartPayload {
178177
private final MultiValueMap<String, HttpEntity<?>> multipartBody;
179178

180-
private SpringRestClientMultipartPayload(Function<UriBuilder, UriBuilder> uriBuilder, Consumer<HttpHeaders> headerBuilder, MultiValueMap<String, HttpEntity<?>> multipartBody) {
179+
private SpringRestClientMultipartPayload(Function<UriBuilder, UriBuilder> uriBuilder, Consumer<org.springframework.http.HttpHeaders> headerBuilder, MultiValueMap<String, HttpEntity<?>> multipartBody) {
181180
super(uriBuilder, headerBuilder);
182181
this.multipartBody = multipartBody;
183182
}
@@ -203,9 +202,8 @@ public void close() throws IOException {
203202
private final class RestClientMultipartPayloadBuilder extends SpringClientRequestBuilder implements MultipartPayload.Builder {
204203
private final MultiValueMap<String, HttpEntity<?>> parts = new LinkedMultiValueMap<>();
205204

206-
@SuppressWarnings("serial")
207205
private void internalAdd(String fieldName, Object fieldData, MediaType contentType) {
208-
parts.add(fieldName, new HttpEntity<>(fieldData, new HttpHeaders() {
206+
parts.add(fieldName, new HttpEntity<>(fieldData, new org.springframework.http.HttpHeaders() {
209207
{
210208
setContentType(contentType);
211209
}
@@ -250,7 +248,7 @@ public Builder addHeader(String name, String value) {
250248

251249
private class SpringClientGetRequest extends SpringClientRequest implements RestClient.GetRequest {
252250

253-
private SpringClientGetRequest(Function<UriBuilder, UriBuilder> uriBuilder, Consumer<HttpHeaders> headerBuilder) {
251+
private SpringClientGetRequest(Function<UriBuilder, UriBuilder> uriBuilder, Consumer<org.springframework.http.HttpHeaders> headerBuilder) {
254252
super(uriBuilder, headerBuilder);
255253
}
256254

@@ -269,7 +267,7 @@ public Optional<Response> getFromServer(ContentType acceptContentType) throws Re
269267

270268
private class SpringClientGetRequestBuilder extends SpringClientRequestBuilder implements RestClient.GetRequest.Builder {
271269
// private Function<UriBuilder, UriBuilder> uriBuilder = Function.identity();
272-
// private Consumer<HttpHeaders> headerBuilder = correlationIdFn != null ? h->h.put(RestClient.CORRELATION_ID_HTTP_HDR, List.of(correlationIdFn.get()))
270+
// private Consumer<org.springframework.http.HttpHeaders> headerBuilder = correlationIdFn != null ? h->h.put(RestClient.CORRELATION_ID_HTTP_HDR, List.of(correlationIdFn.get()))
273271
// : __->{}; // if correlationIdFn is available, use it as the base headerBuilder function.
274272

275273
private SpringClientGetRequestBuilder() {

0 commit comments

Comments
 (0)