[DURACOM-474] Fix

Author: AdamF42

dspace-api/src/main/java/org/dspace/app/customurl/consumer/CustomUrlConsumer.java

@@ -288,7 +288,18 @@ private String extractMetadataValue(Item item, String metadataFieldName) {
      */
     private void assignCustomUrlToItem(Context context, Item item, String customUrl) {
         log.info("Assigning custom URL '{}' to item {}", customUrl, item.getID());
-        customUrlService.replaceCustomUrl(context, item, customUrl);
+        // Evict and re-fetch the item to ensure a clean managed entity.
+        // During event dispatch the item may have detached associations
+        // that cause "detached entity passed to persist" errors.
+        try {
+            context.uncacheEntity(item);
+            Item managedItem = itemService.find(context, item.getID());
+            if (managedItem != null) {
+                customUrlService.replaceCustomUrl(context, managedItem, customUrl);
+            }
+        } catch (SQLException e) {
+            throw new RuntimeException("Failed to reload item " + item.getID(), e);
+        }
     }
 
     /**

dspace-api/src/main/java/org/dspace/app/customurl/service/CustomUrlServiceImpl.java

@@ -77,19 +77,8 @@ public List<String> getAllCustomUrls(Item item) {
     @Override
     public void replaceCustomUrl(Context context, Item item, String newUrl) {
         try {
-            // Ensure the item is fully managed by the current Hibernate session.
-            // The item received from event consumers may reference a detached entity
-            // (e.g., after a context.uncacheEntity/reloadEntity cycle in the caller),
-            // which would cause a "detached entity passed to persist" error
-            // when creating new MetadataValue objects. Evicting and re-fetching
-            // guarantees a clean, fully-managed entity.
-            context.uncacheEntity(item);
-            Item managedItem = itemService.find(context, item.getID());
-            if (managedItem == null) {
-                return;
-            }
-            itemService.clearMetadata(context, managedItem, "dspace", "customurl", null, ANY);
-            itemService.addMetadata(context, managedItem, "dspace", "customurl", null, null, newUrl);
+            itemService.clearMetadata(context, item, "dspace", "customurl", null, ANY);
+            itemService.addMetadata(context, item, "dspace", "customurl", null, null, newUrl);
         } catch (SQLException e) {
             throw new SQLRuntimeException(e);
         }