[DSC-2059] Fix unintentional changes

Author: atarix83

src/app/shared/context-menu/audit-item/audit-item-menu.component.ts

@@ -10,13 +10,10 @@ import {
 import { RouterLink } from '@angular/router';
 import { TranslateModule } from '@ngx-translate/core';
 import {
+  BehaviorSubject,
   combineLatest,
-  Observable,
 } from 'rxjs';
-import {
-  map,
-  take,
-} from 'rxjs/operators';
+import { take } from 'rxjs/operators';
 
 import { AuthorizationDataService } from '../../../core/data/feature-authorization/authorization-data.service';
 import { FeatureID } from '../../../core/data/feature-authorization/feature-id';
@@ -41,7 +38,7 @@ import { ContextMenuEntryType } from '../context-menu-entry-type';
 })
 export class AuditItemMenuComponent extends ContextMenuEntryComponent implements OnInit {
 
-  public isAuthorized$: Observable<boolean>;
+  public isAuthorized$: BehaviorSubject<boolean> =  new BehaviorSubject<boolean>(false);
 
   constructor(
     @Inject('contextMenuObjectProvider') protected injectedContextMenuObject: DSpaceObject,
@@ -52,15 +49,16 @@ export class AuditItemMenuComponent extends ContextMenuEntryComponent implements
   }
 
   ngOnInit(): void {
-    this.isAuthorized$ = combineLatest(
+    combineLatest(
       [
         this.authorizationService.isAuthorized(FeatureID.AdministratorOf),
         this.authorizationService.isAuthorized(FeatureID.IsCollectionAdmin),
         this.authorizationService.isAuthorized(FeatureID.IsCommunityAdmin),
       ],
     ).pipe(
       take(1),
-      map(([isAdmin, isCollectionAdmin, isCommunityAdmin]) => isAdmin || isCollectionAdmin || isCommunityAdmin),
-    );
+    ).subscribe(([isAdmin, isCollectionAdmin, isCommunityAdmin]) => {
+      this.isAuthorized$.next(isAdmin || isCommunityAdmin || isCollectionAdmin);
+    });
   }
 }

src/app/shared/context-menu/bulk-import/bulk-import-menu.component.ts

@@ -10,6 +10,7 @@ import {
 import { RouterLink } from '@angular/router';
 import { TranslateModule } from '@ngx-translate/core';
 import { Observable } from 'rxjs';
+import { switchMap } from 'rxjs/operators';
 
 import { getBulkImportRoute } from '../../../app-routing-paths';
 import { AuthorizationDataService } from '../../../core/data/feature-authorization/authorization-data.service';
@@ -56,7 +57,9 @@ export class BulkImportMenuComponent extends ContextMenuEntryComponent implement
     super(injectedContextMenuObject, injectedContextMenuObjectType, ContextMenuEntryType.BulkImport);
   }
   ngOnInit() {
-    this.isCollectionAdmin$ = this.isCollectionAdmin(false);
+    this.isCollectionAdmin$ = this.notificationService.claimedProfile.pipe(
+      switchMap(() => this.isCollectionAdmin(false)),
+    );
   }
 
   /**

src/app/shared/context-menu/export-collection/export-collection-menu.component.ts

@@ -13,6 +13,7 @@ import {
   TranslateService,
 } from '@ngx-translate/core';
 import { Observable } from 'rxjs';
+import { switchMap } from 'rxjs/operators';
 
 import { AuthorizationDataService } from '../../../core/data/feature-authorization/authorization-data.service';
 import { FeatureID } from '../../../core/data/feature-authorization/feature-id';
@@ -74,7 +75,9 @@ export class ExportCollectionMenuComponent extends ContextMenuEntryComponent imp
   }
 
   ngOnInit() {
-    this.isCollectionAdmin$ = this.isCollectionAdmin(false);
+    this.isCollectionAdmin$ = this.notificationService.claimedProfile.pipe(
+      switchMap(() => this.isCollectionAdmin(false)),
+    );
   }
 
   /**

src/app/shared/context-menu/export-item/export-item-menu.component.html

@@ -1,4 +1,4 @@
-<button class="btn btn-primary" *ngIf="(configuration | async)?.formats?.length > 0"
+<button class="btn btn-primary" *ngIf="(configuration$ | async)?.formats?.length > 0"
         [innerHTML]="'context-menu.actions.export-item.btn' | translate"
         (click)="$event.preventDefault();openExportModal();">
 </button>

src/app/shared/context-menu/export-item/export-item-menu.component.spec.ts

@@ -92,7 +92,7 @@ describe('ExportItemMenuComponent', () => {
   it('should render a button', () => {
     fixture.detectChanges();
     const testConfig = { ...configuration, formats: [{ type: null, id: '1', mimeType: '1', entityType: 'Patent', molteplicity: '1', _links: null }] };
-    component.configuration = of(testConfig);
+    component.configuration$.next(testConfig);
     fixture.detectChanges();
     const link = fixture.debugElement.query(By.css('button'));
     expect(link).not.toBeNull();

src/app/shared/context-menu/export-item/export-item-menu.component.ts

@@ -9,10 +9,7 @@ import {
 } from '@angular/core';
 import { NgbModal } from '@ng-bootstrap/ng-bootstrap';
 import { TranslateModule } from '@ngx-translate/core';
-import {
-  Observable,
-  of,
-} from 'rxjs';
+import { BehaviorSubject } from 'rxjs/internal/BehaviorSubject';
 import { take } from 'rxjs/operators';
 
 import { ItemExportFormatMolteplicity } from '../../../core/itemexportformat/item-export-format.service';
@@ -50,7 +47,8 @@ export class ExportItemMenuComponent extends ContextMenuEntryComponent implement
   /**
    * Type of configuration in current component
    */
-  configuration: Observable<ItemExportFormConfiguration> = of(null);
+  configuration$: BehaviorSubject<ItemExportFormConfiguration> = new BehaviorSubject<ItemExportFormConfiguration>(null);
+
   constructor(
     @Inject('contextMenuObjectProvider') protected injectedContextMenuObject: DSpaceObject,
     @Inject('contextMenuObjectTypeProvider') protected injectedContextMenuObjectType: DSpaceObjectType,
@@ -62,7 +60,8 @@ export class ExportItemMenuComponent extends ContextMenuEntryComponent implement
 
   ngOnInit() {
     if (this.contextMenuObject) {
-      this.configuration =  this.itemExportService.initialItemExportFormConfiguration(this.contextMenuObject as Item).pipe(take(1));
+      this.itemExportService.initialItemExportFormConfiguration(this.contextMenuObject as Item).pipe(take(1))
+        .subscribe((config: ItemExportFormConfiguration) => this.configuration$.next(config));
     }
   }
 

src/app/shared/context-menu/request-correction/request-correction-menu.component.ts

@@ -41,6 +41,7 @@ import {
 import { NotificationsService } from '../../notifications/notifications.service';
 import { ContextMenuEntryComponent } from '../context-menu-entry.component';
 import { ContextMenuEntryType } from '../context-menu-entry-type';
+import { switchMap } from 'rxjs/internal/operators/switchMap';
 
 /**
  * This component renders a context menu option that provides the request a correction functionality.
@@ -134,7 +135,9 @@ export class RequestCorrectionMenuComponent extends ContextMenuEntryComponent im
       }
     });
 
-    this.canCreateCorrection$ = this.canCreateCorrection(false);
+    this.canCreateCorrection$ = this.notificationService.claimedProfile.pipe(
+      switchMap(() => this.canCreateCorrection(false))
+    );
   }
 
   /**