foundation: code cleanup

Author: msaarna

7800bas.c

@@ -288,6 +288,8 @@ int main (int argc, char *argv[])
 		}
 	    }
 	    c = fgets (code, 500, preprocessedfd);	// get next line from input
+	    if (!c)
+		break;		//end of file
 	    incline ();
 	    strcpy (displaycode, code);
 
@@ -374,8 +376,6 @@ int main (int argc, char *argv[])
 	    }
 	    if (strcmp (mycode, code))
 		strcpy (code, mycode);
-	    if (!c)
-		break;		//end of file
 
 	    // preprocessing removed in favor of a simplistic lex-based preprocessor
 
@@ -462,6 +462,7 @@ int main (int argc, char *argv[])
     if (preprocessedfd != NULL && preprocessedfd != stdin) {
         fclose(preprocessedfd);
     }
+
     if (preproc_buffer != NULL) {
         free(preproc_buffer);
         preproc_buffer = NULL;

keywords.c

@@ -561,11 +561,24 @@ void keywords (char **cstatement)
 		 && (statement[0][lastc - 3] == 't')
 		 && (statement[0][lastc - 2] == 'h')
 		 && (statement[0][lastc - 1] == 'e') && (statement[0][lastc - 0] == 'n')))
-		return;
+	    {
+                free (deallocstatement);
+                freemem (deallocorstatement);
+                freemem (deallocelstatement);
+                return;
+            }
+
 
 	    removeCR (statement[1]);
-            if (statement[1][0]==0)
-		return;
+
+	    if (statement[1][0]==0) 
+	    {
+                free (deallocstatement);
+                freemem (deallocorstatement);
+                freemem (deallocelstatement);
+                return;
+	    }
+
 	    sprintf (errorcode, "unknown keyword '%s'.", statement[1]);
 	    prerror (&errorcode[0]);
 	    exit (1);

statements.c

@@ -2207,6 +2207,9 @@ void plotmapfile (char **statement)
     int palettevalues[2048];
     int graphicmodes[2048];
 
+    memset(palettevalues, 0, sizeof(palettevalues));
+    memset(graphicmodes, 0, sizeof(graphicmodes));
+
     assertminimumargs (statement, "plotmapfile", 6);
 
     x = strictatoi (statement[4]);
@@ -5146,6 +5149,7 @@ void barf_graphic_file (void)
 	int graphics_addr[256];
 	int graphics_addr_absolute[256];
 	int tightpacked[256];
+	memset(tightpacked, 0, sizeof(tightpacked));
 	int dmaholeindex = 0;
 
 	// In 7800basic, the graphics blocks are used up from back to front of the rom/bank.