Would it be possible to have more consistency (or less duplication) between amrex/Tests and amrex-tutorials/ExampleCodes? This might help reduce some confusion.
For example, amrex/Tests/EB_CNS does not have an equivalent in amrex-tutorials/ExampleCodes
In particular, amrex/Tests/EB_CNS can be compiled in 2D; the amrex-tutorials/ExampleCodes/EB/CNS code cannot.
For context: I asked a student to work on a 2D EB-CNS test-case, and mistakenly pointed them towards the amrex-tutorials/ExampleCodes/EB/CNS one which gave them compilation errors for 2D. I should of course have pointed them to amrex/Tests/EB_CNS instead. More consistency would have reduced the chance of me making the mistake in the first place.
There are also (very minor) differences between, for example:
amrex-tutorials/ExampleCodes/EB/CNS and amrex/Tests/EB/CNSamrex-tutorials/ExampleCodes/LinearSolvers/ABecLaplacian_C and amrex/Tests/LinearSolvers/ABecLaplacian_C/
(and possibly others as well).
In most cases, I'm not sure whether amrex/Tests or amrex-tutorials/ExampleCodes should take priority, otherwise I would start putting together a PR myself to work towards this.
Would it be possible to have more consistency (or less duplication) between
amrex/Testsandamrex-tutorials/ExampleCodes? This might help reduce some confusion.For example,
amrex/Tests/EB_CNSdoes not have an equivalent inamrex-tutorials/ExampleCodesIn particular,
amrex/Tests/EB_CNScan be compiled in 2D; theamrex-tutorials/ExampleCodes/EB/CNScode cannot.For context: I asked a student to work on a 2D EB-CNS test-case, and mistakenly pointed them towards the
amrex-tutorials/ExampleCodes/EB/CNSone which gave them compilation errors for 2D. I should of course have pointed them toamrex/Tests/EB_CNSinstead. More consistency would have reduced the chance of me making the mistake in the first place.There are also (very minor) differences between, for example:
amrex-tutorials/ExampleCodes/EB/CNSandamrex/Tests/EB/CNSamrex-tutorials/ExampleCodes/LinearSolvers/ABecLaplacian_Candamrex/Tests/LinearSolvers/ABecLaplacian_C/(and possibly others as well).
In most cases, I'm not sure whether
amrex/Testsoramrex-tutorials/ExampleCodesshould take priority, otherwise I would start putting together a PR myself to work towards this.