Fix display of 'Dialing (waiting...)' state.

Change-Id: I8a659823dd61d452641c4ddb0f3141304b86d613

Author: maniac103

src/com/android/incallui/CallCardFragment.java

@@ -356,7 +356,8 @@ public void setSecondaryImage(Drawable image) {
 
     @Override
     public void setCallState(int state, Call.DisconnectCause cause, boolean bluetoothOn,
-            String gatewayLabel, String gatewayNumber, boolean isHeldRemotely, int callType) {
+            String gatewayLabel, String gatewayNumber, boolean isWaitingForRemoteSide,
+            int callType) {
         String callStateLabel = null;
 
         // If this is a video call then update the state of the VideoCallPanel
@@ -369,7 +370,7 @@ public void setCallState(int state, Call.DisconnectCause cause, boolean bluetoot
         }
 
         // States other than disconnected not yet supported
-        callStateLabel = getCallStateLabelFromState(state, cause, isHeldRemotely);
+        callStateLabel = getCallStateLabelFromState(state, cause, isWaitingForRemoteSide);
 
         Log.v(this, "setCallState " + callStateLabel);
         Log.v(this, "DisconnectCause " + cause);
@@ -502,7 +503,7 @@ private void setBluetoothOn(boolean onOff) {
      * cause of disconnect
      */
     private String getCallStateLabelFromState(int state, Call.DisconnectCause cause,
-            boolean isHeldRemotely) {
+            boolean isWaitingForRemoteSide) {
         final Context context = getView().getContext();
         String callStateLabel = null;  // Label to display as part of the call banner
 
@@ -512,13 +513,13 @@ private String getCallStateLabelFromState(int state, Call.DisconnectCause cause,
         } else if (Call.State.ACTIVE == state) {
             // We normally don't show a "call state label" at all in
             // this state (but see below for some special cases).
-            if (isHeldRemotely) {
+            if (isWaitingForRemoteSide) {
                 callStateLabel = context.getString(R.string.card_title_waiting_call);
             }
         } else if (Call.State.ONHOLD == state) {
             callStateLabel = context.getString(R.string.card_title_on_hold);
         } else if (Call.State.DIALING == state) {
-            callStateLabel = context.getString(isHeldRemotely
+            callStateLabel = context.getString(isWaitingForRemoteSide
                     ? R.string.card_title_dialing_waiting : R.string.card_title_dialing);
         } else if (Call.State.REDIALING == state) {
             callStateLabel = context.getString(R.string.card_title_redialing);

src/com/android/incallui/CallCardPresenter.java

@@ -209,27 +209,13 @@ public void onStateChange(InCallState state, CallList callList) {
         }
 
         // Set the call state
-        final int callType = CallUtils.getCallType(mPrimary);
-
-        if (mPrimary != null) {
-            final boolean bluetoothOn =
-                    (AudioModeProvider.getInstance().getAudioMode() == AudioMode.BLUETOOTH);
-            ui.setCallState(mPrimary.getState(), mPrimary.getDisconnectCause(), bluetoothOn,
-                    getGatewayLabel(), getGatewayNumber(), mPrimary.isHeldRemotely(), callType);
-        } else {
-            ui.setCallState(Call.State.IDLE, Call.DisconnectCause.UNKNOWN,
-                    false, null, null, false, callType);
-        }
+        updateCallState(mPrimary, AudioModeProvider.getInstance().getAudioMode());
     }
 
     @Override
     public void onAudioMode(int mode) {
         if (mPrimary != null && getUi() != null) {
-            final boolean bluetoothOn = (AudioMode.BLUETOOTH == mode);
-
-            getUi().setCallState(mPrimary.getState(), mPrimary.getDisconnectCause(), bluetoothOn,
-                    getGatewayLabel(), getGatewayNumber(), mPrimary.isHeldRemotely(),
-                    CallUtils.getCallType(mPrimary));
+            updateCallState(mPrimary, mode);
         }
     }
 
@@ -241,6 +227,23 @@ public void onSupportedAudioMode(int mask) {
     public void onMute(boolean muted) {
     }
 
+    private void updateCallState(Call call, int audioMode) {
+        final int callType = CallUtils.getCallType(call);
+        if (call == null) {
+            getUi().setCallState(Call.State.IDLE, Call.DisconnectCause.UNKNOWN,
+                    false, null, null, false, callType);
+            return;
+        }
+
+        final boolean bluetoothOn = audioMode == AudioMode.BLUETOOTH;
+        final int state = call.getState();
+        final boolean isWaitingForRemoteSide =
+                (state == Call.State.ACTIVE && call.isHeldRemotely()) ||
+                (state == Call.State.DIALING && call.isDialingWaiting());
+        getUi().setCallState(call.getState(), call.getDisconnectCause(), bluetoothOn,
+                getGatewayLabel(), getGatewayNumber(), isWaitingForRemoteSide, callType);
+    }
+
     public void updateCallTime() {
         final CallCardUi ui = getUi();
 
@@ -520,7 +523,8 @@ void setSecondary(boolean show, String name, boolean nameIsNumber, String label,
                 Drawable photo, boolean isConference, boolean isGeneric);
         void setSecondaryImage(Drawable image);
         void setCallState(int state, Call.DisconnectCause cause, boolean bluetoothOn,
-                String gatewayLabel, String gatewayNumber, boolean isHeldRemotely, int callType);
+                String gatewayLabel, String gatewayNumber,
+                boolean isWaitingForRemoteSide, int callType);
         void setPrimaryCallElapsedTime(boolean show, String duration);
         void setPrimaryName(String name, boolean nameIsNumber);
         void setPrimaryImage(Drawable image);