Skip to content

Commit 54ed07c

Browse files
authored
Merge pull request #328 from nSircombe/feature/github/may_updates
Adds patch to build libgomp from sources
2 parents 9407c79 + faf1518 commit 54ed07c

3 files changed

Lines changed: 11 additions & 5 deletions

File tree

ML-Frameworks/pytorch-aarch64/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ where `YY` is the year, and `MM` the month of the increment.
88
## [unreleased]
99

1010
### Added
11+
- WIP patch to build a newer version of libgomp from source - https://github.com/pytorch/pytorch/pull/152361
12+
Improve scaling for >16 threads.
1113

1214
### Changed
1315
- Updates hashes for:

ML-Frameworks/pytorch-aarch64/build-wheel.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,9 @@ if ! docker container inspect $TORCH_BUILD_CONTAINER >/dev/null 2>&1 ; then
8686
docker exec -t $TORCH_BUILD_CONTAINER bash -c $PYTORCH_ROOT/.circleci/scripts/binary_populate_env.sh
8787
docker exec -t $TORCH_BUILD_CONTAINER bash -c "$PYTORCH_ROOT/.ci/aarch64_linux/aarch64_ci_setup.sh"
8888

89+
# Build a newer version of libgomp from source (see https://github.com/pytorch/pytorch/pull/152361)
90+
docker exec -t $TORCH_BUILD_CONTAINER bash -c "bash $PYTORCH_ROOT/.ci/docker/common/install_libgomp.sh"
91+
8992
# This must be in this if block because it cannot handle being called twice
9093
docker exec -t $TORCH_BUILD_CONTAINER bash -c "bash $UTILS/build_openblas.sh"
9194

ML-Frameworks/pytorch-aarch64/get-source.sh

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ source ../utils/git-utils.sh
2121

2222
set -eux -o pipefail
2323
PYTORCH_HASH=e872bf8f888bdbb27a03e03935db61babf7180b8 # 2.8.0.dev20250430 from viable/strict
24-
IDEEP_HASH=2ef932a861439e4cc9bb8baee8424b57573de023 # From ideep_pytorch
24+
IDEEP_HASH=2ef932a861439e4cc9bb8baee8424b57573de023 # From ideep_pytorch
2525
ONEDNN_HASH=69150ce5fe1f453af9125ca42a921e017092ccf7 # From main
2626
ACL_HASH=334108c0efc512efdc9576ba957dbcf5b7ee168a # rc_25_04_29_0
2727
TORCH_AO_HASH=e1cb44ab84eee0a3573bb161d65c18661dc4a307 # From main
@@ -30,10 +30,11 @@ git-shallow-clone https://github.com/pytorch/pytorch.git $PYTORCH_HASH
3030
(
3131
cd pytorch
3232

33-
apply-github-patch pytorch/pytorch 143190 6e5628b1f648d862e8fdd150ad277120b236ed15 # Enable AArch64 CI scripts to be used for local dev
34-
apply-github-patch pytorch/pytorch 140159 ca4a718be80eb88ca6804b91201e4f98a3e236c8 # cpu: enable gemm-bf16f32 for SDPA BF16
33+
apply-github-patch pytorch/pytorch 143190 6e5628b1f648d862e8fdd150ad277120b236ed15 # Enable AArch64 CI scripts to be used for local dev
34+
apply-github-patch pytorch/pytorch 140159 ca4a718be80eb88ca6804b91201e4f98a3e236c8 # cpu: enable gemm-bf16f32 for SDPA BF16
3535
apply-github-patch pytorch/pytorch 140159 406fe1fbd066401774c104d125a7ac0b3d6eb52b
36-
apply-github-patch pytorch/pytorch 150833 02987a7c2e9b249a669723224c8d3cd80c6cb64e # Pin all root requirements to major versions
36+
apply-github-patch pytorch/pytorch 152361 7c54b6b07558c330ee2f95b4793edb3bfbb814c9 # Build libgomp (gcc-11) from source
37+
apply-github-patch pytorch/pytorch 150833 02987a7c2e9b249a669723224c8d3cd80c6cb64e # Pin all root requirements to major versions
3738

3839
git submodule sync
3940
git submodule update --init --checkout --force --recursive --jobs=$(nproc)
@@ -44,7 +45,7 @@ git-shallow-clone https://github.com/pytorch/pytorch.git $PYTORCH_HASH
4445
(
4546
cd mkl-dnn
4647
git fetch origin $ONEDNN_HASH && git clean -f && git checkout -f FETCH_HEAD
47-
apply-github-patch uxlfoundation/oneDNN 3022 4a00e92b995388192e666ee332554e4ef65b484a # cpu: aarch64: enable jit conv for 128
48+
apply-github-patch uxlfoundation/oneDNN 3022 4a00e92b995388192e666ee332554e4ef65b484a # cpu: aarch64: enable jit conv for 128
4849
)
4950
)
5051
)

0 commit comments

Comments
 (0)