Skip to content
This repository was archived by the owner on Jul 7, 2025. It is now read-only.

Commit 3c84793

Browse files
committed
사용자 관리 포트 제거 및 발신자 이름 로직 최적화
- `LetterQueryService`와 `LetterCommandService`에서 `UserManagementPort` 삭제. - `senderName` 기본값 처리 로직 단순화 (`ANONYMOUS_SENDER_NAME` 사용). - 엔터티(`ReceiveLetterEntity`, `SendLetterEntity`)에서 `senderName`을 `sender?.username` 기반으로 계산하도록 수정. - 불필요한 변수와 로직 제거로 코드 최적화.
1 parent 34cdd81 commit 3c84793

4 files changed

Lines changed: 7 additions & 10 deletions

File tree

Application-Module/src/main/kotlin/com/asap/application/letter/service/LetterCommandService.kt

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -106,16 +106,13 @@ class LetterCommandService(
106106
receiverId = DomainId(command.userId),
107107
letterId = DomainId(command.letterId),
108108
)
109+
109110
val independentLetter =
110111
IndependentLetter.create(
111112
sender =
112113
SenderInfo(
113114
senderId = sendLetter.senderId,
114-
senderName =
115-
sendLetter.senderName
116-
?: sendLetter.senderId
117-
?.let { userManagementPort.getUserNotNull(it).username }
118-
.orEmpty(),
115+
senderName = sendLetter.senderName ?: ANONYMOUS_SENDER_NAME,
119116
),
120117
receiver =
121118
ReceiverInfo(

Application-Module/src/main/kotlin/com/asap/application/letter/service/LetterQueryService.kt

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import com.asap.application.letter.port.out.IndependentLetterManagementPort
55
import com.asap.application.letter.port.out.SendLetterManagementPort
66
import com.asap.application.letter.port.out.SpaceLetterManagementPort
77
import com.asap.application.space.port.out.SpaceManagementPort
8-
import com.asap.application.user.port.out.UserManagementPort
98
import com.asap.common.page.PageRequest
109
import com.asap.common.page.Sort
1110
import com.asap.domain.common.DomainId
@@ -16,7 +15,6 @@ import org.springframework.transaction.annotation.Transactional
1615
@Transactional(readOnly = true)
1716
class LetterQueryService(
1817
private val sendLetterManagementPort: SendLetterManagementPort,
19-
private val userManagementPort: UserManagementPort,
2018
private val independentLetterManagementPort: IndependentLetterManagementPort,
2119
private val spaceLetterManagementPort: SpaceLetterManagementPort,
2220
private val spaceManagementPort: SpaceManagementPort,
@@ -32,9 +30,8 @@ class LetterQueryService(
3230
receiverId = DomainId(query.userId),
3331
letterId = DomainId(query.letterId),
3432
).also {
35-
val sender = it.senderId?.let { userManagementPort.getUserNotNull(it) }
3633
return GetVerifiedLetterUsecase.Response(
37-
senderName = sender?.username,
34+
senderName = it.senderName,
3835
content = it.content.content,
3936
sendDate = it.createdDate,
4037
templateType = it.content.templateType,
@@ -76,7 +73,7 @@ class LetterQueryService(
7673
independentLetterManagementPort.getNearbyLetter(DomainId(query.userId), DomainId(query.letterId))
7774
return GetIndependentLettersUsecase.Response.One(
7875
senderName = letter.sender.senderName,
79-
letterCount = letterCount.toLong(),
76+
letterCount = letterCount,
8077
content = letter.content.content,
8178
sendDate = letter.receiveDate,
8279
images = letter.content.images,

Infrastructure-Module/Persistence/src/main/kotlin/com/asap/persistence/jpa/letter/entity/ReceiveLetterEntity.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,9 @@ class ReceiveLetterEntity(
5353
@ManyToOne(fetch = FetchType.LAZY)
5454
@JoinColumn(name = "sender_id", insertable = false, updatable = false)
5555
var sender: UserEntity? = null
56+
5657
var senderName: String = senderName
58+
get() = sender?.username ?: field
5759

5860
@Column(
5961
name = "receiver_id",

Infrastructure-Module/Persistence/src/main/kotlin/com/asap/persistence/jpa/letter/entity/SendLetterEntity.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ class SendLetterEntity(
5555

5656
@Column(name = "sender_name")
5757
var senderName: String? = senderName
58+
get() = sender?.username ?: field
5859

5960
@ManyToOne(fetch = FetchType.LAZY)
6061
@JoinColumn(

0 commit comments

Comments
 (0)