ASAP-456 비회원 이미지 업로드 로직 리팩토링 및 테스트 개선

- `ImageMetadata.owner`를 nullable로 변경하여 비회원 지원.
- 비회원 이미지 업로드 시 기본 ID("anonymous") 설정 로직을 `S3ImageManagementAdapter`로 이동.
- `upload` 메서드의 비회원 처리 로직 단순화.
- `ImageCommandServiceTest` 테스트 구조 개선: 시나리오 분리 및 검증 추가.
- `ImageMetadata` 데이터 클래스 구조 수정.

Author: tlarbals824

Application-Module/src/main/kotlin/com/asap/application/image/service/ImageCommandService.kt

@@ -12,25 +12,13 @@ class ImageCommandService(
     private val imageManagementPort: ImageManagementPort,
     private val userManagementPort: UserManagementPort,
 ) : UploadImageUsecase {
-    companion object {
-        private const val ANONYMOUS_OWNER_ID = "anonymous"
-    }
-
     override fun upload(command: UploadImageUsecase.Command): UploadImageUsecase.Response {
-        val owner =
-            when {
-                command.userId != null -> {
-                    val user = userManagementPort.getUserNotNull(DomainId(command.userId))
-                    user.id.value
-                }
-
-                else -> ANONYMOUS_OWNER_ID
-            }
+        val user = command.userId?.let { userManagementPort.getUserNotNull(DomainId(it)) }
 
         val uploadedImage =
             imageManagementPort.save(
                 ImageMetadata(
-                    owner = owner,
+                    owner = user?.id?.value,
                     fileMetaData = command.image,
                 ),
             )

Application-Module/src/main/kotlin/com/asap/application/image/vo/ImageMetadata.kt

@@ -3,7 +3,6 @@ package com.asap.application.image.vo
 import com.asap.common.file.FileMetaData
 
 data class ImageMetadata(
-    val owner: String,
-    val fileMetaData: FileMetaData
-) {
-}
+    val owner: String?,
+    val fileMetaData: FileMetaData,
+)

Application-Module/src/test/kotlin/com/asap/application/image/service/ImageCommandServiceTest.kt

@@ -2,22 +2,21 @@ package com.asap.application.image.service
 
 import com.asap.application.image.port.`in`.UploadImageUsecase
 import com.asap.application.image.port.out.ImageManagementPort
-import com.asap.application.image.vo.ImageMetadata
 import com.asap.application.image.vo.UploadedImage
 import com.asap.application.user.port.out.UserManagementPort
 import com.asap.common.file.FileMetaData
 import com.asap.domain.UserFixture
+import io.kotest.core.spec.IsolationMode
 import io.kotest.core.spec.style.BehaviorSpec
 import io.kotest.matchers.nulls.shouldNotBeNull
-import io.kotest.matchers.shouldBe
 import io.mockk.every
 import io.mockk.mockk
-import io.mockk.slot
 import io.mockk.verify
 import java.io.InputStream
 
 class ImageCommandServiceTest :
     BehaviorSpec({
+        isolationMode = IsolationMode.InstancePerLeaf
 
         val mockImageManagementPort = mockk<ImageManagementPort>(relaxed = true)
         val mockUserManagementPort = mockk<UserManagementPort>(relaxed = true)
@@ -28,10 +27,11 @@ class ImageCommandServiceTest :
                 mockUserManagementPort,
             )
 
-        given("익명 사용자의 이미지 업로드 요청이 들어올 때") {
+        given("이미지 업로드 요청이 들어올 때") {
+            val mockUser = UserFixture.createUser()
             val command =
                 UploadImageUsecase.Command(
-                    userId = null,
+                    userId = mockUser.id.value,
                     image =
                         FileMetaData(
                             name = "name",
@@ -40,12 +40,14 @@ class ImageCommandServiceTest :
                             inputStream = InputStream.nullInputStream(),
                         ),
                 )
-            val imageMetadataSlot = slot<ImageMetadata>()
             every {
-                mockImageManagementPort.save(capture(imageMetadataSlot))
+                mockUserManagementPort.getUserNotNull(any())
+            } returns mockUser
+            every {
+                mockImageManagementPort.save(any())
             } returns
                 UploadedImage(
-                    imageUrl = "anonymousImageUrl",
+                    imageUrl = "imageUrl",
                 )
             `when`("이미지 업로드 요청을 처리하면") {
                 val response = imageCommandService.upload(command)
@@ -54,17 +56,14 @@ class ImageCommandServiceTest :
                         this.isNotBlank()
                         this.isNotEmpty()
                     }
-                    verify { mockImageManagementPort.save(any()) }
-                    imageMetadataSlot.captured.owner shouldBe "anonymous"
                 }
             }
         }
 
-        given("이미지 업로드 요청이 들어올 때") {
-            val mockUser = UserFixture.createUser()
+        given("userId가 null인 이미지 업로드 요청이 들어올 때") {
             val command =
                 UploadImageUsecase.Command(
-                    userId = mockUser.id.value,
+                    userId = null,
                     image =
                         FileMetaData(
                             name = "name",
@@ -73,9 +72,6 @@ class ImageCommandServiceTest :
                             inputStream = InputStream.nullInputStream(),
                         ),
                 )
-            every {
-                mockUserManagementPort.getUserNotNull(any())
-            } returns mockUser
             every {
                 mockImageManagementPort.save(any())
             } returns
@@ -84,6 +80,9 @@ class ImageCommandServiceTest :
                 )
             `when`("이미지 업로드 요청을 처리하면") {
                 val response = imageCommandService.upload(command)
+                then("getUserNotNull 메서드가 호출되지 않아야 한다") {
+                    verify(exactly = 0) { mockUserManagementPort.getUserNotNull(any()) }
+                }
                 then("이미지가 저장되어야 한다") {
                     response.imageUrl shouldNotBeNull {
                         this.isNotBlank()

Infrastructure-Module/AWS/src/main/kotlin/com/asap/aws/s3/S3ImageManagementAdapter.kt

@@ -13,7 +13,9 @@ class S3ImageManagementAdapter(
     private val s3Template: S3Template,
 ) : ImageManagementPort {
     override fun save(image: ImageMetadata): UploadedImage {
-        val key = "${image.owner}/${UUID.randomUUID()}"
+        val owner = image.owner ?: ANONYMOUS_OWNER_ID
+
+        val key = "$owner/${UUID.randomUUID()}"
 
         val resource =
             s3Template.upload(
@@ -33,5 +35,6 @@ class S3ImageManagementAdapter(
 
     companion object {
         private const val BUCKET_NAME = "lettering-images"
+        private const val ANONYMOUS_OWNER_ID = "anonymous"
     }
 }