Add ROMM->CIE-XYZ builtin and update tests

Register ROMM_to_CIE-XYZ-D65_BFD and LINEAR-RIMM_to_ACES2065-1_BFD in Config version checks, correct ProPhotoRGB builtin to target CIE XYZ D65 (update comments/registration string), and adjust unit test expected values for ROMM_to_CIE-XYZ-D65_BFD to match the corrected conversion.

Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>

Author: ssh4net

src/OpenColorIO/Config.cpp

@@ -5647,6 +5647,8 @@ void Config::Impl::checkVersionConsistency(ConstTransformRcPtr & transform) cons
                         || 0 == Platform::Strcasecmp(blt->getStyle(), "ACES-OUTPUT - ACES2065-1_to_CIE-XYZ-D65 - HDR-1000nit-REC2020-D60-in-REC2020-D65_2.0")
                         || 0 == Platform::Strcasecmp(blt->getStyle(), "ACES-OUTPUT - ACES2065-1_to_CIE-XYZ-D65 - HDR-2000nit-REC2020-D60-in-REC2020-D65_2.0")
                         || 0 == Platform::Strcasecmp(blt->getStyle(), "ACES-OUTPUT - ACES2065-1_to_CIE-XYZ-D65 - HDR-4000nit-REC2020-D60-in-REC2020-D65_2.0")
+                        || 0 == Platform::Strcasecmp(blt->getStyle(), "ROMM_to_CIE-XYZ-D65_BFD")
+                        || 0 == Platform::Strcasecmp(blt->getStyle(), "LINEAR-RIMM_to_ACES2065-1_BFD")
                         // NB: This one was added in OCIO 2.4.1.
                         || 0 == Platform::Strcasecmp(blt->getStyle(), "DISPLAY - CIE-XYZ-D65_to_DisplayP3-HDR") )
                 )

src/OpenColorIO/transforms/builtins/ProPhotoRGB.cpp

@@ -106,22 +106,22 @@ namespace OCIO_NAMESPACE
 					LINEAR_RIMM_to_ACES2065_1_BFD_Functor);
 			}
 
-			// Encoded ProPhoto RGB (gamma 1.8) to ACES2065-1.
+			// Encoded ProPhoto RGB (gamma 1.8) to CIE XYZ D65.
 			{
 				auto ROMM_to_CIE_XYZ_D65_BFD_Functor = [](OpRcPtrVec& ops)
 					{
 						// 1. Decode gamma 1.8 to linear.
 						ROMM_RGB_GAMMA_18::GenerateEncodedToLinearOps(ops);
 
-						// 2. Convert color space from ROMM RGB (D50) to ACES AP0 (D60).
+						// 2. Convert color space from ROMM RGB (D50) to CIE XYZ D65.
 						MatrixOpData::MatrixArrayPtr matrix
 							= build_conversion_matrix_to_XYZ_D65(ROMM_RGB::primaries,
 								ADAPTATION_BRADFORD);
 						CreateMatrixOp(ops, matrix, TRANSFORM_DIR_FORWARD);
 					};
 
 				registry.addBuiltin("ROMM_to_CIE-XYZ-D65_BFD",
-					"Convert ProPhoto RGB (gamma 1.8 encoded) to ACES2065-1",
+					"Convert ProPhoto RGB (gamma 1.8 encoded) to CIE XYZ D65",
 					ROMM_to_CIE_XYZ_D65_BFD_Functor);
 			}
 

tests/cpu/transforms/BuiltinTransform_tests.cpp

@@ -723,8 +723,8 @@ AllValues UnitTestValues
         { 0.5649694f,      0.4038837f,      0.3751478f,      -0.505630434f, 0.738133013f, 0.251128823f } } },
     { "ROMM_to_CIE-XYZ-D65_BFD",
         { 1.0e-6f,
-        { 0.5f,           0.4f,           0.3f,      0.248054f,   0.216383f,   0.124372f },
-        { 0.03f,          0.02f,          0.01f,     0.00160897f, 0.00140735f, 0.000677473f } } },
+        { 0.5f,            0.4f,            0.3f,            0.03f,           0.02f,           0.01f},
+        { 0.248033493677f, 0.216374642372f, 0.124341066020f, 0.001608840857f, 0.001407296790f, 0.000677302006f} } },
     { "LINEAR-RIMM_to_ACES2065-1_BFD",
         { 1.0e-6f,
         {0.5f,           0.4f,           0.3f},      {0.47351069f, 0.39131449f, 0.29965645f} } }