Remove ProPhoto sRGB-gamma variant and tests

Remove the ROMM_RGB_SRGB_GAMMA implementation and its registration for the PROPHOTO builtins. Deleted the sRGB-style GammaOpData helper functions and the PROPHOTO-RGB-SRGB-GAMMA_to_ACES2065-1 registry entry from src/OpenColorIO/transforms/builtins/ProPhotoRGB.cpp. Also remove the leftover commented test reference from tests/cpu/transforms/builtins/BuiltinTransformRegistry_tests.cpp. This cleans up an obsolete ProPhoto (sRGB-gamma) variant and its test artifact.

Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>

Author: ssh4net

src/OpenColorIO/transforms/builtins/ProPhotoRGB.cpp

@@ -82,36 +82,6 @@ namespace OCIO_NAMESPACE
 	} // namespace ROMM_RGB_GAMMA_18
 
 
-	// ProPhoto RGB with sRGB gamma curve.
-	// This is a common variant used by Adobe and other applications.
-	// Uses the sRGB transfer function (gamma 2.4, offset 0.055) instead of
-	// the standard ROMM RGB gamma 1.8 curve.
-	namespace ROMM_RGB_SRGB_GAMMA
-	{
-
-		void GenerateLinearToEncodedOps(OpRcPtrVec& ops)
-		{
-			// sRGB gamma encoding: gamma=2.4, offset=0.055
-			// This uses the MONCURVE model which is efficient for sRGB-style curves.
-			const GammaOpData::Params rgbParams = { 2.4, 0.055 };
-			const GammaOpData::Params alphaParams = { 1.0, 0.0 };
-			auto gammaData = std::make_shared<GammaOpData>(GammaOpData::MONCURVE_FWD,
-				rgbParams, rgbParams, rgbParams, alphaParams);
-			CreateGammaOp(ops, gammaData, TRANSFORM_DIR_FORWARD);
-		}
-
-		void GenerateEncodedToLinearOps(OpRcPtrVec& ops)
-		{
-			// sRGB gamma decoding: gamma=2.4, offset=0.055
-			const GammaOpData::Params rgbParams = { 2.4, 0.055 };
-			const GammaOpData::Params alphaParams = { 1.0, 0.0 };
-			auto gammaData = std::make_shared<GammaOpData>(GammaOpData::MONCURVE_REV,
-				rgbParams, rgbParams, rgbParams, alphaParams);
-			CreateGammaOp(ops, gammaData, TRANSFORM_DIR_FORWARD);
-		}
-
-	} // namespace ROMM_RGB_SRGB_GAMMA
-
 
 	namespace PROPHOTO
 	{
@@ -155,26 +125,6 @@ namespace OCIO_NAMESPACE
 					ROMM_to_CIE_XYZ_D65_BFD_Functor);
 			}
 
-			// ProPhoto RGB with sRGB gamma to ACES2065-1.
-			{
-				auto ROMM_RGB_SRGB_to_ACES2065_1_Functor = [](OpRcPtrVec& ops)
-					{
-						// 1. Decode sRGB gamma to linear.
-						ROMM_RGB_SRGB_GAMMA::GenerateEncodedToLinearOps(ops);
-
-						// 2. Convert color space from ROMM RGB (D50) to ACES AP0 (D60).
-						MatrixOpData::MatrixArrayPtr matrix
-							= build_conversion_matrix(ROMM_RGB::primaries,
-								ACES_AP0::primaries,
-								ADAPTATION_BRADFORD);
-						CreateMatrixOp(ops, matrix, TRANSFORM_DIR_FORWARD);
-					};
-
-				registry.addBuiltin("PROPHOTO-RGB-SRGB-GAMMA_to_ACES2065-1",
-					"Convert ProPhoto RGB (sRGB gamma encoded) to ACES2065-1",
-					ROMM_RGB_SRGB_to_ACES2065_1_Functor);
-			}
-
 		}
 
 	} // namespace PROPHOTO

tests/cpu/transforms/builtins/BuiltinTransformRegistry_tests.cpp

@@ -407,5 +407,4 @@ OCIO_ADD_TEST(Builtins, version_2_3_validation)
     // ProPhotoRGB / ROMM RGB builtin transforms.
     TestStyle("ROMM_to_CIE-XYZ-D65_BFD");
     TestStyle("LINEAR-RIMM_to_ACES2065-1_BFD");
-    //TestStyle("PROPHOTO-RGB-SRGB-GAMMA_to_ACES2065-1");
 }