Fix the cleanup discovered from a crash on Windows. Thanks @cedrik

dpmacri · dpmacri · commit eaf79fa3245a · 2026-04-17T09:04:59.000-07:00
Fuoco!

Signed-off-by: Dean P. Macri &lt;dean.p.macri@gmail.com&gt;
diff --git a/src/lib/image/MovieFFMpeg/AppleProRes.h b/src/lib/image/MovieFFMpeg/AppleProRes.h
@@ -28,7 +28,7 @@ struct AppleProResContext
     {
         if (prpixbuf.baseAddr)
         {
-            av_freep(prpixbuf.baseAddr);
+            av_free(prpixbuf.baseAddr);
         }
         if (prdecoder)
         {
@@ -44,6 +44,14 @@ struct AppleProResContext
         {
             return *this;
         }
+        if (prpixbuf.baseAddr)
+        {
+            av_free(prpixbuf.baseAddr);
+        }
+        if (prdecoder)
+        {
+            PRCloseDecoder(prdecoder);
+        }
         pixfmt = other.pixfmt;
         avPixelFormat = other.avPixelFormat;
         clearPRPixBuf();

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ struct AppleProResContext`
`28`	`28`	`{`
`29`	`29`	`if (prpixbuf.baseAddr)`
`30`	`30`	`{`
`31`		`- av_freep(prpixbuf.baseAddr);`
	`31`	`+ av_free(prpixbuf.baseAddr);`
`32`	`32`	`}`
`33`	`33`	`if (prdecoder)`
`34`	`34`	`{`
`@@ -44,6 +44,14 @@ struct AppleProResContext`
`44`	`44`	`{`
`45`	`45`	`return *this;`
`46`	`46`	`}`
	`47`	`+ if (prpixbuf.baseAddr)`
	`48`	`+ {`
	`49`	`+ av_free(prpixbuf.baseAddr);`
	`50`	`+ }`
	`51`	`+ if (prdecoder)`
	`52`	`+ {`
	`53`	`+ PRCloseDecoder(prdecoder);`
	`54`	`+ }`
`47`	`55`	`pixfmt = other.pixfmt;`
`48`	`56`	`avPixelFormat = other.avPixelFormat;`
`49`	`57`	`clearPRPixBuf();`