fix: tighten TestNoMagicValues, migrate 7 numeric constants to config

Remove blanket isConstDef/isVarDef exemption from TestNoMagicValues
— numeric const definitions outside config/ are now caught. All 7
violations resolved:

- JSON-RPC error codes (ErrCodeParse, ErrCodeNotFound,
  ErrCodeInvalidArg, ErrCodeInternal) moved from mcp/proto/schema.go
  to config/mcp/schema/. Updated 14 consumer sites + 1 test file.
- DefaultPriority (50) moved to config/steering/. Updated
  steering/frontmatter.go and cli/steering/cmd/add/cmd.go.
- PollIntervalSec (5) moved to config/mcp/server/.
- Removed dead isVarDef helper from magic_values_test.go.

Spec: specs/ast-audit-contributor-guide.md
Signed-off-by: Jose Alekhinne <jose@ctx.ist>

Author: josealekhine

internal/audit/magic_values_test.go

@@ -99,12 +99,14 @@ func TestNoMagicValues(t *testing.T) {
 					return true
 				}
 
-				// Skip file-level const/var definition sites only.
-				// Local consts inside function bodies are NOT exempt —
-				// they are just renamed magic numbers.
-				if isConstDef(file, lit) || isVarDef(file, lit) {
-					return true
-				}
+				// Const/var definitions in exempt packages
+				// are already skipped (line 86). Outside
+				// those packages, numeric constants are
+				// magic values that belong in config/.
+				//
+				// DO NOT re-add a blanket isConstDef
+				// exemption. It masks constants defined
+				// in the wrong package.
 
 				if exemptIntLiterals[lit.Value] {
 					return true
@@ -157,28 +159,6 @@ func isExemptPackage(pkgPath string) bool {
 	return false
 }
 
-// isVarDef reports whether lit appears inside a var declaration.
-func isVarDef(file *ast.File, lit *ast.BasicLit) bool {
-	for _, decl := range file.Decls {
-		gd, ok := decl.(*ast.GenDecl)
-		if !ok || gd.Tok != token.VAR {
-			continue
-		}
-		for _, spec := range gd.Specs {
-			vs, ok := spec.(*ast.ValueSpec)
-			if !ok {
-				continue
-			}
-			for _, val := range vs.Values {
-				if containsNode(val, lit) {
-					return true
-				}
-			}
-		}
-	}
-	return false
-}
-
 // isStrconvArg reports whether lit is an argument to a strconv
 // function (radix or bitsize parameter).
 func isStrconvArg(file *ast.File, lit *ast.BasicLit) bool {

internal/cli/steering/cmd/add/cmd.go

@@ -24,9 +24,6 @@ import (
 	writeSteering "github.com/ActiveMemory/ctx/internal/write/steering"
 )
 
-// defaultPriority is the default priority for new steering files.
-const defaultPriority = 50
-
 // Cmd returns the "ctx steering add" subcommand.
 //
 // Returns:
@@ -79,7 +76,7 @@ func Run(c *cobra.Command, name string) error {
 	sf := &steering.SteeringFile{
 		Name:      name,
 		Inclusion: cfgSteering.InclusionManual,
-		Priority:  defaultPriority,
+		Priority:  cfgSteering.DefaultPriority,
 	}
 
 	data := steering.Print(sf)

internal/config/README.md

@@ -4,14 +4,14 @@
 
 This directory contains ~60 sub-packages, each holding constants,
 compiled regexes, type definitions, or text keys for a single
-domain. This looks unusual. It's intentional.
+domain. This looks unusual. **It's intentional**.
 
 ### The problem it solves
 
 A monolithic `config` package creates a false dependency: importing
 `config` to use `config.TokenBudget` also imports every regex
 pattern, every MCP constant, every entry type, and every CLI flag
-name. In Go, the package is the dependency unit — importing one
+name. In Go, the package is the dependency unit: importing one
 symbol imports the whole package. A change to any constant in the
 package marks every consumer as stale for recompilation and makes
 the blast radius of any change the entire codebase.
@@ -44,7 +44,7 @@ import "github.com/ActiveMemory/ctx/internal/config"  // everything
 
 - Surgical dependency tracking (change `config/mcp/tool` and only
   MCP packages recompile)
-- Zero import cycles (all sub-packages are leaves — zero internal
+- Zero import cycles (all sub-packages are leaves: zero internal
   dependencies)
 - Clear ownership (each file belongs to one domain)
 - Safe to modify (changing a constant in `config/agent` cannot
@@ -138,12 +138,12 @@ method receivers, interface participation, or business logic. A
 type with `func (t IssueType) Severity() int` has outgrown
 `config/` and belongs in `entity/`.
 
-| Stage | Home | Example |
-|-------|------|---------|
-| Pure value enum | `config/<domain>/` | `type IssueType string` with const values |
-| Cross-package value enum | `config/<domain>/` | Same — `config/` is already importable everywhere |
-| Type with methods | `entity/` | `func (t IssueType) Severity() int` |
-| Type implementing interfaces | `entity/` | `var _ fmt.Stringer = IssueType("")` |
+| Stage                        | Home               | Example                                           |
+|------------------------------|--------------------|---------------------------------------------------|
+| Pure value enum              | `config/<domain>/` | `type IssueType string` with const values         |
+| Cross-package value enum     | `config/<domain>/` | Same — `config/` is already importable everywhere |
+| Type with methods            | `entity/`          | `func (t IssueType) Severity() int`               |
+| Type implementing interfaces | `entity/`          | `var _ fmt.Stringer = IssueType("")`              |
 
 The migration path is natural: start in `config/`, promote to
 `entity/` when behavior appears. `TestCrossPackageTypes` catches

internal/config/mcp/schema/schema.go

@@ -9,6 +9,18 @@ package schema
 // ProtocolVersion is the MCP protocol version string.
 const ProtocolVersion = "2024-11-05"
 
+// Standard JSON-RPC error codes.
+const (
+	// ErrCodeParse indicates malformed JSON.
+	ErrCodeParse = -32700
+	// ErrCodeNotFound indicates method not found.
+	ErrCodeNotFound = -32601
+	// ErrCodeInvalidArg indicates invalid parameters.
+	ErrCodeInvalidArg = -32602
+	// ErrCodeInternal indicates an internal error.
+	ErrCodeInternal = -32603
+)
+
 // JSON Schema type constants.
 const (
 	// Object is the JSON Schema type for objects.

internal/config/mcp/server/server.go

@@ -20,6 +20,10 @@ const (
 	SubcommandServe = "serve"
 )
 
+// PollIntervalSec is the default interval in seconds for
+// resource change polling.
+const PollIntervalSec = 5
+
 // Args returns the CLI arguments to launch the ctx MCP server.
 func Args() []string {
 	return []string{"mcp", SubcommandServe}

internal/config/steering/steering.go

@@ -26,3 +26,7 @@ const (
 // LabelAllTools is the display label when a steering
 // or trigger item applies to all tools.
 const LabelAllTools = "all"
+
+// DefaultPriority is the default injection priority for
+// steering files when omitted from frontmatter.
+const DefaultPriority = 50

internal/mcp/proto/schema.go

@@ -64,18 +64,6 @@ type RPCError struct {
 	Data    interface{} `json:"data,omitempty"`
 }
 
-// Standard JSON-RPC error codes.
-const (
-	// ErrCodeParse indicates malformed JSON was received.
-	ErrCodeParse = -32700
-	// ErrCodeNotFound indicates the method was not found.
-	ErrCodeNotFound = -32601
-	// ErrCodeInvalidArg indicates invalid method parameters.
-	ErrCodeInvalidArg = -32602
-	// ErrCodeInternal indicates an internal JSON-RPC error.
-	ErrCodeInternal = -32603
-)
-
 // --- Initialization types ---
 
 // InitializeParams contains client information sent during initialization.

internal/mcp/server/parse/parse.go

@@ -11,6 +11,7 @@ import (
 
 	"github.com/ActiveMemory/ctx/internal/assets/read/desc"
 	"github.com/ActiveMemory/ctx/internal/config/embed/text"
+	cfgSchema "github.com/ActiveMemory/ctx/internal/config/mcp/schema"
 	"github.com/ActiveMemory/ctx/internal/config/mcp/server"
 	"github.com/ActiveMemory/ctx/internal/mcp/proto"
 )
@@ -32,7 +33,7 @@ func Request(data []byte) (*proto.Request, *proto.Response) {
 		return nil, &proto.Response{
 			JSONRPC: server.JSONRPCVersion,
 			Error: &proto.RPCError{
-				Code:    proto.ErrCodeParse,
+				Code:    cfgSchema.ErrCodeParse,
 				Message: desc.Text(text.DescKeyMCPErrParse),
 			},
 		}

internal/mcp/server/poll/poll.go

@@ -17,9 +17,11 @@ import (
 	"github.com/ActiveMemory/ctx/internal/mcp/server/catalog"
 )
 
-// defaultPollInterval is the default interval for resource change
-// polling.
-const defaultPollInterval = 5 * time.Second
+// defaultPollInterval is the default interval for
+// resource change polling.
+var defaultPollInterval = time.Duration(
+	server.PollIntervalSec,
+) * time.Second
 
 // NewPoller creates a poller for the given context directory.
 //

internal/mcp/server/resource/dispatch.go

@@ -12,6 +12,7 @@ import (
 
 	"github.com/ActiveMemory/ctx/internal/assets/read/desc"
 	"github.com/ActiveMemory/ctx/internal/config/embed/text"
+	cfgSchema "github.com/ActiveMemory/ctx/internal/config/mcp/schema"
 	"github.com/ActiveMemory/ctx/internal/context/load"
 	"github.com/ActiveMemory/ctx/internal/mcp/proto"
 	"github.com/ActiveMemory/ctx/internal/mcp/server/catalog"
@@ -50,14 +51,14 @@ func DispatchRead(
 		req.Params, &params,
 	); unmarshalErr != nil {
 		return out.ErrResponse(
-			req.ID, proto.ErrCodeInvalidArg,
+			req.ID, cfgSchema.ErrCodeInvalidArg,
 			desc.Text(text.DescKeyMCPErrInvalidParams),
 		)
 	}
 
 	ctx, loadErr := load.Do(contextDir)
 	if loadErr != nil {
-		return out.ErrResponse(req.ID, proto.ErrCodeInternal,
+		return out.ErrResponse(req.ID, cfgSchema.ErrCodeInternal,
 			fmt.Sprintf(
 				desc.Text(text.DescKeyMCPLoadContext),
 				loadErr,
@@ -74,7 +75,7 @@ func DispatchRead(
 		return readAgentPacket(req.ID, ctx, tokenBudget)
 	}
 
-	return out.ErrResponse(req.ID, proto.ErrCodeInvalidArg,
+	return out.ErrResponse(req.ID, cfgSchema.ErrCodeInvalidArg,
 		fmt.Sprintf(
 			desc.Text(text.DescKeyMCPErrUnknownResource),
 			params.URI,