Skip to content

Commit 49d4218

Browse files
josealekhinejosealekhine
committed
fix: check error return of os.Chdir in defer statements
Fixes errcheck linter warnings about unchecked error returns. Signed-off-by: Jose Alekhinne <alekhinejose@gmail.com>
1 parent cabe008 commit 49d4218

13 files changed

Lines changed: 29 additions & 29 deletions

File tree

‎internal/cli/add/add_test.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ func TestAddCommand(t *testing.T) {
2727
if err := os.Chdir(tmpDir); err != nil {
2828
t.Fatalf("failed to chdir: %v", err)
2929
}
30-
defer os.Chdir(origDir)
30+
defer func() { _ = os.Chdir(origDir) }()
3131

3232
// First init
3333
initCmd := initialize.Cmd()
@@ -67,7 +67,7 @@ func TestAddDecisionAndLearning(t *testing.T) {
6767
if err := os.Chdir(tmpDir); err != nil {
6868
t.Fatalf("failed to chdir: %v", err)
6969
}
70-
defer os.Chdir(origDir)
70+
defer func() { _ = os.Chdir(origDir) }()
7171

7272
// First init
7373
initCmd := initialize.Cmd()
@@ -140,7 +140,7 @@ func TestAddFromFile(t *testing.T) {
140140
if err := os.Chdir(tmpDir); err != nil {
141141
t.Fatalf("failed to chdir: %v", err)
142142
}
143-
defer os.Chdir(origDir)
143+
defer func() { _ = os.Chdir(origDir) }()
144144

145145
// First init
146146
initCmd := initialize.Cmd()

‎internal/cli/agent/agent_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ func TestAgentCommand(t *testing.T) {
2525
if err := os.Chdir(tmpDir); err != nil {
2626
t.Fatalf("failed to chdir: %v", err)
2727
}
28-
defer os.Chdir(origDir)
28+
defer func() { _ = os.Chdir(origDir) }()
2929

3030
// First init
3131
initCmd := initialize.Cmd()
@@ -55,7 +55,7 @@ func TestAgentJSONOutput(t *testing.T) {
5555
if err := os.Chdir(tmpDir); err != nil {
5656
t.Fatalf("failed to chdir: %v", err)
5757
}
58-
defer os.Chdir(origDir)
58+
defer func() { _ = os.Chdir(origDir) }()
5959

6060
// First init
6161
initCmd := initialize.Cmd()

‎internal/cli/compact/compact_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ func TestCompactCommand(t *testing.T) {
9797
if err := os.Chdir(tmpDir); err != nil {
9898
t.Fatalf("failed to chdir: %v", err)
9999
}
100-
defer os.Chdir(origDir)
100+
defer func() { _ = os.Chdir(origDir) }()
101101

102102
// First init
103103
initCmd := initialize.Cmd()
@@ -126,7 +126,7 @@ func TestCompactWithTasks(t *testing.T) {
126126
if err := os.Chdir(tmpDir); err != nil {
127127
t.Fatalf("failed to chdir: %v", err)
128128
}
129-
defer os.Chdir(origDir)
129+
defer func() { _ = os.Chdir(origDir) }()
130130

131131
// First init
132132
initCmd := initialize.Cmd()

‎internal/cli/complete/complete_test.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ func TestCompleteCommand(t *testing.T) {
2828
if err := os.Chdir(tmpDir); err != nil {
2929
t.Fatalf("failed to chdir: %v", err)
3030
}
31-
defer os.Chdir(origDir)
31+
defer func() { _ = os.Chdir(origDir) }()
3232

3333
// First init
3434
initCmd := initialize.Cmd()

‎internal/cli/drift/drift_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ func TestDriftCommand(t *testing.T) {
2525
if err := os.Chdir(tmpDir); err != nil {
2626
t.Fatalf("failed to chdir: %v", err)
2727
}
28-
defer os.Chdir(origDir)
28+
defer func() { _ = os.Chdir(origDir) }()
2929

3030
// First init
3131
initCmd := initialize.Cmd()
@@ -55,7 +55,7 @@ func TestDriftJSONOutput(t *testing.T) {
5555
if err := os.Chdir(tmpDir); err != nil {
5656
t.Fatalf("failed to chdir: %v", err)
5757
}
58-
defer os.Chdir(origDir)
58+
defer func() { _ = os.Chdir(origDir) }()
5959

6060
// First init
6161
initCmd := initialize.Cmd()

‎internal/cli/initialize/init_test.go‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ func TestInitCommand(t *testing.T) {
2626
if err := os.Chdir(tmpDir); err != nil {
2727
t.Fatalf("failed to chdir: %v", err)
2828
}
29-
defer os.Chdir(origDir)
29+
defer func() { _ = os.Chdir(origDir) }()
3030

3131
// Run the init command
3232
cmd := Cmd()
@@ -137,7 +137,7 @@ func TestInitMergeInsertsAfterH1(t *testing.T) {
137137
if err := os.Chdir(tmpDir); err != nil {
138138
t.Fatalf("failed to chdir: %v", err)
139139
}
140-
defer os.Chdir(origDir)
140+
defer func() { _ = os.Chdir(origDir) }()
141141

142142
// Create CLAUDE.md with H1 but no ctx markers
143143
existingContent := `# My Amazing Project
@@ -202,7 +202,7 @@ func TestInitMergeInsertsAtTopWhenNoH1(t *testing.T) {
202202
if err := os.Chdir(tmpDir); err != nil {
203203
t.Fatalf("failed to chdir: %v", err)
204204
}
205-
defer os.Chdir(origDir)
205+
defer func() { _ = os.Chdir(origDir) }()
206206

207207
// Create CLAUDE.md without H1 (starts with H2)
208208
existingContent := `## Build Instructions
@@ -263,7 +263,7 @@ func TestInitWithExistingClaudeMdWithCtxMarker(t *testing.T) {
263263
if err := os.Chdir(tmpDir); err != nil {
264264
t.Fatalf("failed to chdir: %v", err)
265265
}
266-
defer os.Chdir(origDir)
266+
defer func() { _ = os.Chdir(origDir) }()
267267

268268
// Create existing CLAUDE.md with ctx marker already present
269269
existingContent := `# My Project

‎internal/cli/load/load_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ func TestLoadCommand(t *testing.T) {
2525
if err := os.Chdir(tmpDir); err != nil {
2626
t.Fatalf("failed to chdir: %v", err)
2727
}
28-
defer os.Chdir(origDir)
28+
defer func() { _ = os.Chdir(origDir) }()
2929

3030
// First init
3131
initCmd := initialize.Cmd()
@@ -55,7 +55,7 @@ func TestLoadRawOutput(t *testing.T) {
5555
if err := os.Chdir(tmpDir); err != nil {
5656
t.Fatalf("failed to chdir: %v", err)
5757
}
58-
defer os.Chdir(origDir)
58+
defer func() { _ = os.Chdir(origDir) }()
5959

6060
// First init
6161
initCmd := initialize.Cmd()

‎internal/cli/loop/loop_test.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ func TestLoopCommand(t *testing.T) {
2323
if err := os.Chdir(tmpDir); err != nil {
2424
t.Fatalf("failed to chdir: %v", err)
2525
}
26-
defer os.Chdir(origDir)
26+
defer func() { _ = os.Chdir(origDir) }()
2727

2828
// Create a PROMPT.md file
2929
if err := os.WriteFile("PROMPT.md", []byte("# Test Prompt\n"), 0644); err != nil {

‎internal/cli/session/session_test.go‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ func TestSessionCommands(t *testing.T) {
187187
if err := os.Chdir(tmpDir); err != nil {
188188
t.Fatalf("failed to chdir: %v", err)
189189
}
190-
defer os.Chdir(origDir)
190+
defer func() { _ = os.Chdir(origDir) }()
191191

192192
// First init
193193
initCmd := initialize.Cmd()
@@ -252,7 +252,7 @@ func TestSessionParse(t *testing.T) {
252252
if err := os.Chdir(tmpDir); err != nil {
253253
t.Fatalf("failed to chdir: %v", err)
254254
}
255-
defer os.Chdir(origDir)
255+
defer func() { _ = os.Chdir(origDir) }()
256256

257257
// Create a test jsonl file
258258
jsonlContent := `{"type":"user","message":{"role":"user","content":"Hello"},"timestamp":"2025-01-21T10:00:00Z"}
@@ -283,7 +283,7 @@ func TestSessionParseWithExtract(t *testing.T) {
283283
if err := os.Chdir(tmpDir); err != nil {
284284
t.Fatalf("failed to chdir: %v", err)
285285
}
286-
defer os.Chdir(origDir)
286+
defer func() { _ = os.Chdir(origDir) }()
287287

288288
// Create a test jsonl file with content that should trigger extraction
289289
jsonlContent := `{"type":"assistant","message":{"role":"assistant","content":"We decided to use PostgreSQL for the database. I learned that connection pooling is important."},"timestamp":"2025-01-21T10:00:00Z"}
@@ -313,7 +313,7 @@ func TestSessionParseWithOutput(t *testing.T) {
313313
if err := os.Chdir(tmpDir); err != nil {
314314
t.Fatalf("failed to chdir: %v", err)
315315
}
316-
defer os.Chdir(origDir)
316+
defer func() { _ = os.Chdir(origDir) }()
317317

318318
// Create a test jsonl file
319319
jsonlContent := `{"type":"user","message":{"role":"user","content":"Hello"},"timestamp":"2025-01-21T10:00:00Z"}

‎internal/cli/status/status_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ func TestStatusCommand(t *testing.T) {
2525
if err := os.Chdir(tmpDir); err != nil {
2626
t.Fatalf("failed to chdir: %v", err)
2727
}
28-
defer os.Chdir(origDir)
28+
defer func() { _ = os.Chdir(origDir) }()
2929

3030
// First init
3131
initCmd := initialize.Cmd()
@@ -55,7 +55,7 @@ func TestStatusJSONOutput(t *testing.T) {
5555
if err := os.Chdir(tmpDir); err != nil {
5656
t.Fatalf("failed to chdir: %v", err)
5757
}
58-
defer os.Chdir(origDir)
58+
defer func() { _ = os.Chdir(origDir) }()
5959

6060
// First init
6161
initCmd := initialize.Cmd()

0 commit comments

Comments
 (0)