fix: remove single-char string exemption from TestNoMagicStrings

No string literal gets a free pass — "/" is a directory separator,
"-" is a dash, "." is a dot. All must use config constants.

Added token.Slash, token.Dot, token.Plus, token.Hash to
config/token/delim.go. Migrated 30 single-char magic strings
across 16 files to use token.*, marker.*, or config constants.

Signed-off-by: Jose Alekhinne <jose@ctx.ist>

Author: josealekhine

internal/audit/magic_strings_test.go

@@ -126,27 +126,6 @@ func checkMagicString(
 		return
 	}
 
-	// Single-character strings that are already defined
-	// as token constants are exempt only when used as
-	// such. But we cannot distinguish usage context in
-	// a simple AST walk, so we exempt the most common
-	// structural punctuation: slash, dot, colon, hash,
-	// equals, pipe, ampersand, question mark, at-sign,
-	// semicolon, tilde, underscore, and quotes.
-	if len(s) == 1 {
-		r := rune(s[0])
-		switch r {
-		case '/', '.', ':', '#', '=', '|', '&',
-			'?', '@', ';', '~', '_', '\'', '"',
-			'*', '>', '<', '!', '+', ',', '\\',
-			'(', ')', '[', ']', '{', '}':
-			return
-		}
-		// Non-punctuation single chars (letters, digits,
-		// special symbols like "-") fall through to the
-		// violation check.
-	}
-
 	// Format verbs ("%s", "%d %s", etc.).
 	if isFormatString(s) {
 		return

internal/cli/dep/core/format.go

@@ -26,7 +26,9 @@ import (
 //   - string: Safe Mermaid node identifier
 func MermaidID(pkg string) string {
 	r := strings.NewReplacer(
-		"/", "_", ".", "_", token.Dash, "_",
+		token.Slash, token.Underscore,
+		token.Dot, token.Underscore,
+		token.Dash, token.Underscore,
 	)
 	return r.Replace(pkg)
 }

internal/cli/dep/core/go.go

@@ -13,6 +13,7 @@ import (
 	"strings"
 
 	cfgDep "github.com/ActiveMemory/ctx/internal/config/dep"
+	"github.com/ActiveMemory/ctx/internal/config/token"
 	execDep "github.com/ActiveMemory/ctx/internal/exec/dep"
 )
 
@@ -97,10 +98,10 @@ func ListGoPackages() ([]GoPackage, error) {
 //   - bool: True if the path is a stdlib package
 func IsStdlib(path string) bool {
 	first := path
-	if i := strings.Index(path, "/"); i >= 0 {
+	if i := strings.Index(path, token.Slash); i >= 0 {
 		first = path[:i]
 	}
-	return !strings.Contains(first, ".")
+	return !strings.Contains(first, token.Dot)
 }
 
 // ShortPkgName strips the module prefix for readability.
@@ -112,7 +113,7 @@ func IsStdlib(path string) bool {
 // Returns:
 //   - string: Shortened path, or original if prefix doesn't match
 func ShortPkgName(importPath, modPath string) string {
-	if modPath != "" && strings.HasPrefix(importPath, modPath+"/") {
+	if modPath != "" && strings.HasPrefix(importPath, modPath+token.Slash) {
 		return importPath[len(modPath)+1:]
 	}
 	return importPath

internal/cli/journal/core/format/fmt.go

@@ -46,9 +46,9 @@ func Size(bytes int64) string {
 // Returns:
 //   - string: Safe slug (e.g., "internal_config_x_go")
 func KeyFileSlug(path string) string {
-	slug := strings.ReplaceAll(path, "/", "_")
-	slug = strings.ReplaceAll(slug, ".", "_")
-	slug = strings.ReplaceAll(slug, "*", token.GlobReplace)
+	slug := strings.ReplaceAll(path, token.Slash, token.Underscore)
+	slug = strings.ReplaceAll(slug, token.Dot, token.Underscore)
+	slug = strings.ReplaceAll(slug, token.GlobStar, token.GlobReplace)
 	return slug
 }
 

internal/cli/journal/core/normalize/normalize.go

@@ -142,7 +142,7 @@ func Content(content string, fencesVerified bool) string {
 			inner := m[1 : len(m)-1] // strip backticks
 			inner = strings.ReplaceAll(inner, marker.AngleLT, marker.EntityLT)
 			inner = strings.ReplaceAll(inner, marker.AngleGT, marker.EntityGT)
-			return `"` + inner + `"`
+			return token.DoubleQuote + inner + token.DoubleQuote
 		}
 		line = regex.InlineCodeAngle.ReplaceAllStringFunc(
 			line, replacer,

internal/cli/journal/core/parse/parse.go

@@ -18,6 +18,7 @@ import (
 	"github.com/ActiveMemory/ctx/internal/config/embed/text"
 	"github.com/ActiveMemory/ctx/internal/config/file"
 	"github.com/ActiveMemory/ctx/internal/config/journal"
+	"github.com/ActiveMemory/ctx/internal/config/marker"
 	"github.com/ActiveMemory/ctx/internal/config/regex"
 	"github.com/ActiveMemory/ctx/internal/config/token"
 	"github.com/ActiveMemory/ctx/internal/entity"
@@ -177,8 +178,10 @@ func JournalEntry(path, filename string) entity.JournalEntry {
 	// become HTML entities; backticks and # are stripped (they add no
 	// meaning inside [...] link labels).
 	entry.Title = strings.NewReplacer(
-		"<", "&lt;", ">", "&gt;",
-		token.Backtick, "", "#", "",
+		marker.AngleLT, marker.EntityLT,
+		marker.AngleGT, marker.EntityGT,
+		token.Backtick, "",
+		token.Hash, "",
 	).Replace(entry.Title)
 	entry.Title = strings.TrimSpace(entry.Title)
 

internal/cli/journal/core/wrap/wrap.go

@@ -10,6 +10,7 @@ import (
 	"strings"
 
 	"github.com/ActiveMemory/ctx/internal/config/journal"
+	"github.com/ActiveMemory/ctx/internal/config/marker"
 	"github.com/ActiveMemory/ctx/internal/config/token"
 )
 
@@ -45,7 +46,7 @@ func Content(content string) string {
 
 		// Wrap long lines (skip tables)
 		if len(line) > journal.LineWrapWidth &&
-			!strings.HasPrefix(strings.TrimSpace(line), "|") {
+			!strings.HasPrefix(strings.TrimSpace(line), marker.TablePipe) {
 			out = append(out, Soft(line, journal.LineWrapWidth)...)
 		} else {
 			out = append(out, line)

internal/cli/pad/cmd/export/cmd.go

@@ -13,6 +13,7 @@ import (
 	"github.com/ActiveMemory/ctx/internal/config/embed/cmd"
 	"github.com/ActiveMemory/ctx/internal/config/embed/flag"
 	cFlag "github.com/ActiveMemory/ctx/internal/config/flag"
+	"github.com/ActiveMemory/ctx/internal/config/token"
 )
 
 // Cmd returns the pad export subcommand.
@@ -29,7 +30,7 @@ func Cmd() *cobra.Command {
 		Long:  long,
 		Args:  cobra.MaximumNArgs(1),
 		RunE: func(cmd *cobra.Command, args []string) error {
-			dir := "."
+			dir := token.Dot
 			if len(args) > 0 {
 				dir = args[0]
 			}

internal/cli/system/core/event/event.go

@@ -16,6 +16,7 @@ import (
 	"github.com/ActiveMemory/ctx/internal/config/embed/text"
 	"github.com/ActiveMemory/ctx/internal/config/event"
 	cfgTime "github.com/ActiveMemory/ctx/internal/config/time"
+	"github.com/ActiveMemory/ctx/internal/config/token"
 	"github.com/ActiveMemory/ctx/internal/notify"
 )
 
@@ -49,7 +50,7 @@ func ExtractHookName(e notify.Payload) string {
 		return e.Detail.Hook
 	}
 	// Fall back to extracting from message prefix (e.g., "qa-reminder: ...")
-	if idx := strings.Index(e.Message, ":"); idx > 0 {
+	if idx := strings.Index(e.Message, token.Colon); idx > 0 {
 		return e.Message[:idx]
 	}
 	return event.HookFallback

internal/cli/system/core/version/version.go

@@ -35,7 +35,7 @@ import (
 //   - minor: minor version number
 //   - ok: true if parsing succeeded
 func ParseMajorMinor(ver string) (major, minor int, ok bool) {
-	parts := strings.SplitN(ver, ".", 3)
+	parts := strings.SplitN(ver, token.Dot, 3)
 	if len(parts) < 2 {
 		return 0, 0, false
 	}