refactor: dedup threshold evaluation in sysinfo

Replace 3 structurally identical memory/swap/disk check blocks
with a data-driven loop over a byteCheck slice. Same behavior,
less repetition.

Spec: specs/ast-audit-contributor-guide.md
Signed-off-by: Jose Alekhinne <jose@ctx.ist>

Author: josealekhine

internal/sysinfo/threshold.go

@@ -32,56 +32,66 @@ import (
 func Evaluate(snap Snapshot) []ResourceAlert {
 	var alerts []ResourceAlert
 
-	// Memory
-	if snap.Memory.Supported && snap.Memory.TotalBytes > 0 {
-		pct := percent(snap.Memory.UsedBytes, snap.Memory.TotalBytes)
-		msg := fmt.Sprintf(desc.Text(text.DescKeyResourcesAlertMemory),
-			pct, FormatGiB(snap.Memory.UsedBytes), FormatGiB(snap.Memory.TotalBytes))
-		if pct >= stats.ThresholdMemoryDangerPct {
-			alerts = append(alerts, ResourceAlert{
-				Severity: SeverityDanger, Resource: cfgSysinfo.ResourceMemory, Message: msg,
-			})
-		} else if pct >= stats.ThresholdMemoryWarnPct {
-			alerts = append(alerts, ResourceAlert{
-				Severity: SeverityWarning,
-				Resource: cfgSysinfo.ResourceMemory,
-				Message:  msg,
-			})
-		}
+	type byteCheck struct {
+		supported bool
+		used      uint64
+		total     uint64
+		descKey   string
+		resource  string
+		dangerPct float64
+		warnPct   float64
 	}
 
-	// Swap
-	if snap.Memory.Supported && snap.Memory.SwapTotalBytes > 0 {
-		pct := percent(snap.Memory.SwapUsedBytes, snap.Memory.SwapTotalBytes)
-		msg := fmt.Sprintf(
-			desc.Text(text.DescKeyResourcesAlertSwap),
-			pct,
-			FormatGiB(snap.Memory.SwapUsedBytes),
-			FormatGiB(snap.Memory.SwapTotalBytes),
-		)
-		if pct >= stats.ThresholdSwapDangerPct {
-			alerts = append(alerts, ResourceAlert{
-				Severity: SeverityDanger, Resource: cfgSysinfo.ResourceSwap, Message: msg,
-			})
-		} else if pct >= stats.ThresholdSwapWarnPct {
-			alerts = append(alerts, ResourceAlert{
-				Severity: SeverityWarning, Resource: cfgSysinfo.ResourceSwap, Message: msg,
-			})
-		}
+	checks := []byteCheck{
+		{
+			snap.Memory.Supported,
+			snap.Memory.UsedBytes,
+			snap.Memory.TotalBytes,
+			text.DescKeyResourcesAlertMemory,
+			cfgSysinfo.ResourceMemory,
+			stats.ThresholdMemoryDangerPct,
+			stats.ThresholdMemoryWarnPct,
+		},
+		{
+			snap.Memory.Supported,
+			snap.Memory.SwapUsedBytes,
+			snap.Memory.SwapTotalBytes,
+			text.DescKeyResourcesAlertSwap,
+			cfgSysinfo.ResourceSwap,
+			stats.ThresholdSwapDangerPct,
+			stats.ThresholdSwapWarnPct,
+		},
+		{
+			snap.Disk.Supported,
+			snap.Disk.UsedBytes,
+			snap.Disk.TotalBytes,
+			text.DescKeyResourcesAlertDisk,
+			cfgSysinfo.ResourceDisk,
+			stats.ThresholdDiskDangerPct,
+			stats.ThresholdDiskWarnPct,
+		},
 	}
 
-	// Disk
-	if snap.Disk.Supported && snap.Disk.TotalBytes > 0 {
-		pct := percent(snap.Disk.UsedBytes, snap.Disk.TotalBytes)
-		msg := fmt.Sprintf(desc.Text(text.DescKeyResourcesAlertDisk),
-			pct, FormatGiB(snap.Disk.UsedBytes), FormatGiB(snap.Disk.TotalBytes))
-		if pct >= stats.ThresholdDiskDangerPct {
+	for _, c := range checks {
+		if !c.supported || c.total == 0 {
+			continue
+		}
+		pct := percent(c.used, c.total)
+		msg := fmt.Sprintf(
+			desc.Text(c.descKey), pct,
+			FormatGiB(c.used), FormatGiB(c.total),
+		)
+		if pct >= c.dangerPct {
 			alerts = append(alerts, ResourceAlert{
-				Severity: SeverityDanger, Resource: cfgSysinfo.ResourceDisk, Message: msg,
+				Severity: SeverityDanger,
+				Resource: c.resource,
+				Message:  msg,
 			})
-		} else if pct >= stats.ThresholdDiskWarnPct {
+		} else if pct >= c.warnPct {
 			alerts = append(alerts, ResourceAlert{
-				Severity: SeverityWarning, Resource: cfgSysinfo.ResourceDisk, Message: msg,
+				Severity: SeverityWarning,
+				Resource: c.resource,
+				Message:  msg,
 			})
 		}
 	}