Relax bad cmd handling in subshell

Author: daved

internal/subshell/bash/bash.go

@@ -176,11 +176,7 @@ func (v *SubShell) Activate(proj *project.Project, cfg sscommon.Configurable, ou
 		directEnv = sscommon.EnvSlice(v.env)
 	}
 
-	cmd, err := sscommon.NewCommand(v.Binary(), shellArgs, directEnv)
-	if err != nil {
-		return err
-	}
-
+	cmd := sscommon.NewCommand(v.Binary(), shellArgs, directEnv)
 	v.errs = sscommon.Start(cmd)
 	v.cmd = cmd
 	return nil

internal/subshell/cmd/cmd.go

@@ -165,11 +165,7 @@ func (v *SubShell) Activate(prj *project.Project, cfg sscommon.Configurable, out
 		directEnv = sscommon.EnvSlice(v.env)
 	}
 
-	cmd, err := sscommon.NewCommand("cmd", shellArgs, directEnv)
-	if err != nil {
-		return err
-	}
-
+	cmd := sscommon.NewCommand("cmd", shellArgs, directEnv)
 	v.errs = sscommon.Start(cmd)
 	v.cmd = cmd
 	return nil

internal/subshell/fish/fish.go

@@ -152,11 +152,7 @@ func (v *SubShell) Activate(proj *project.Project, cfg sscommon.Configurable, ou
 		directEnv = sscommon.EnvSlice(v.env)
 	}
 
-	cmd, err := sscommon.NewCommand(v.Binary(), shellArgs, directEnv)
-	if err != nil {
-		return err
-	}
-
+	cmd := sscommon.NewCommand(v.Binary(), shellArgs, directEnv)
 	v.errs = sscommon.Start(cmd)
 	v.cmd = cmd
 	return nil

internal/subshell/sscommon/sscommon.go

@@ -7,31 +7,18 @@ import (
 	"strings"
 
 	"github.com/ActiveState/cli/internal/errs"
-	"github.com/ActiveState/cli/internal/fileutils"
 	"github.com/ActiveState/cli/internal/locale"
 	"github.com/ActiveState/cli/internal/logging"
 	"github.com/ActiveState/cli/internal/osutils"
 	"github.com/ActiveState/cli/internal/sighandler"
 )
 
-func NewCommand(command string, args []string, env []string) (*exec.Cmd, error) {
-	if !fileutils.IsExecutable(command) {
-		err := locale.NewInputError(
-			"err_sscommon_command_not_executable",
-			"Command '{{.V0}}' is not an executable.",
-			command,
-		)
-		return nil, errs.AddTips(err,
-			"Ensure that the targeted command is a valid executable.",
-			"Checking environment vars like SHELL may help resolve this.",
-		)
-	}
-
+func NewCommand(command string, args []string, env []string) *exec.Cmd {
 	cmd := exec.Command(command, args...)
 	if env != nil {
 		cmd.Env = append(os.Environ(), env...)
 	}
-	return cmd, nil
+	return cmd
 }
 
 // Start wires stdin/stdout/stderr into the provided command, starts it, and
@@ -66,7 +53,11 @@ func Start(cmd *exec.Cmd) chan error {
 				return
 			}
 
-			errors <- errs.Wrap(err, "Command Failed: %s", cmd.String())
+			err = errs.AddTips(errs.Wrap(err, "Command Failed: %s", cmd.String()),
+				"Checking environment vars like SHELL may help resolve this.",
+			)
+			errors <- err
+
 			return
 		}
 	}()

internal/subshell/tcsh/tcsh.go

@@ -146,11 +146,7 @@ func (v *SubShell) Activate(proj *project.Project, cfg sscommon.Configurable, ou
 		directEnv = sscommon.EnvSlice(v.env)
 	}
 
-	cmd, err := sscommon.NewCommand(v.Binary(), shellArgs, directEnv)
-	if err != nil {
-		return err
-	}
-
+	cmd := sscommon.NewCommand(v.Binary(), shellArgs, directEnv)
 	v.errs = sscommon.Start(cmd)
 	v.cmd = cmd
 	return nil

internal/subshell/zsh/zsh.go

@@ -196,11 +196,7 @@ func (v *SubShell) Activate(proj *project.Project, cfg sscommon.Configurable, ou
 		directEnv = sscommon.EnvSlice(v.env)
 	}
 
-	cmd, err := sscommon.NewCommand(v.Binary(), nil, directEnv)
-	if err != nil {
-		return err
-	}
-
+	cmd := sscommon.NewCommand(v.Binary(), nil, directEnv)
 	v.errs = sscommon.Start(cmd)
 	v.cmd = cmd
 	return nil