chore: Fixed/ignored lint errors

ijlee2 · mixonic · commit ca77b18a3462 · 2025-07-03T11:43:22.000-04:00
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -28,7 +28,14 @@ module.exports = {
     browser: true,
   },
   rules: {
-    'ember-best-practices/require-dependent-keys': 'off',
+    'ember/no-classic-classes': 'off', // 41 errors
+    'ember/no-classic-components': 'off', // 20 errors
+    'ember/no-component-lifecycle-hooks': 'off', // 12 errors
+    'ember/no-get': 'off', // 406 errors
+    'ember/no-runloop': 'off', // 26 errors
+    'ember/require-computed-property-dependencies': 'off', // 23 errors
+    'ember/require-tagless-components': 'off', // 14 errors
+    'ember-best-practices/require-dependent-keys': 'off', // 56 errors
     'no-restricted-imports': [
       'error',
       {
diff --git a/.prettierrc.js b/.prettierrc.js
@@ -1 +1,2 @@
+// eslint-disable-next-line n/no-unpublished-require
 module.exports = require('@addepar/prettier-config');
diff --git a/addon-test-support/pages/-private/ember-table-header.js b/addon-test-support/pages/-private/ember-table-header.js
@@ -17,11 +17,13 @@ function computedStyleInPixels(target, property) {
 }
 
 export const SortPage = PageObject.extend({
+  // eslint-disable-next-line ember/avoid-leaking-state-in-ember-objects
   indicator: {
     scope: '[data-test-sort-indicator]',
     isAscending: hasClass('is-ascending'),
     isDescending: hasClass('is-descending'),
   },
+  // eslint-disable-next-line ember/avoid-leaking-state-in-ember-objects
   toggle: {
     scope: '[data-test-sort-toggle]',
   },
diff --git a/addon/-private/collapse-tree.js b/addon/-private/collapse-tree.js
@@ -24,6 +24,7 @@ export const TableRowMeta = EmberObject.extend({
     get() {
       let rowValue = get(this, '_rowValue');
 
+      // eslint-disable-next-line no-prototype-builtins
       if (rowValue.hasOwnProperty('isCollapsed')) {
         return get(rowValue, 'isCollapsed');
       } else {
@@ -34,6 +35,7 @@ export const TableRowMeta = EmberObject.extend({
     set(key, isCollapsed) {
       let rowValue = get(this, '_rowValue');
 
+      // eslint-disable-next-line no-prototype-builtins
       if (rowValue.hasOwnProperty('isCollapsed')) {
         set(rowValue, 'isCollapsed', isCollapsed);
       } else {
@@ -588,6 +590,7 @@ const CollapseTreeNode = EmberObject.extend({
       children.push(sortedChildren.slice(sliceStart));
     }
 
+    // eslint-disable-next-line ember/no-side-effects
     this._childNodes = children;
 
     return children;
@@ -813,6 +816,7 @@ export default EmberObject.extend(EmberArray, {
 
     let rows = get(this, 'rows');
 
+    // eslint-disable-next-line ember/no-side-effects
     this._root = CollapseTreeNode.create({ value: { children: rows }, tree: this });
 
     return this._root;
diff --git a/addon/-private/column-tree.js b/addon/-private/column-tree.js
@@ -111,6 +111,7 @@ const TableColumnMeta = EmberObject.extend({
     return this.get('_node.leaves.length');
   }),
 
+  // eslint-disable-next-line ember/require-return-from-computed
   index: computed('isLeaf', '_node.offsetIndex', function() {
     if (this.get('isLeaf')) {
       return this.get('_node.offsetIndex');
@@ -167,6 +168,7 @@ const ColumnTreeNode = EmberObject.extend({
     let column = get(this, 'column');
 
     if (!parent) {
+      // eslint-disable-next-line ember/no-assignment-of-untracked-properties-used-in-tracking-contexts
       this.isRoot = true;
     } else {
       let columnMetaCache = get(tree, 'columnMetaCache');
@@ -222,6 +224,7 @@ const ColumnTreeNode = EmberObject.extend({
     let tree = get(this, 'tree');
     let parent = this;
 
+    // eslint-disable-next-line ember/no-side-effects
     this._subcolumnNodes = emberA(
       get(this, 'column.subcolumns').map(column => ColumnTreeNode.create({ column, tree, parent }))
     );
@@ -622,6 +625,7 @@ export default EmberObject.extend({
 
     let columns = get(this, 'columns');
 
+    // eslint-disable-next-line ember/no-side-effects
     this._root = ColumnTreeNode.create({ column: { subcolumns: columns }, tree: this });
     return this._root;
   }),
diff --git a/addon/-private/utils/observer.js b/addon/-private/utils/observer.js
@@ -4,9 +4,10 @@ import { assert } from '@ember/debug';
 // eslint-disable-next-line no-restricted-imports
 import { observer as emberObserver } from '@ember/object';
 
-// eslint-disable-next-line no-restricted-imports
 import {
+  // eslint-disable-next-line no-restricted-imports
   addObserver as emberAddObserver,
+  // eslint-disable-next-line no-restricted-imports
   removeObserver as emberRemoveObserver,
 } from '@ember/object/observers';
 
@@ -17,6 +18,7 @@ function asyncObserver(...args) {
   let dependentKeys = args;
   let sync = false;
 
+  // eslint-disable-next-line ember/no-observers
   return emberObserver({ dependentKeys, fn, sync });
 }
 
@@ -37,6 +39,7 @@ function asyncAddObserver(...args) {
     method = args[3];
   }
 
+  // eslint-disable-next-line ember/no-observers
   return emberAddObserver(obj, path, target, method, sync);
 }
 
diff --git a/addon/components/-private/scroll-indicators/component.js b/addon/components/-private/scroll-indicators/component.js
@@ -337,6 +337,7 @@ export default Component.extend({
     addObserver(this, 'enabledIndicators', this._updateListeners);
   },
 
+  // eslint-disable-next-line ember/require-super-in-lifecycle-hooks
   willDestroy() {
     if (this._isListening) {
       this._removeListeners();
diff --git a/addon/components/ember-tbody/component.js b/addon/components/ember-tbody/component.js
@@ -289,7 +289,9 @@ export default Component.extend({
       let scheduleUpdate = (this._scheduleUpdate = () => {
         scheduleOnce('actions', this, this._updateDataTestRowCount);
       });
+      // eslint-disable-next-line ember/no-observers
       this.collapseTree.addObserver('rows', scheduleUpdate);
+      // eslint-disable-next-line ember/no-observers
       this.collapseTree.addObserver('[]', scheduleUpdate);
     }
 
@@ -330,6 +332,7 @@ export default Component.extend({
     }
   ),
 
+  // eslint-disable-next-line ember/require-super-in-lifecycle-hooks
   willDestroy() {
     for (let [row, meta] of this.rowMetaCache.entries()) {
       meta.destroy();
@@ -351,7 +354,9 @@ export default Component.extend({
   wrappedRows: computed('rows', function() {
     let rows = this.get('rows');
 
+    // eslint-disable-next-line ember/no-side-effects
     this.collapseTree.set('rowMetaCache', this.rowMetaCache);
+    // eslint-disable-next-line ember/no-side-effects
     this.collapseTree.set('rows', rows);
 
     return this.collapseTree;
diff --git a/addon/components/ember-td/component.js b/addon/components/ember-td/component.js
@@ -74,6 +74,7 @@ export default BaseTableCell.extend({
   onDoubleClick: null,
 
   // only watch `api` due to a bug in Ember
+  // eslint-disable-next-line ember/require-computed-macros
   unwrappedApi: computed('api', function() {
     return this.get('api.api') || this.get('api');
   }),
diff --git a/addon/components/ember-thead/component.js b/addon/components/ember-thead/component.js
@@ -240,6 +240,7 @@ export default Component.extend({
     let columnKeyPath = this.get('columnKeyPath');
     this.columnMetaCache = new MetaCache({ keyPath: columnKeyPath });
 
+    // eslint-disable-next-line ember/no-assignment-of-untracked-properties-used-in-tracking-contexts
     this.columnTree = ColumnTree.create({
       onReorder: this.onReorder?.bind(this),
       onResize: this.onResize?.bind(this),
diff --git a/tests/acceptance/docs-test.js b/tests/acceptance/docs-test.js
@@ -101,18 +101,21 @@ module('Acceptance | docs', function(hooks) {
 
     await header.click();
     assert.true(
+      // eslint-disable-next-line qunit/no-assert-logical-expression
       header.sortIndicator.isPresent && header.sortIndicator.isDescending,
       'sort descending'
     );
 
     await header.click();
     assert.true(
+      // eslint-disable-next-line qunit/no-assert-logical-expression
       header.sortIndicator.isPresent && header.sortIndicator.isAscending,
       'sort ascending'
     );
 
     await header.click();
     assert.true(
+      // eslint-disable-next-line qunit/no-assert-logical-expression
       header.sortIndicator.isPresent && header.sortIndicator.isDescending,
       'sort cycles back to descending'
     );
diff --git a/tests/dummy/app/controllers/docs/guides/header/fixed-columns.js b/tests/dummy/app/controllers/docs/guides/header/fixed-columns.js
@@ -1,6 +1,6 @@
 import Controller from '@ember/controller';
 import { A as emberA } from '@ember/array';
-import { get, set, action } from '@ember/object';
+import { set, action } from '@ember/object';
 
 import { generateRows } from 'dummy/utils/generators';
 import { computed } from '@ember/object';
diff --git a/tests/dummy/app/controllers/docs/guides/header/size-constraints.js b/tests/dummy/app/controllers/docs/guides/header/size-constraints.js
@@ -23,6 +23,7 @@ export default Controller.extend({
   init() {
     this._super(...arguments);
 
+    // eslint-disable-next-line ember/no-observers
     addObserver(this, 'widthConstraint', this.setDefaultResizeMode);
   },
 
diff --git a/tests/helpers/generate-table.js b/tests/helpers/generate-table.js
@@ -161,5 +161,6 @@ export async function generateTable(testContext, ...args) {
 
   await render(fullTable);
 
+  // eslint-disable-next-line ember/no-settled-after-test-helper
   await settled();
 }
diff --git a/tests/integration/components/basic-test.js b/tests/integration/components/basic-test.js
@@ -308,6 +308,7 @@ module('Integration | basic', function() {
         </div>
       `);
 
+      // eslint-disable-next-line ember/no-settled-after-test-helper
       await settled();
       assert.strictEqual(table.rows.length, itemsCount, 'renders the correct number of rows');
     });
@@ -331,6 +332,7 @@ module('Integration | basic', function() {
         </div>
       `);
 
+      // eslint-disable-next-line ember/no-settled-after-test-helper
       await settled();
       assert
         .dom('[data-test-inverse-yield]')
@@ -350,6 +352,7 @@ module('Integration | basic', function() {
       for (let tagName of ['th', 'td']) {
         classList = find(`${tagName}:nth-of-type(1)`).classList;
         assert.false(
+          // eslint-disable-next-line qunit/no-assert-logical-expression
           classList.contains('ember-table__text-align-left') ||
             classList.contains('ember-table__text-align-center') ||
             classList.contains('ember-table__text-align-right'),
diff --git a/tests/integration/components/cell-test.js b/tests/integration/components/cell-test.js
@@ -3,7 +3,7 @@ import hbs from 'htmlbars-inline-precompile';
 
 import { generateTable, generateColumns } from '../../helpers/generate-table';
 import { componentModule } from '../../helpers/module';
-import { set, get } from '@ember/object';
+import { set } from '@ember/object';
 
 import { fillIn, render, settled } from '@ember/test-helpers';
 
@@ -109,6 +109,7 @@ module('Integration | cell', function() {
         </div>
       `);
 
+      // eslint-disable-next-line ember/no-settled-after-test-helper
       await settled();
 
       await fillIn('input', 'Z');
@@ -138,6 +139,7 @@ module('Integration | cell', function() {
         </EmberTable>
       `);
 
+      // eslint-disable-next-line ember/no-settled-after-test-helper
       await settled();
 
       let row = table.rows.objectAt(0);
@@ -177,6 +179,7 @@ module('Integration | cell', function() {
         </EmberTable>
       `);
 
+      // eslint-disable-next-line ember/no-settled-after-test-helper
       await settled();
 
       let header = table.headers.objectAt(0);
diff --git a/tests/integration/components/headers/ember-th-test.js b/tests/integration/components/headers/ember-th-test.js
@@ -11,6 +11,7 @@ let table = new TablePage();
 module('[Unit] ember-th', function(hooks) {
   setupRenderingTest(hooks);
 
+  // eslint-disable-next-line qunit/require-expect
   test('A header cell accepts a block', async function(assert) {
     assert.expect(4);
 
@@ -83,6 +84,7 @@ module('[Unit] ember-th', function(hooks) {
       </EmberTable>
     `);
 
+    // eslint-disable-next-line ember/no-settled-after-test-helper
     await settled();
 
     let headers = table.headers.toArray();
@@ -117,6 +119,7 @@ module('[Unit] ember-th', function(hooks) {
       </EmberTable>
     `);
 
+    // eslint-disable-next-line ember/no-settled-after-test-helper
     await settled();
 
     let header = table.headers.objectAt(0);
diff --git a/tests/integration/components/headers/main-test.js b/tests/integration/components/headers/main-test.js
@@ -444,6 +444,7 @@ module('Integration | header | main', function() {
       assert.strictEqual(slackHeader.logicalWidth, 50, 'slack column receives the balance');
     });
 
+    // eslint-disable-next-line qunit/no-identical-names
     test('gte-container-slack', async function(assert) {
       await generateTable(this, {
         widthConstraint: 'gte-container-slack',
diff --git a/tests/integration/components/headers/reorder-test.js b/tests/integration/components/headers/reorder-test.js
@@ -23,7 +23,7 @@ const table = new TablePage();
  * pixels to stay from the edge.
  *
  */
-export async function scrollToEdge(targetElement, edgeOffset, direction) {
+async function scrollToEdge(targetElement, edgeOffset, direction) {
   let targetElementRight = targetElement.getBoundingClientRect().right;
   let container = find('.ember-table');
 
@@ -368,6 +368,7 @@ module('Integration | headers | reorder', function() {
       );
     });
 
+    // eslint-disable-next-line qunit/no-identical-names
     test('scroll container scrolls reordering at right edge', async function(assert) {
       let columnCount = 20;
       let columnWidth = 100;
@@ -395,6 +396,7 @@ module('Integration | headers | reorder', function() {
       );
     });
 
+    // eslint-disable-next-line qunit/no-identical-names
     test('scroll container scrolls reordering at left edge', async function(assert) {
       let columnCount = 20;
       let columnWidth = 100;
diff --git a/tests/integration/components/loading-more-test.js b/tests/integration/components/loading-more-test.js
@@ -21,6 +21,7 @@ module('Integration | loading more', function() {
         </EmberTable>
       `);
 
+      // eslint-disable-next-line ember/no-settled-after-test-helper
       await settled();
 
       assert.dom('[data-test-custom-spinner]').exists('Renders a custom spinner');
@@ -35,6 +36,7 @@ module('Integration | loading more', function() {
         </EmberTable>
       `);
 
+      // eslint-disable-next-line ember/no-settled-after-test-helper
       await settled();
 
       assert.true(table.loadingMore.isShown, 'Loading more indicator is shown');
@@ -49,6 +51,7 @@ module('Integration | loading more', function() {
         </EmberTable>
       `);
 
+      // eslint-disable-next-line ember/no-settled-after-test-helper
       await settled();
 
       assert.false(table.loadingMore.isShown, 'Loading more indicator is not shown');
@@ -63,6 +66,7 @@ module('Integration | loading more', function() {
         </EmberTable>
       `);
 
+      // eslint-disable-next-line ember/no-settled-after-test-helper
       await settled();
 
       assert.true(
@@ -80,6 +84,7 @@ module('Integration | loading more', function() {
         </EmberTable>
       `);
 
+      // eslint-disable-next-line ember/no-settled-after-test-helper
       await settled();
 
       assert.false(
@@ -103,6 +108,7 @@ module('Integration | loading more', function() {
         </EmberTable>
       `);
 
+      // eslint-disable-next-line ember/no-settled-after-test-helper
       await settled();
       await scrollTo(table.overflow(), scrollLeft, 0);
 
diff --git a/tests/integration/components/meta-test.js b/tests/integration/components/meta-test.js
diff --git a/tests/integration/components/selection-test.js b/tests/integration/components/selection-test.js
diff --git a/tests/integration/components/tree-test.js b/tests/integration/components/tree-test.js
diff --git a/tests/unit/-private/collapse-tree-test.js b/tests/unit/-private/collapse-tree-test.js
diff --git a/tests/unit/-private/column-tree-test.js b/tests/unit/-private/column-tree-test.js

Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
	`1`	`+// eslint-disable-next-line n/no-unpublished-require`
`1`	`2`	`module.exports = require('@addepar/prettier-config');`