From da130d25da7fc4b85ab697596a376f75d344ae31 Mon Sep 17 00:00:00 2001 From: Abir Abbas Date: Fri, 23 Oct 2026 23:01:01 -0400 Subject: [PATCH 1/2] notices: say Windows builds embed the furrow engine too Since #1888 pinned furrow v0.2.0, the release workflow embeds the engine on every platform, native Windows included; the shipped notice still said Windows builds omit it. Co-Authored-By: Claude Opus 5.5 (1M context) --- THIRD-PARTY-NOTICES.md | 2 +- cmd/codeaf-notices/notices.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/THIRD-PARTY-NOTICES.md b/THIRD-PARTY-NOTICES.md index c45c71cd5b..b20901dd1e 100644 --- a/THIRD-PARTY-NOTICES.md +++ b/THIRD-PARTY-NOTICES.md @@ -2,7 +2,7 @@ This file covers every third-party Go module compiled into the codeaf binary, plus the two copied components carried in this repository's own tree. It ships beside the binaries in every release. Regenerate it with `go run ./cmd/codeaf-notices generate`. -The embedded furrow engine is a separate Apache-2.0 project from [Agent-Field/furrow](https://github.com/Agent-Field/furrow), copyright 2026 furrow contributors. Its source is maintained upstream; codeaf records its release and artifact hashes in `internal/furrowbin/pin.json`. See [furrow's licence](https://github.com/Agent-Field/furrow/blob/main/LICENSE). Explicit developer artifacts and `FURROW_SOURCE` checkouts replace that pinned engine. Native Windows builds omit it. +The embedded furrow engine is a separate Apache-2.0 project from [Agent-Field/furrow](https://github.com/Agent-Field/furrow), copyright 2026 furrow contributors. Its source is maintained upstream; codeaf records its release and artifact hashes in `internal/furrowbin/pin.json`. See [furrow's licence](https://github.com/Agent-Field/furrow/blob/main/LICENSE). Explicit developer artifacts and `FURROW_SOURCE` checkouts replace that pinned engine. Every release platform embeds it, native Windows included. ## charm.land/bubbletea/v2 diff --git a/cmd/codeaf-notices/notices.go b/cmd/codeaf-notices/notices.go index f709aac6da..abf545f600 100644 --- a/cmd/codeaf-notices/notices.go +++ b/cmd/codeaf-notices/notices.go @@ -326,7 +326,7 @@ func renderNotices(components []component) []byte { var out bytes.Buffer out.WriteString("# Third-party notices\n\n") out.WriteString("This file covers every third-party Go module compiled into the codeaf binary, plus the two copied components carried in this repository's own tree. It ships beside the binaries in every release. Regenerate it with `go run ./cmd/codeaf-notices generate`.\n") - out.WriteString("\nThe embedded furrow engine is a separate Apache-2.0 project from [Agent-Field/furrow](https://github.com/Agent-Field/furrow), copyright 2026 furrow contributors. Its source is maintained upstream; codeaf records its release and artifact hashes in `internal/furrowbin/pin.json`. See [furrow's licence](https://github.com/Agent-Field/furrow/blob/main/LICENSE). Explicit developer artifacts and `FURROW_SOURCE` checkouts replace that pinned engine. Native Windows builds omit it.\n") + out.WriteString("\nThe embedded furrow engine is a separate Apache-2.0 project from [Agent-Field/furrow](https://github.com/Agent-Field/furrow), copyright 2026 furrow contributors. Its source is maintained upstream; codeaf records its release and artifact hashes in `internal/furrowbin/pin.json`. See [furrow's licence](https://github.com/Agent-Field/furrow/blob/main/LICENSE). Explicit developer artifacts and `FURROW_SOURCE` checkouts replace that pinned engine. Every release platform embeds it, native Windows included.\n") for _, component := range components { fmt.Fprintf(&out, "\n## %s\n\n", component.Identifier) // THE THREE FACTS ARE A LIST because consecutive plain lines are one From 8179d62758b8e59f59b1ebd67e36ca21694fdf34 Mon Sep 17 00:00:00 2001 From: Abir Abbas Date: Fri, 23 Oct 2026 23:01:16 -0400 Subject: [PATCH 2/2] changes: entry for #1917 Co-Authored-By: Claude Opus 5.5 (1M context) --- .../unreleased/1917-notices-windows-embeds-the-engine.md | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 docs/changes/unreleased/1917-notices-windows-embeds-the-engine.md diff --git a/docs/changes/unreleased/1917-notices-windows-embeds-the-engine.md b/docs/changes/unreleased/1917-notices-windows-embeds-the-engine.md new file mode 100644 index 0000000000..5159585620 --- /dev/null +++ b/docs/changes/unreleased/1917-notices-windows-embeds-the-engine.md @@ -0,0 +1,8 @@ +--- +kind: fixed +title: the shipped third-party notice no longer says Windows builds leave out the furrow engine +pr: 1917 +surface: [build, docs] +invalidates: + - "THIRD-PARTY-NOTICES.md said native Windows builds omit the embedded furrow engine. Since #1888 pinned furrow v0.2.0, every release platform embeds it, native Windows included." +---