Ensure LinkedList<> objects are not copied

Author: willmmiles

src/AsyncEventSource.cpp

@@ -157,7 +157,7 @@ size_t AsyncEventSourceMessage::send(AsyncClient *client) {
 // Client
 
 AsyncEventSourceClient::AsyncEventSourceClient(AsyncWebServerRequest *request, AsyncEventSource *server)
-: _messageQueue(LinkedList<AsyncEventSourceMessage *>([](AsyncEventSourceMessage *m){ delete  m; }))
+: _messageQueue([](AsyncEventSourceMessage *m){ delete  m; })
 {
   _client = request->client();
   _server = server;
@@ -256,7 +256,7 @@ void AsyncEventSourceClient::_runQueue(){
 
 AsyncEventSource::AsyncEventSource(const String& url)
   : _url(url)
-  , _clients(LinkedList<AsyncEventSourceClient *>([](AsyncEventSourceClient *c){ delete c; }))
+  , _clients([](AsyncEventSourceClient *c){ delete c; })
   , _connectcb(NULL)
 {}
 

src/AsyncWebSocket.cpp

@@ -369,8 +369,8 @@ AsyncWebSocketMultiMessage* AsyncWebSocketMultiMessage::clone() const {
  constexpr size_t AWSC_PING_PAYLOAD_LEN = sizeof(AWSC_PING_PAYLOAD);
 
 AsyncWebSocketClient::AsyncWebSocketClient(AsyncWebServerRequest *request, AsyncWebSocket *server)
-  : _controlQueue(LinkedList<AsyncWebSocketControl *>([](AsyncWebSocketControl *c){ delete  c; }))
-  , _messageQueue(LinkedList<AsyncWebSocketMessage *>([](AsyncWebSocketMessage *m){ delete  m; }))
+  : _controlQueue([](AsyncWebSocketControl *c){ delete  c; })
+  , _messageQueue([](AsyncWebSocketMessage *m){ delete  m; })
   , _tempObject(NULL)
 {
   _client = request->client();
@@ -844,7 +844,7 @@ uint16_t AsyncWebSocketClient::remotePort() {
 
 AsyncWebSocket::AsyncWebSocket(const String& url)
   :_url(url)
-  ,_clients(LinkedList<AsyncWebSocketClient *>([](AsyncWebSocketClient *c){ delete c; }))
+  ,_clients([](AsyncWebSocketClient *c){ delete c; })
   ,_cNextId(1)
   ,_enabled(true)
 {
@@ -1203,7 +1203,7 @@ AsyncWebSocketMessageBuffer* AsyncWebSocket::makeBuffer(const uint8_t * data, si
   return new AsyncWebSocketMessageBuffer(std::move(buffer));
 }
 
-AsyncWebSocket::AsyncWebSocketClientLinkedList AsyncWebSocket::getClients() const {
+const AsyncWebSocket::AsyncWebSocketClientLinkedList& AsyncWebSocket::getClients() const {
   return _clients;
 }
 

src/AsyncWebSocket.h

@@ -355,7 +355,7 @@ class AsyncWebSocket: public AsyncWebHandler {
     AsyncWebSocketMessageBuffer* makeBuffer(const uint8_t * data, size_t size)  __attribute__((deprecated));
     void _cleanBuffers() {};
 
-    AsyncWebSocketClientLinkedList getClients() const;
+    const AsyncWebSocketClientLinkedList& getClients() const;
 };
 
 //WebServer response to authenticate the socket and detach the tcp client from the web server request

src/StringArray.h

@@ -80,6 +80,12 @@ class LinkedList {
     LinkedList(OnRemove onRemove) : _root(nullptr), _last(nullptr), _onRemove(onRemove) {}
     ~LinkedList() { free(); }
 
+    LinkedList(const LinkedList<T, Item>&) = delete;
+    LinkedList(LinkedList<T, Item>&&) = delete;
+    LinkedList& operator=(const LinkedList<T, Item>&) = delete;
+    LinkedList& operator=(LinkedList<T, Item>&&) = delete;
+
+
     void add(T t){
       auto it = new ItemType(std::move(t));
       if(!_root){