Update createWithSignature function using async/await

Added a test to verify deprecation warning

Author: julianmesa-gitkraken

lib/tag.js

@@ -66,77 +66,47 @@ const deprecatedCreateWithSignatureHelper = util.deprecate(function(repo, oidTar
  *                                   representing the signed message
  * @return {Oid}
  */
-Tag.createWithSignature = function(
+Tag.createWithSignature = async (
   repo,
   tagName,
   target,
   tagger,
   message,
   force,
   signingCallback
-) {
-
-  const createTag = function(repo,
-    tagName,
-    target,
-    tagger,
-    message,
-    force,
-    signingCallback) {
-    let tagBuffer;
-
-    return Tag.createBuffer(repo, tagName, target.id(), tagger, message)
-      .then((tagBufferResult) => {
-        tagBuffer = tagBufferResult;
-        return signingCallback(tagBuffer);
-      })
-      .then(({ code, signedData }) => {
-        switch (code) {
-          case NodeGit.Error.CODE.OK: {
-            const normalizedEnding = signedData.endsWith("\n") ? "" : "\n";
-            const signedTagString = tagBuffer + signedData + normalizedEnding;
-            return Tag.createFromBuffer(repo, signedTagString, force);
-          }
-          case NodeGit.Error.CODE.PASSTHROUGH:
-            return Tag.create(
-              repo,
-              tagName,
-              target,
-              tagger,
-              message,
-              force
-            );
-          default: {
-            const error = new Error(
-              `Tag.createWithSignature threw with error code ${code}`
-            );
-            error.errno = code;
-            throw error;
-          }
-        }
-      });
-  };
-
+) => {
+  let targetOid;
   if (!target.id) {
-    deprecatedCreateWithSignatureHelper(repo, target).then((targetOid) => {
-      return createTag(repo,
+    targetOid = await deprecatedCreateWithSignatureHelper(repo, target);
+  } else {
+    targetOid = target;
+  }
+
+  const tagBuffer = await Tag.createBuffer(repo, tagName, targetOid.id(), tagger, message);
+  const { code, signedData } = await signingCallback(tagBuffer);
+  switch (code) {
+    case NodeGit.Error.CODE.OK: {
+      const normalizedEnding = signedData.endsWith("\n") ? "" : "\n";
+      const signedTagString = tagBuffer + signedData + normalizedEnding;
+      return Tag.createFromBuffer(repo, signedTagString, force);
+    }
+    case NodeGit.Error.CODE.PASSTHROUGH:
+      return Tag.create(
+        repo,
         tagName,
         targetOid,
         tagger,
         message,
-        force,
-        signingCallback);
-    });
-  } else {
-    return createTag(repo,
-      tagName,
-      target,
-      tagger,
-      message,
-      force,
-      signingCallback);
+        force
+      );
+    default: {
+      const error = new Error(
+        `Tag.createWithSignature threw with error code ${code}`
+      );
+      error.errno = code;
+      throw error;
+    }
   }
-
 };
 
 /**

test/tests/tag.js

@@ -591,6 +591,42 @@ describe("Tag", function() {
     });
   });
 
+  it("will show a deprecation warning if createWithSignature use oid instead object", function() {
+    var targetCommit;
+    const name = "created-signed-tag-annotationCreate";
+    const repository = this.repository;
+    const signature = Signature.create(
+      "Shaggy Rogers",
+      "shaggy@mystery.com",
+      987654321,
+      90
+    );
+    const message = "I'm a teapot";
+    const signingCallback = () => ({
+      code: NodeGit.Error.CODE.ERROR
+    });
+
+
+    return repository.getCommit(commitPointedTo).then((commit) => {
+      targetCommit = commit;
+      return Tag.createWithSignature(
+        repository,
+        name,
+        targetCommit.id(),
+        signature,
+        message,
+        1,
+        signingCallback
+      );
+    }).then(function() {
+        assert.fail("Should not have been able to create tag");
+      }, function(error) {
+        if (error && error.errno === NodeGit.Error.CODE.ERROR) {
+          return;
+        }
+        throw error;
+      });
+  });
 
   it("can create a new signed tag with Tag.annotationCreate", function() {
     var targetCommit;