Added null-check to sessionStorage.

Author: ChrisAcrobat

Arena

@@ -3,7 +3,7 @@ function a(){
 	let _editor;
 	(()=>{
 		let acceptedDev;
-		if(GitHubApi.getSessionStorage().acceptedDev){
+		if(GitHubApi.getSessionStorage()?.acceptedDev){
 			acceptedDev = true;
 		}
 		const defaultSetup = {
@@ -91,7 +91,7 @@ function a(){
 									if(typeof url === 'string'){
 										if(url && (url[0] === '?' || url[0] === '!')){
 											if(acceptedDev === undefined){
-												let session = GitHubApi.getSessionStorage();
+												const session = GitHubApi.getSessionStorage();
 												acceptedDev = 'I accept unsandboxed sources' === (prompt('By having exclamation (!) and question (?) marks first in the URL you side steps all security features and you do so at your own risk. Only do this to URLs for code that you trust.\n\nWrite "I accept unsandboxed sources" to allow unsandboxed sources.')??'').toLowerCase();
 												session.acceptedDev = acceptedDev;
 												GitHubApi.setSessionStorage(session);

Dev/index.js

@@ -9,9 +9,9 @@ class GitHubApi{
 		return GitHubApi.#CLIENT_ID;
 	}
 	static getSession(){
-		let session = localStorage.getItem(GitHubApi.#SESSION_KEY);
+		const session = localStorage.getItem(GitHubApi.#SESSION_KEY);
 		try{
-			return JSON.parse(session ?? '{}')
+			return JSON.parse(session)
 		}catch(error){}
 		return session;
 	}

GitHubApi.js

@@ -450,12 +450,12 @@ function a(){
 							}
 						}
 						let url = option.value;
-						let session = GitHubApi.getSessionStorage();
-						if(!url.startsWith('https://ai-tournaments.github.io/') && !session.externalReplaysAccepted){
+						const session = GitHubApi.getSessionStorage();
+						if(!url.startsWith('https://ai-tournaments.github.io/') && !session?.externalReplaysAccepted){
 							session.externalReplaysAccepted = 'i accept external replay viewers' === (prompt('External replays are by default blocked for security reasons. do so at your own risk. Only do this to URLs for code that you trust.\n\nWrite "I accept external replays" to allow external replay viewers.')??'').toLowerCase();
 							GitHubApi.setSessionStorage(session);
 						}
-						if(url.startsWith('https://ai-tournaments.github.io/') || session.externalReplaysAccepted){
+						if(url.startsWith('https://ai-tournaments.github.io/') || session?.externalReplaysAccepted){
 							_element_iframe.dataset.arenaResult = JSON.stringify(_replayData.body);
 							_element_iframe.src = url;
 							document.getElementById('open-replay-in-new-tab').addEventListener('click', ()=>{

Replay/index.js

@@ -23,20 +23,20 @@ function a(){
 	if(GitHubApi.isLoggedIn()){
 		updateUserDisplay();
 		GitHubApi.fetch('user').then(response => response.json()).then(async user => {
-			let sessionStorage = GitHubApi.getSessionStorage();
-			sessionStorage.username = user.login;
-			sessionStorage.avatar_url = user.avatar_url;
+			const sessionStorage = GitHubApi.getSessionStorage();
+			sessionStorage?.username = user.login;
+			sessionStorage?.avatar_url = user.avatar_url;
 			GitHubApi.setSessionStorage(sessionStorage);
 			updateUserDisplay();
 		});
 		GitHubApi.fetch('user/following').then(response => response.json()).then(following => {
-			let sessionStorage = GitHubApi.getSessionStorage();
-			sessionStorage.following = following.map(user => user.login);
+			const sessionStorage = GitHubApi.getSessionStorage();
+			sessionStorage?.following = following.map(user => user.login);
 			GitHubApi.setSessionStorage(sessionStorage);
 		});
 		GitHubApi.fetch('user/followers').then(response => response.json()).then(followers => {
-			let sessionStorage = GitHubApi.getSessionStorage();
-			sessionStorage.followers = followers.map(user => user.login);
+			const sessionStorage = GitHubApi.getSessionStorage();
+			sessionStorage?.followers = followers.map(user => user.login);
 			GitHubApi.setSessionStorage(sessionStorage);
 		});
 	}
@@ -105,11 +105,11 @@ function a(){
 		}
 	}
 	function updateUserDisplay(){
-		let sessionStorage = GitHubApi.getSessionStorage();
-		if(sessionStorage.username){
+		const sessionStorage = GitHubApi.getSessionStorage();
+		if(sessionStorage?.username){
 			[...document.getElementsByClassName('local-username')].forEach(element => element.innerHTML = sessionStorage.username);
 		}
-		if(sessionStorage.avatar_url){
+		if(sessionStorage?.avatar_url){
 			[...document.getElementsByClassName('local-profile-image')].forEach(img => img.src = sessionStorage.avatar_url);
 		}
 	}
@@ -296,11 +296,11 @@ function a(){
 	function openWindow(header='', message='', center=false, maxWidth, displayOnce=false){
 		let isIframe = message.constructor.name === 'HTMLIFrameElement';
 		let combinedMessage = header+'\n'+(isIframe ? isIframe.srcdoc : message);
-		let sessionStorage = GitHubApi.getSessionStorage();
-		if(!sessionStorage.windowMessages){
+		const sessionStorage = GitHubApi.getSessionStorage();
+		if(!sessionStorage?.windowMessages){
 			sessionStorage.windowMessages = {};
 		}
-		if(!sessionStorage.windowMessages[combinedMessage]){
+		if(!sessionStorage?.windowMessages[combinedMessage]){
 			let windowWrapper = document.createElement('div');
 			_content.appendChild(windowWrapper);
 			if(maxWidth !== undefined){
@@ -314,8 +314,8 @@ function a(){
 			cross.classList.add('cross-close');
 			cross.onclick = ()=>{
 				if(displayOnce){
-					let sessionStorage = GitHubApi.getSessionStorage();
-					if(!sessionStorage.windowMessages){
+					const sessionStorage = GitHubApi.getSessionStorage();
+					if(!sessionStorage?.windowMessages){
 						sessionStorage.windowMessages = {};
 					}
 					sessionStorage.windowMessages[combinedMessage] = new Date().toISOString();