fx

Author: xsalonx

test/public/runs/navigationUtils.js

@@ -35,7 +35,7 @@ exports.navigateToRunsOverview = async (page) => {
 exports.navigateToRunsPerLhcPeriod = async (page, lhcPeriodId, expectedRowsCount, tabPanel='detectorQualities') => {
     await waitForNavigation(page, () => pressElement(page, 'a#lhc-period-overview', true));
     await waitForNavigation(page, () => pressElement(page, `#row${lhcPeriodId}-associatedRuns a`, true));
-    await waitForNavigation(page, () => pressElement(page, `#${tabPanel}-tab a`, true));
+    await pressElement(page, `#${tabPanel}-tab`, true);
     expectUrlParams(page, { page: 'runs-per-lhc-period', lhcPeriodId, panel: tabPanel }, ['pdpBeamType']);
     await waitForTableLength(page, expectedRowsCount);
 };

test/public/runs/runsPerLhcPeriod.overview.test.js

@@ -30,6 +30,7 @@ const {
     expectUrlParams,
     fillInput,
     expectColumnValues,
+    openFilteringPanel,
 } = require('../defaults.js');
 const { RUN_QUALITIES, RunQualities } = require('../../../lib/domain/enums/RunQualities.js');
 const { resetDatabaseContent } = require('../../utilities/resetDatabaseContent.js');
@@ -243,7 +244,7 @@ module.exports = () => {
     });
 
     it('should successfully apply detectors notBadFraction filters', async () => {
-        await pressElement(page, '#openFilterToggle', true);
+        await openFilteringPanel(page);
 
         await page.waitForSelector('#inelasticInteractionRateAvg-operator');
         await page.select('#inelasticInteractionRateAvg-operator', '<=');
@@ -281,7 +282,7 @@ module.exports = () => {
         expect(exportContent.trim()).to.be.eql([
             'runNumber,ITS',
             '105,""',
-            '56,Good (from: 1565294400000 to: 1565298000000)',
+            '56,"Good (from: 1565294400000 to: 1565298000000)"',
             '54,""',
             '49,""',
         ].join('\r\n'));

test/public/runs/runsPerSimulationPass.overview.test.js

@@ -278,8 +278,8 @@ module.exports = () => {
         expect(exportContent.trim()).to.be.eql([
             'runNumber,CPV',
             '108,""',
-            '107,"Bad (from: 1565272000000 to: 1565337000000) | Bad (from: 1565340600000 to: 1565359200000)"',
-            '106,""'
+            '107,""',
+            '106,"Bad (from: 1565272000000 to: 1565337000000) | Bad (from: 1565340600000 to: 1565359200000)"'
         ].join('\r\n'));
         fs.unlinkSync(path.resolve(downloadPath, targetFileName));
     });