Skip to content

Commit 94e36ee

Browse files
committed
[O2B-1524] Add tooltip to GAQ button
Added tooltip indicating that the GAQ Summary is disabled and prompting users to click to view GAQ flags. Updated the corresponding test to verify the tooltip's presence.
1 parent 2c6dc20 commit 94e36ee

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

lib/public/views/Runs/RunPerDataPass/RunsPerDataPassOverviewPage.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,13 @@ export const RunsPerDataPassOverviewPage = ({
160160
),
161161
visible: true,
162162
format: (_, { runNumber }) => {
163-
const gaqDisplay = h('button.btn.btn-primary.w-100', 'GAQ');
163+
const gaqDisplay = h('button.btn.btn-primary.w-100', [
164+
'GAQ',
165+
h(
166+
'.d-inline-block.va-t-bottom',
167+
tooltip(h('.f7', iconWarning()), 'GAQ Summary is disabled, please click to view GAQ flags'),
168+
),
169+
]);
164170
return frontLink(gaqDisplay, 'gaq-flags', { dataPassId, runNumber });
165171
},
166172
filter: ({ filteringModel }) => numericalComparisonFilter(

test/public/runs/runsPerDataPass.overview.test.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,8 @@ module.exports = () => {
147147

148148
await expectInnerText(page, '#row106-globalAggregatedQuality', 'GAQ');
149149

150+
expect(await getPopoverInnerText(await page.waitForSelector('#row106-globalAggregatedQuality .popover-trigger')))
151+
.to.be.equal('GAQ Summary is disabled, please click to view GAQ flags');
150152
});
151153

152154
it('should ignore QC flags created by services in QC summaries of AOT and MUON ', async () => {

0 commit comments

Comments
 (0)