[O2B-1479] Remove redundant ?? in table.js, Processed @isaachilly 's feedback

Author: Houwie7000

lib/public/components/common/table/table.js

@@ -153,7 +153,7 @@ export const table = (
 
     const scrollEnabled = horizontalScrollEnabled || verticalScrollEnabled;
     let optionalTableClassesExpression = freezeFirstColumn && horizontalScrollEnabled ? '.freeze-first-column' : '';
-    optionalTableClassesExpression += tableClasses ?? '';
+    optionalTableClassesExpression += tableClasses;
 
     const firstLevelWrapperClasses =
         (verticalScrollEnabled ? '.sticky-table-wrapper' : '') +

lib/public/utilities/formatting/formatBeamType.js

@@ -23,6 +23,6 @@ export const formatBeamType = (beamType = '') => {
     if (beamOneType !== '' && beamTwoType !== '') {
         return h('', [beamOneType.trim(), h('br'), beamTwoType.trim()]);
     } else {
-        return '-';
+        return h('', '-');
     }
 };

lib/public/views/LhcFills/ActiveColumns/lhcFillsActiveColumns.js

@@ -16,6 +16,7 @@ import { formatTimestamp } from '../../../utilities/formatting/formatTimestamp.j
 import { formatDuration } from '../../../utilities/formatting/formatDuration.mjs';
 import { formatPercentage } from '../../../utilities/formatting/formatPercentage.js';
 import { CopyToClipboardComponent, h } from '/js/src/index.js';
+import { iconPlus } from '/js/src/icons.js';
 import { formatRunsList } from '../../Runs/format/formatRunsList.js';
 import { formatLhcFillsTimeLoss } from '../format/formatLhcFillsTimeLoss.js';
 import { buttonLinkWithDropdown } from '../../../components/common/selection/infoLoggerButtonGroup/buttonLinkWithDropdown.js';
@@ -39,13 +40,13 @@ export const lhcFillsActiveColumns = {
             { fillNumber },
             [
                 h(CopyToClipboardComponent, { value: fillNumber, id: fillNumber }, 'Copy Fill Number'),
+                ...infologgerLinksComponents({ runNumbers: runs.map(({ runNumber }) => runNumber) }),
                 frontLink(
-                    'Add log to this fill',
+                    [iconPlus(), ' Add log to this fill'],
                     'log-create',
                     { lhcFillNumbers: [fillNumber] },
                     { id: 'create-log', class: 'btn btn-primary h2' },
                 ),
-                ...infologgerLinksComponents({ runNumbers: runs.map(({ runNumber }) => runNumber) }),
             ],
         ),
         profiles: {

test/public/lhcFills/overview.test.js

@@ -31,12 +31,6 @@ const { expect } = chai;
 const percentageRegex = new RegExp(/\d{1,2}.\d{2}%/);
 const durationRegex = new RegExp(/\d{2}:\d{2}:\d{2}/);
 
-const beamTypeExpect = { selector:'tbody tr:nth-child(1) td:nth-child(8)', value: 'PROTON\nPROTON'};
-const beforeFirststRunExpect = { selector:'tbody tr:nth-child(1) td:nth-child(5)', value: '03:00:00\n(25.00%)'};
-const collidingBunchesExpect = { selector:'tbody tr:nth-child(1) td:nth-child(9)', value: '1024'};
-const meanRunDurationExpect = { selector:'tbody tr:nth-child(1) td:nth-child(6)', value: '01:40:00'};
-const totalRunsDurationExpect = { selector:'tbody tr:nth-child(1) td:nth-child(7)', value: '05:00:00\n(41.67%)'};
-
 module.exports = () => {
     let page;
     let browser;
@@ -133,8 +127,8 @@ module.exports = () => {
         await page.waitForSelector(`body > div:nth-child(3) > div:nth-child(1)`);
         await expectInnerText(page, `#copy-6 > div:nth-child(1)`, 'Copy Fill Number')
 
-        await expectLink(page, 'body > div:nth-child(3) > div:nth-child(1) > div:nth-child(1) > div:nth-child(1) > a:nth-child(2)', {
-            href: `http://localhost:4000/?page=log-create&lhcFillNumbers=6`, innerText: 'Add log to this fill'
+        await expectLink(page, 'body > div:nth-child(3) > div:nth-child(1) > div:nth-child(1) > div:nth-child(1) > a:nth-child(3)', {
+            href: `http://localhost:4000/?page=log-create&lhcFillNumbers=6`, innerText: ' Add log to this fill'
         })
         // disable the popover
         await pressElement(page, `#row6-fillNumber-text > div:nth-child(1) > div:nth-child(2)`)
@@ -217,6 +211,12 @@ module.exports = () => {
     });
 
     it('should successfully display some statistics', async () => {
+        const beamTypeExpect = { selector: 'tbody tr:nth-child(1) td:nth-child(8)', value: 'PROTON\nPROTON' };
+        const beforeFirststRunExpect = { selector: 'tbody tr:nth-child(1) td:nth-child(5)', value: '03:00:00\n(25.00%)' };
+        const collidingBunchesExpect = { selector: 'tbody tr:nth-child(1) td:nth-child(9)', value: '1024' };
+        const meanRunDurationExpect = { selector: 'tbody tr:nth-child(1) td:nth-child(6)', value: '01:40:00' };
+        const totalRunsDurationExpect = { selector: 'tbody tr:nth-child(1) td:nth-child(7)', value: '05:00:00\n(41.67%)' };
+
         await goToPage(page, 'lhc-fill-overview');
 
         await expectInnerText(page, beamTypeExpect.selector, beamTypeExpect.value);