[O2B-1464] Fix missing LHC22o-test productions (#1959)

* fix

* rollback

Author: xsalonx

…enums/NonPhysicsProductionsNamesRoles.js …enums/NonPhysicsProductionsNamesWords.jslib/domain/enums/NonPhysicsProductionsNamesRoles.js renamed to lib/domain/enums/NonPhysicsProductionsNamesWords.js lib/domain/enums/NonPhysicsProductionsNamesRoles.js renamed to lib/domain/enums/NonPhysicsProductionsNamesWords.js

@@ -12,6 +12,9 @@
  * or submit itself to any jurisdiction.
  */
 
+/**
+ * TEST or DEBUG production's name must have '_test' or '_debug' substring. '_' is required because of test periods like 'LHC22o-test'
+ */
 const NonPhysicsProductionsNamesWords = Object.freeze({
     TEST: 'test',
     DEBUG: 'debug',

lib/server/controllers/dataPasses.controller.js

@@ -21,7 +21,7 @@ const { dtoValidator } = require('../utilities/dtoValidator.js');
 const { countedItemsToHttpView } = require('../utilities/countedItemsToHttpView.js');
 const { updateExpressResponseFromNativeError } = require('../express/updateExpressResponseFromNativeError');
 const PaginationDto = require('../../domain/dtos/PaginationDto.js');
-const { NON_PHYSICS_PRODUCTIONS_NAMES_WORDS } = require('../../domain/enums/NonPhysicsProductionsNamesRoles.js');
+const { NON_PHYSICS_PRODUCTIONS_NAMES_WORDS } = require('../../domain/enums/NonPhysicsProductionsNamesWords.js');
 
 /**
  * List All DataPasses with statistics

lib/server/services/dataPasses/DataPassService.js

@@ -22,7 +22,7 @@ const { PdpBeamType } = require('../../../domain/enums/PdpBeamType');
 const { BadParameterError } = require('../../errors/BadParameterError');
 const { SkimmingStage } = require('../../../domain/enums/SkimmingStage');
 const { LogManager } = require('@aliceo2/web-ui');
-const { NonPhysicsProductionsNamesWords } = require('../../../domain/enums/NonPhysicsProductionsNamesRoles.js');
+const { NonPhysicsProductionsNamesWords } = require('../../../domain/enums/NonPhysicsProductionsNamesWords.js');
 
 /**
  * @typedef DataPassIdentifier
@@ -136,10 +136,10 @@ class DataPassService {
 
         const byName = filter?.include?.byName ?? [];
         if (!byName.includes(NonPhysicsProductionsNamesWords.TEST)) {
-            queryBuilder.where('name').not().substring(NonPhysicsProductionsNamesWords.TEST);
+            queryBuilder.where('name').not().substring(`\\_${NonPhysicsProductionsNamesWords.TEST}`);
         }
         if (!byName.includes(NonPhysicsProductionsNamesWords.DEBUG)) {
-            queryBuilder.where('name').not().substring(NonPhysicsProductionsNamesWords.DEBUG);
+            queryBuilder.where('name').not().substring(`\\_${NonPhysicsProductionsNamesWords.DEBUG}`);
         }
 
         const { count, rows } = await DataPassRepository.findAndCountAll(queryBuilder);

lib/server/services/lhcPeriod/LhcPeriodStatisticsService.js

@@ -19,7 +19,7 @@ const { RunQualities } = require('../../../domain/enums/RunQualities.js');
 const { BadParameterError } = require('../../errors/BadParameterError');
 const { NotFoundError } = require('../../errors/NotFoundError');
 const { RunDefinition } = require('../../../domain/enums/RunDefinition.js');
-const { NonPhysicsProductionsNamesWords } = require('../../../domain/enums/NonPhysicsProductionsNamesRoles.js');
+const { NonPhysicsProductionsNamesWords } = require('../../../domain/enums/NonPhysicsProductionsNamesWords.js');
 
 /**
  * @typedef LhcPeriodIdentifier object to uniquely identify a lhc period
@@ -204,8 +204,8 @@ class LhcPeriodStatisticsService {
 
                         where: {
                             name: { [Op.and]: [
-                                { [Op.notLike]: `%${NonPhysicsProductionsNamesWords.TEST}%` },
-                                { [Op.notLike]: `%${NonPhysicsProductionsNamesWords.DEBUG}%` },
+                                { [Op.notLike]: `%\\_${NonPhysicsProductionsNamesWords.TEST}%` },
+                                { [Op.notLike]: `%\\_${NonPhysicsProductionsNamesWords.DEBUG}%` },
                             ] },
                         },