Allow flags creation to continue if initial one fails for sync

Author: graduta

lib/server/services/qualityControlFlag/QcFlagService.js

@@ -156,50 +156,55 @@ class QcFlagService {
             const createdFlags = [];
             for (const qcFlag of qcFlags) {
                 const { comment, flagTypeId, origin } = qcFlag;
-                const { from, to } = this._prepareQcFlagPeriod({ from: qcFlag.from, to: qcFlag.to }, targetRun);
-
-                // Insert
-                const newInstance = await QcFlagRepository.insert({
-                    from,
-                    to,
-                    comment,
-                    origin,
-                    createdById: user.id,
-                    flagTypeId,
-                    runNumber,
-                    detectorId: detector.id,
-                });
-                if (dataPass) {
-                    await newInstance.addDataPass(dataPass);
-                } else if (simulationPass) {
-                    await newInstance.addSimulationPass(simulationPass);
+                // Each flag should be treated separately and the for loop should not fail on the first error
+                try {
+                    const { from, to } = this._prepareQcFlagPeriod({ from: qcFlag.from, to: qcFlag.to }, targetRun);
+
+                    // Insert
+                    const newInstance = await QcFlagRepository.insert({
+                        from,
+                        to,
+                        comment,
+                        origin,
+                        createdById: user.id,
+                        flagTypeId,
+                        runNumber,
+                        detectorId: detector.id,
+                    });
+                    if (dataPass) {
+                        await newInstance.addDataPass(dataPass);
+                    } else if (simulationPass) {
+                        await newInstance.addSimulationPass(simulationPass);
+                    }
+
+                    /** @var {SequelizeQcFlag} createdFlag */
+                    const createdFlag = await QcFlagRepository.findOne({
+                        where: { id: newInstance.id },
+                        include: [
+                            { association: 'dataPasses' },
+                            { association: 'simulationPasses' },
+                            { association: 'createdBy' },
+                        ],
+                    });
+
+                    // Update effective periods
+                    const effectivePeriodsToBeUpdated = await QcFlagEffectivePeriodRepository.findOverlappingPeriodsCreatedBeforeLimit(
+                        { from, to },
+                        createdFlag.createdAt,
+                        { dataPassId: dataPass?.id, simulationPassId: simulationPass?.id, runNumber, detectorId: detector.id },
+                    );
+                    await this._removeEffectivePeriodsAndPeriodIntersection(createdFlag, effectivePeriodsToBeUpdated);
+
+                    await QcFlagEffectivePeriodRepository.insert({
+                        flagId: newInstance.id,
+                        from: newInstance.from,
+                        to: newInstance.to,
+                    });
+
+                    createdFlags.push(qcFlagAdapter.toEntity(createdFlag));
+                } catch (error) {
+                    this._logger.warnMessage(`Failed to create QC flag with properties: ${JSON.stringify(qcFlag)}. Error: ${error}`);
                 }
-
-                /** @var {SequelizeQcFlag} createdFlag */
-                const createdFlag = await QcFlagRepository.findOne({
-                    where: { id: newInstance.id },
-                    include: [
-                        { association: 'dataPasses' },
-                        { association: 'simulationPasses' },
-                        { association: 'createdBy' },
-                    ],
-                });
-
-                // Update effective periods
-                const effectivePeriodsToBeUpdated = await QcFlagEffectivePeriodRepository.findOverlappingPeriodsCreatedBeforeLimit(
-                    { from, to },
-                    createdFlag.createdAt,
-                    { dataPassId: dataPass?.id, simulationPassId: simulationPass?.id, runNumber, detectorId: detector.id },
-                );
-                await this._removeEffectivePeriodsAndPeriodIntersection(createdFlag, effectivePeriodsToBeUpdated);
-
-                await QcFlagEffectivePeriodRepository.insert({
-                    flagId: newInstance.id,
-                    from: newInstance.from,
-                    to: newInstance.to,
-                });
-
-                createdFlags.push(qcFlagAdapter.toEntity(createdFlag));
             }
             return createdFlags;
         });

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@aliceo2/bookkeeping",
-  "version": "1.9.1",
+  "version": "1.9.2",
   "author": "ALICEO2",
   "scripts": {
     "coverage": "nyc npm test && npm run coverage:report",