[O2B-1520] Revert changes to validate range

Simplified the range validation logic in rangeUtils.js by removing redundant checks and revert to using parseInt for number parsing.

Revert test too.

Author: isaachilly

lib/utilities/rangeUtils.js

@@ -28,16 +28,9 @@ export const validateRange = (value, helpers) => {
 
     for (const number of numbers) {
         if (number.includes('-')) {
-            // Check if '-' occurs more than once in this part of the range
-            if (number.lastIndexOf('-') !== number.indexOf('-')) {
-                return helpers.error(RANGE_INVALID, { message: `Invalid range: ${number}` });
-            }
             const parts = number.split('-');
-            // Ensure exactly 2 parts and both are non-empty
-            if (parts.length !== 2 || parts[0].trim() === '' || parts[1].trim() === '') {
-                return helpers.error(RANGE_INVALID, { message: `Invalid range: ${number}` });
-            }
-            const [start, end] = parts.map((n) => Number(n));
+            const [start, end] = parts.map((n) => parseInt(n, 10));
+
             if (Number.isNaN(start) || Number.isNaN(end) || start > end) {
                 return helpers.error(RANGE_INVALID, { message: `Invalid range: ${number}` });
             }
@@ -46,12 +39,6 @@ export const validateRange = (value, helpers) => {
             if (rangeSize > MAX_RANGE_SIZE) {
                 return helpers.error(RANGE_INVALID, { message: `Given range exceeds max size of ${MAX_RANGE_SIZE} range: ${number}` });
             }
-        } else {
-            // Single number validation
-            const num = Number(number);
-            if (Number.isNaN(num)) {
-                return helpers.error(RANGE_INVALID, { message: `Invalid number: ${number}` });
-            }
         }
     }
 

test/lib/usecases/run/GetAllRunsUseCase.test.js

@@ -90,8 +90,8 @@ module.exports = () => {
         expect(runs[1].runNumber).to.equal(95);
     });
 
-    it('should return an array, only containing found runs from passed list (run numbers can be missing)', async () => {
-        getAllRunsDto.query = { filter: { runNumbers: '17, ,400,18' } };
+    it('should return an array, only containing found runs from passed list (run numbers can be missing or non-numbers)', async () => {
+        getAllRunsDto.query = { filter: { runNumbers: '-2,17, ,400,18' } };
         const { runs } = await new GetAllRunsUseCase().execute(getAllRunsDto);
 
         expect(runs).to.be.an('array');