Skip to content

Commit f525a85

Browse files
author
GuustMetz
committed
remove name whilst runs per lhc name is loading
1 parent ac1020e commit f525a85

3 files changed

Lines changed: 4 additions & 8 deletions

File tree

lib/public/views/Runs/RunPerDataPass/RunsPerDataPassOverviewPage.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -214,11 +214,7 @@ export const RunsPerDataPassOverviewPage = ({
214214
profiles: ['runsPerDataPass'],
215215
},
216216
},
217-
};
218-
219-
detectors && dataPass && Object.assign(
220-
activeColumns,
221-
createRunDetectorsAsyncQcActiveColumns(
217+
...detectors && dataPass && createRunDetectorsAsyncQcActiveColumns(
222218
perDataPassOverviewModel.runDetectorsSelectionModel,
223219
detectors,
224220
remoteDplDetectorsUserHasAccessTo,
@@ -229,7 +225,7 @@ export const RunsPerDataPassOverviewPage = ({
229225
mcReproducibleAsNotBad,
230226
},
231227
),
232-
);
228+
};
233229

234230
return [
235231
h('.flex-row.justify-between.items-center.g2', [

lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ export const RunsPerLhcPeriodOverviewPage = ({ runs: { perLhcPeriodOverviewModel
102102

103103
const lhcPeriodName = remoteLhcPeriodStatistics?.match({
104104
Success: (lhcPeriodStatistics) => lhcPeriodStatistics.lhcPeriod.name,
105-
Other: () => null,
105+
Other: () => '',
106106
});
107107

108108
return [

test/public/runs/runsPerDataPass.overview.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -625,7 +625,7 @@ module.exports = () => {
625625

626626
it('should successfully enable QC flag creation when data pass is un-frozen', async () => {
627627
await waitForTableLength(page, 3);
628-
await page.waitForSelector('#set-qc-flags-trigger[disabled]', { hidden: true });
628+
await page.waitForSelector('#set-qc-flags-trigger[disabled]');
629629
await page.waitForSelector('#set-qc-flags-trigger');
630630
await page.waitForSelector('#row107-ACO-text a');
631631
});

0 commit comments

Comments
 (0)