Skip to content

Commit b17750d

Browse files
committed
[core] Clear all old run timestamps on SOSOR
1 parent 026ed69 commit b17750d

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

core/environment/environment.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,9 @@ func newEnvironment(userVars map[string]string, newId uid.ID) (env *Environment,
189189
runStartTime := time.Now()
190190
runStartTimeS := strconv.FormatInt(runStartTime.UnixMilli(), 10)
191191
env.workflow.SetRuntimeVar("run_start_time_ms", runStartTimeS)
192-
env.workflow.SetRuntimeVar("run_end_time_ms", "") // we delete previous SOEOR
192+
env.workflow.SetRuntimeVar("run_start_completion_time_ms", "") // we delete previous EOSOR
193+
env.workflow.SetRuntimeVar("run_end_time_ms", "") // we delete previous SOEOR
194+
env.workflow.SetRuntimeVar("run_end_completion_time_ms", "") // we delete previous EOEOR
193195

194196
the.EventWriterWithTopic(topic.Run).WriteEventWithTimestamp(&pb.Ev_RunEvent{
195197
EnvironmentId: envId.String(),

core/environment/transition_startactivity.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ func (t StartActivityTransition) do(env *Environment) (err error) {
8989
"fill_info_stable_beam_end_ms",
9090
"run_type",
9191
"run_start_time_ms",
92+
"run_end_time_ms", // included to ensure that a cleared SOEOR timestamp is propagated to all tasks during START-STOP-START
9293
"lhc_period",
9394
} {
9495
if value, ok := cvs[key]; ok {

0 commit comments

Comments
 (0)