Only render when hovering over a shulker box && remove existing item list on shulker box hover

Author: FrederoxDev

CMakeLists.txt

@@ -2,6 +2,7 @@ cmake_minimum_required(VERSION 3.12)
 project(ItemInformation)
 set(MOD_VERSION "1.4.0")
 
+
 # Define only RelWithDebInfo as the available build configuration
 set(CMAKE_CONFIGURATION_TYPES "RelWithDebInfo" CACHE STRING "Build configurations" FORCE)
 set(CMAKE_BUILD_TYPE "RelWithDebInfo" CACHE STRING "Choose the type of build, options are: Debug Release RelWithDebInfo" FORCE)

include/dllmain.h

@@ -24,6 +24,7 @@
 #include <minecraft/src/common/world/Container.h>
 #include <minecraft/src-deps/core/resource/ResourceHelper.h>
 #include <minecraft/src-client/common/client/renderer/TexturePtr.h>
+#include <minecraft/src-client/common/client/gui/controls/renderers/HoverRenderer.h>
 
 #include "ShulkerRenderer.h"
 

src/dllmain.cpp

@@ -5,13 +5,30 @@ ClientInstance* client;
 
 ShulkerBoxBlockItem::_appendFormattedHovertext _Shulker_appendFormattedHoverText;
 Item::_appendFormattedHovertext _Item_appendFormattedHovertext;
+HoverRenderer::__renderHoverBox __renderHoverBox;
 
+ShulkerRenderer shulkerRenderer;
 ItemStack shulkerInventory[27];
-bool isHoveringShulkerbox = false;
+
+static void Item_appendFormattedHovertext(Item* self, const ItemStackBase& itemStack, Level& level, std::string& text, uint8_t a5) {
+    _Item_appendFormattedHovertext(self, itemStack, level, text, a5);
+    Item* item = itemStack.mItem;
+
+    uint64_t max = item->getMaxDamage();
+
+    if (max != 0) {
+        uint64_t current = max - item->getDamageValue(itemStack.mUserData);
+        text.append(fmt::format("\n{}7Durability: {} / {}{}r", "\xc2\xa7", current, max, "\xc2\xa7"));
+    }
+
+    std::string rawNameId;
+    itemStack.getRawNameId(rawNameId);
+    text.append(fmt::format("\n{}8{}:{} ({}){}r", "\xc2\xa7", item->mNamespace, rawNameId, item->mId, "\xc2\xa7"));
+}
 
 static void Shulker_appendFormattedHovertext(ShulkerBoxBlockItem* self, const ItemStackBase& itemStack, Level& level, std::string& text, uint8_t someBool) {
-    _Shulker_appendFormattedHoverText(self, itemStack, level, text, someBool);
-    isHoveringShulkerbox = true;
+    // Use the appendFormattedHovertext for regular items, we don't want the list of items
+    Item_appendFormattedHovertext(self, itemStack, level, text, someBool);
 
     // Reset all the currrent item stacks
     for (auto& itemStack : shulkerInventory) {
@@ -32,21 +49,15 @@ static void Shulker_appendFormattedHovertext(ShulkerBoxBlockItem* self, const It
     }
 }
 
-static void Item_appendFormattedHovertext(Item* self, const ItemStackBase& itemStack, Level& level, std::string& text, uint8_t a5) {
-    _Item_appendFormattedHovertext(self, itemStack, level, text, a5);
-    isHoveringShulkerbox = false;
-    Item* item = itemStack.mItem;
-
-    uint64_t max = item->getMaxDamage();
-
-    if (max != 0) {
-        uint64_t current = max - item->getDamageValue(itemStack.mUserData);
-        text.append(fmt::format("\n{}7Durability: {} / {}{}r", "\xc2\xa7", current, max, "\xc2\xa7"));
+static void _renderHoverBox(HoverRenderer* self, MinecraftUIRenderContext* ctx, IClientInstance* client, RectangleArea* aabb, float someFloat) {
+    // This is really bad code, it is relying on the fact that I have also hooked appendFormattedHovertext for items to append the item identifier
+    // I have no idea where the currently hovered item is stored in the game! I can't find any references to it, so it might be set in some weird place?
+    if (self->mText.find("shulker_box") != std::string::npos) {
+        shulkerRenderer.Render(ctx);
+        return;
     }
 
-    std::string rawNameId;
-    itemStack.getRawNameId(rawNameId);
-    text.append(fmt::format("\n{}8{}:{} ({}){}r", "\xc2\xa7", item->mNamespace, rawNameId, item->mId, "\xc2\xa7"));
+    __renderHoverBox(self, ctx, client, aabb, someFloat);
 }
 
 ModFunction void Initialize(const char* gameVersion, InputManager * inputManager) {
@@ -61,12 +72,11 @@ ModFunction void Initialize(const char* gameVersion, InputManager * inputManager
         SigScan("40 55 53 56 57 41 54 41 55 41 56 41 57 48 8D 6C 24 ? 48 81 EC ? ? ? ? 48 8B 05 ? ? ? ? 48 33 C4 48 89 45 ? 49 8B F1 4C 89 44 24 ? 4C 8B F2 48 8B D9"),
         &Item_appendFormattedHovertext, reinterpret_cast<void**>(&_Item_appendFormattedHovertext)
     );
-}
 
-ShulkerRenderer shulkerRenderer;
-
-ModFunction void OnRenderUI(ScreenView* screenView, UIRenderContext* ctx) {
-    shulkerRenderer.Render(ctx);
+    hookManager.CreateHook(
+        SigScan("48 8B C4 48 89 58 ? 48 89 70 ? 48 89 78 ? 4C 89 70 ? 55 48 8D 68 ? 48 81 EC ? ? ? ? 0F 29 70 ? 0F 29 78 ? 44 0F 29 40 ? 49 8B D9"),
+        &_renderHoverBox, reinterpret_cast<void**>(&__renderHoverBox)
+    );
 }
 
 ModFunction void Shutdown() {