Commit ccded32
fix: correct ternary handling in java2spec, nullable strings in repeated elements
- java2spec: ternary with null false-branch (cond ? val : null) now
preserves the original write method and uses the true branch as field
name, instead of blindly treating all ternaries as bool-as-int.
Fixes ClipData.ActivityInfo being misidentified as ParcelItemActivityInfos bool.
- codegen: string8/string16 in repeated elements are now *string with
WriteNullableString/ReadNullableString, matching Java's nullable semantics.
- parcel: add WriteNullableString and WriteNullableString16 helpers.
- Revert unrelated codec2_test.go refactoring.1 parent d43f70b commit ccded32
19 files changed
Lines changed: 124 additions & 292 deletions
File tree
- android
- companion/virtual
- content
- types
- media/tv
- telecom
- telephony/data
- window
- parcel
- specs/android
- companion/virtual
- content
- media/tv
- telecom
- telephony/data
- window
- tests/e2e
- tools/pkg
- codegen
- parcelspec
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
55 | 65 | | |
56 | 66 | | |
57 | 67 | | |
| |||
148 | 158 | | |
149 | 159 | | |
150 | 160 | | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
151 | 171 | | |
152 | 172 | | |
153 | 173 | | |
| |||
0 commit comments