Skip to content

Commit ae7fcb9

Browse files
xaionaro@dx.centerxaionaro@dx.center
authored andcommitted
docs(broadcast-receiver): replace magic strings with named constants
Use wifi.WifiStateChangedAction, wifi.ScanResultsAvailableAction, wifi.ExtraWifiState, and bluetooth.ActionFound instead of hardcoded string literals.
1 parent 7774e0e commit ae7fcb9

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

docs/broadcast-receiver.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,12 @@ package main
5555

5656
import (
5757
"fmt"
58-
"log"
5958
"unsafe"
6059

6160
"github.com/AndroidGoLab/jni"
6261
"github.com/AndroidGoLab/jni/app"
62+
"github.com/AndroidGoLab/jni/content"
63+
"github.com/AndroidGoLab/jni/net/wifi"
6364
)
6465

6566
// listenForWifiStateChanges registers a BroadcastReceiver for
@@ -85,7 +86,7 @@ func listenForWifiStateChanges(vm *jni.VM, activity *jni.Object) (cleanup func()
8586

8687
// Read an int extra (e.g. wifi_state).
8788
const defaultWifiState = -1
88-
state, err := intent.GetIntExtra("wifi_state", defaultWifiState)
89+
state, err := intent.GetIntExtra(wifi.ExtraWifiState, defaultWifiState)
8990
if err != nil {
9091
return nil, err
9192
}
@@ -96,7 +97,7 @@ func listenForWifiStateChanges(vm *jni.VM, activity *jni.Object) (cleanup func()
9697
)
9798

9899
// 2. Create an IntentFilter for the desired action.
99-
filter, err := content.NewIntentFilter(vm, "android.net.wifi.WIFI_STATE_CHANGED")
100+
filter, err := content.NewIntentFilter(vm, wifi.WifiStateChangedAction)
100101
if err != nil {
101102
jni.UnregisterProxyHandler(handlerID)
102103
return nil, fmt.Errorf("new IntentFilter: %w", err)
@@ -207,9 +208,9 @@ call `addAction` for each:
207208
```go
208209
// Create an empty filter and add multiple actions:
209210
filter, _ := content.NewIntentFilter(vm, "")
210-
filter.AddAction("android.net.wifi.WIFI_STATE_CHANGED")
211-
filter.AddAction("android.net.wifi.SCAN_RESULTS")
212-
filter.AddAction("android.bluetooth.device.action.FOUND")
211+
filter.AddAction(wifi.WifiStateChangedAction)
212+
filter.AddAction(wifi.ScanResultsAvailableAction)
213+
filter.AddAction(bluetooth.ActionFound)
213214
defer filter.Close()
214215

215216
ctx := &app.Context{VM: vm, Obj: activity}

0 commit comments

Comments
 (0)