Skip to content

Commit 4278f40

Browse files
authored
fix: crash when removing named log files when simulations fails (#121)
* Fix syntax issue when removing logfile * chore: update version to 1.13.2 and add changelog entry for syntax fix * Update anybodycon dependency version to 8.1* in pixi.toml * Fix test task dependencies in pixi.toml * Remove commented-out Linux test job due to WINE compatibility issues
1 parent 67bc073 commit 4278f40

6 files changed

Lines changed: 1541 additions & 4655 deletions

File tree

.github/workflows/test.yml

Lines changed: 29 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -43,23 +43,36 @@ jobs:
4343
RLM_LICENSE: ${{ secrets.LICENSE_SERVER }}
4444

4545

46-
test-linux-cloud:
47-
runs-on: ubuntu-latest
48-
container: ghcr.io/anybody/anybodycon-github-actions:latest
46+
# Linux builds have started failing with AMS 8.1 due to some WINE issue:
47+
# ----------------------------- Captured stderr call -----------------------------
48+
# wine: Call from 00006FFFFF463DF7 to unimplemented function ucrtbase.dll.feholdexcept, aborting
49+
# wine: Unimplemented function ucrtbase.dll.feholdexcept called at address 00006FFFFF463DF7 (thread 0524), starting debugger...
50+
# wine: Call from 00006FFFFF463DF7 to unimplemented function ucrtbase.dll.feholdexcept, aborting
51+
#
52+
# This link hits at solutions: https://forum.winehq.org/viewtopic.php?t=40355
53+
# Either something with WINETRICKS or using a the newest WINE 10.1
54+
#
55+
# So this can not be fixed until we update the AnyBody Linux containers.
56+
#
57+
#
58+
59+
# test-linux-cloud:
60+
# runs-on: ubuntu-latest
61+
# container: ghcr.io/anybody/anybodycon-github-actions:latest
4962

50-
needs: lint
63+
# needs: lint
5164

52-
steps:
53-
- uses: actions/checkout@v4
65+
# steps:
66+
# - uses: actions/checkout@v4
5467

55-
- uses: prefix-dev/setup-pixi@v0.8.1
56-
with:
57-
environments: test
58-
cache-write: ${{ github.event_name == 'push' && github.ref_name == 'master' }}
59-
activate-environment: test
68+
# - uses: prefix-dev/setup-pixi@v0.8.1
69+
# with:
70+
# environments: test
71+
# cache-write: ${{ github.event_name == 'push' && github.ref_name == 'master' }}
72+
# activate-environment: test
6073

61-
- name: test
62-
env:
63-
RLM_LICENSE_PASSWORD: ${{ secrets.LICENSE_PASSWORD }}
64-
RLM_LICENSE: ${{ secrets.LICENSE_SERVER }}
65-
run: pytest tests
74+
# - name: test
75+
# env:
76+
# RLM_LICENSE_PASSWORD: ${{ secrets.LICENSE_PASSWORD }}
77+
# RLM_LICENSE: ${{ secrets.LICENSE_SERVER }}
78+
# run: pytest tests

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# AnyPyTools Change Log
22

3+
## v1.13.2
4+
5+
**Fixed:**
6+
* Fixed and syntax issue when removing logfiles when simulation fails.
7+
38
## v1.13.1
49

510
**Fixed:**

anypytools/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
"NORMAL_PRIORITY_CLASS",
3737
]
3838

39-
__version__ = "1.13.1"
39+
__version__ = "1.13.2"
4040

4141

4242
def print_versions():

anypytools/abcutils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -908,7 +908,7 @@ def _worker(self, task, task_queue):
908908
)
909909
finally:
910910
if not self.keep_logfiles and not task.has_error():
911-
silentremove(logfile.name)
911+
silentremove(task.logfile)
912912
task.logfile = ""
913913
task_queue.put(task)
914914

0 commit comments

Comments
 (0)