Skip to content

Commit 8c5c9d5

Browse files
EXADS Bid Adapter : update bidder code before adapter is published (prebid#11464)
* First commit * fix: readme.md * fix: changed exads urls * fix: Tools and suggestions related to the doc * fix: from code review * fix: from code review * fix: from code review * fix: error from code review - native example * fox: from code review * fix: from code review * fix: from code review * fix: native img set as mandatory * fix: from code review * fix: from code review * fix: from code review * fix: from code review * fix: from code review * fix: from code review * fix: bidfloor and bidfloorcur set as optional * fix: dsa * fix: mananing multiple responses * fix: unit test after code review * fix: fixing native snippet code * fix: from code review * fix: video events after code review * fix: video module into documentation * fix: impression tracker for native * fix: afeter code review * fix: unit tests * fix: added badv and bcat * fix: video -> mimes and protocols * fix * fix: removed image_output and video_output params, forcing always html for rtb banner * fix: gulp * fix: added site.name * fix: removed EXADS dir * fix: after linting * fix: unit tests * fix: final dsa solution * fix: dsa * fix: fix instream example * fix: doc media type context * fix: documented the endpoint param into native section * fix: related to markdown lint validation (#2) * fix: from CR (#3) * fix: changed bidder code to exads * fix: userAgent --------- Co-authored-by: tfoliveira <tfoliveira@users.noreply.github.com>
1 parent 5438945 commit 8c5c9d5

3 files changed

Lines changed: 9 additions & 10 deletions

File tree

modules/exadsBidAdapter.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import * as utils from '../src/utils.js';
22
import { BANNER, NATIVE, VIDEO } from '../src/mediaTypes.js';
33
import { registerBidder } from '../src/adapters/bidderFactory.js';
44

5-
const BIDDER = 'exadsadserver';
5+
const BIDDER = 'exads';
66

77
const PARTNERS = {
88
ORTB_2_4: 'ortb_2_4'
@@ -332,12 +332,11 @@ function getEnvParams() {
332332
envParams.osName = 'MacOS';
333333
} else if (envParams.userAgent.match(/Unix/i)) {
334334
envParams.osName = 'Unix';
335-
// TODO: what is userAgent.userAgent supposed to be?
336-
} else if (envParams.userAgent.userAgent?.match(/Android/i)) {
335+
} else if (envParams.userAgent.match(/Android/i)) {
337336
envParams.osName = 'Android';
338-
} else if (envParams.userAgent.userAgent?.match(/iPhone|iPad|iPod/i)) {
337+
} else if (envParams.userAgent.match(/iPhone|iPad|iPod/i)) {
339338
envParams.osName = 'iOS';
340-
} else if (envParams.userAgent.userAgent?.match(/Linux/i)) {
339+
} else if (envParams.userAgent.match(/Linux/i)) {
341340
envParams.osName = 'Linux';
342341
} else {
343342
envParams.osName = 'Unknown';

modules/exadsBidAdapter.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ adUnits =
123123
}
124124
},
125125
bids: [{
126-
bidder: 'exadsadserver',
126+
bidder: 'exads',
127127
params: {
128128
zoneId: 12345,
129129
fid: '829a896f011475d50da0d82cfdd1af8d9cdb07ff',
@@ -162,7 +162,7 @@ adUnits =
162162
}
163163
},
164164
bids: [{
165-
bidder: 'exadsadserver',
165+
bidder: 'exads',
166166
params: {
167167
zoneId: 12345,
168168
fid: '829a896f011475d50da0d82cfdd1af8d9cdb07ff',
@@ -237,7 +237,7 @@ adUnits = [{
237237
}
238238
},
239239
bids: [{
240-
bidder: 'exadsadserver',
240+
bidder: 'exads',
241241
params: {
242242
zoneId: 12345,
243243
fid: '829a896f011475d50da0d82cfdd1af8d9cdb07ff',
@@ -365,7 +365,7 @@ adUnits = [{
365365
}
366366
},
367367
bids: [{
368-
bidder: 'exadsadserver',
368+
bidder: 'exads',
369369
params: {
370370
zoneId: 12345,
371371
fid: '829a896f011475d50da0d82cfdd1af8d9cdb07ff',

test/spec/modules/exadsBidAdapter_spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { spec, imps } from 'modules/exadsBidAdapter.js';
33
import { BANNER, NATIVE, VIDEO } from '../../../src/mediaTypes.js';
44

55
describe('exadsBidAdapterTest', function () {
6-
const bidder = 'exadsadserver';
6+
const bidder = 'exads';
77

88
const partners = {
99
ORTB_2_4: 'ortb_2_4'

0 commit comments

Comments
 (0)