Merge pull request #61 from Appsilon/60-fix-single-choice-dropdown

fix: make dropdown work with a singular choice

Author: jakubnowicki

DESCRIPTION

@@ -1,7 +1,7 @@
 Type: Package
 Package: reactable.extras
 Title: Extra Features for 'reactable' Package
-Version: 0.2.0.9000
+Version: 0.2.0.9001
 Authors@R:
   c(
     person("Recle", "Vibal", role = c("aut", "cre"), email = "opensource+recle@appsilon.com"),

NEWS.md

@@ -1,6 +1,7 @@
 # reactable.extras (development)
 
 - Fix server-side processing example.
+- Dropdown now work with a singular choice.
 
 # reactable.extras 0.2.0
 

R/inputs.R

@@ -129,7 +129,7 @@ build_dropdown_extra_choices <- function(choices) {
   if (length(choices) == 0) {
     choices_js <- ""
   } else {
-    choices_js <- paste0(", choices: ", rjson::toJSON(choices))
+    choices_js <- paste0(", choices: ", rjson::toJSON(as.list(choices)))
   }
 
   return(choices_js)

tests/testthat/test-inputs.R

@@ -34,6 +34,12 @@ test_that("`dropdown_extra` sets choices to blank when length is 0", {
   expect_equal(choices, "")
 })
 
+test_that("`dropdown_extra` serializes a single value as an array", {
+  choices <- build_dropdown_extra_choices("a")
+
+  expect_equal(choices, ', choices: ["a"]')
+})
+
 test_that("`dropdown_extra` sets choices correctly", {
   choices <- build_dropdown_extra_choices(letters[1:3])