style(clippy): fix

Author: noamteyssier

src/bq/reader.rs

@@ -508,6 +508,7 @@ impl MmapReader {
     }
 
     /// Creates a new quality score buffer
+    #[must_use]
     pub fn build_qbuf(&self) -> Vec<u8> {
         vec![self.default_quality_score; self.header.slen.max(self.header.xlen) as usize]
     }

src/bq/writer.rs

@@ -133,6 +133,7 @@ impl Encoder {
     }
 
     /// Returns whether the header is paired-end.
+    #[must_use]
     pub fn is_paired(&self) -> bool {
         self.header.is_paired()
     }
@@ -494,13 +495,11 @@ impl<W: Write> BinseqWriter<W> {
             } else {
                 Ok(false)
             }
+        } else if let Some(buffer) = self.encoder.encode_single(record.s_seq)? {
+            write_buffer(&mut self.inner, buffer)?;
+            Ok(true)
         } else {
-            if let Some(buffer) = self.encoder.encode_single(record.s_seq)? {
-                write_buffer(&mut self.inner, buffer)?;
-                Ok(true)
-            } else {
-                Ok(false)
-            }
+            Ok(false)
         }
     }
 

src/cbq/core/block.rs

@@ -513,7 +513,7 @@ impl ColumnarBlock {
                 if *len as usize > self.qbuf.len() {
                     self.qbuf.resize(*len as usize, self.default_quality_score);
                 }
-            })
+            });
         }
 
         // decompress header lengths
@@ -721,7 +721,7 @@ impl<'a> Iterator for RefRecordIter<'a> {
             let record = RefRecord {
                 block: self.block,
                 index: self.index,
-                qbuf: &self.qbuf,
+                qbuf: self.qbuf,
                 global_index,
                 sseq_span,
                 sheader_span,

src/error.rs

@@ -256,7 +256,7 @@ pub enum WriteError {
     #[error("Incompatible headers found in VBinseqWriter::ingest. Found ({1:?}) Expected ({0:?})")]
     IncompatibleHeaders(crate::vbq::VBinseqHeader, crate::vbq::VBinseqHeader),
 
-    /// When building a SequencingRecord without a primary sequence
+    /// When building a `SequencingRecord` without a primary sequence
     #[error("SequencingRecordBuilder requires a primary sequence (s_seq)")]
     MissingSequence,
 }

src/record/sequencing_record.rs

@@ -265,7 +265,7 @@ impl<'a> SequencingRecordBuilder<'a> {
         self
     }
 
-    /// Builds the SequencingRecord
+    /// Builds the `SequencingRecord`
     ///
     /// # Errors
     ///

src/vbq/writer.rs

@@ -917,7 +917,7 @@ impl BlockWriter {
 
         // Write the lengths
         self.write_length(record.s_seq.len() as u64)?;
-        self.write_length(record.x_seq.map_or(0, |x| x.len()) as u64)?;
+        self.write_length(record.x_seq.map_or(0, <[u8]>::len) as u64)?;
 
         // Write the primary sequence and optional quality
         self.write_buffer(sbuf)?;

src/write.rs

@@ -81,7 +81,7 @@ impl FromStr for Format {
             "bq" | "BQ" | "b" => Ok(Self::Bq),
             "vbq" | "VBQ" | "v" => Ok(Self::Vbq),
             "cbq" | "CBQ" | "c" => Ok(Self::Cbq),
-            _ => Err(format!("Unknown format: {}", s)),
+            _ => Err(format!("Unknown format: {s}")),
         }
     }
 }
@@ -381,7 +381,7 @@ impl<W: Write> BinseqWriter<W> {
     /// Returns an error if there's an I/O error writing the final data.
     pub fn finish(&mut self) -> Result<()> {
         match self {
-            Self::Bq(w) => w.flush().map_err(Into::into),
+            Self::Bq(w) => w.flush(),
             Self::Vbq(w) => w.finish(),
             Self::Cbq(w) => w.finish(),
         }