feat(#10): move constants to environment variables

Author: ArielMAJ

.env.example

@@ -11,3 +11,7 @@ POSTGRES_PORT=5432
 
 POSTGRES_ECHO=true
 DATABASE_ENABLE_CONNECTION_POOLING=true
+
+SECRET_KEY=
+ALGORITHM=
+ACCESS_TOKEN_EXPIRE_MINUTES=

api/config.py

@@ -58,6 +58,12 @@ class DatabaseConfig:
     }
 
 
+class AuthConfig:
+    SECRET_KEY: str = os.getenv("SECRET_KEY")
+    ALGORITHM: str = os.getenv("ALGORITHM")
+    ACCESS_TOKEN_EXPIRE_MINUTES: int = int(os.getenv("ACCESS_TOKEN_EXPIRE_MINUTES"))
+
+
 class Config:
     """Base configuration."""
 
@@ -74,6 +80,7 @@ class Config:
     APPLICATION_ROOT = os.getenv("APPLICATION_ROOT", "")
 
     DATABASE: DatabaseConfig = DatabaseConfig()
+    AUTH: AuthConfig = AuthConfig()
 
 
 class TestConfig(Config):

api/entrypoints/user.py

@@ -23,7 +23,7 @@ async def get_users() -> List[UserOut]:
     return await UserService().get_all()
 
 
-@authenticated_router.get("/me", response_model=UserOut)
+@router.get("/me", response_model=UserOut)
 async def read_user_me(
     current_user: Annotated[User, Depends(AuthService.get_current_active_user)]
 ):

api/services/auth.py

@@ -2,6 +2,7 @@
 from typing import Annotated, Union
 
 import jwt
+from api.config import Config
 from api.database.models.users import User
 from api.exceptions.http_exceptions import CredentialsException
 from api.schemas.auth import TokenData
@@ -13,11 +14,6 @@
 oauth2_scheme = OAuth2PasswordBearer(tokenUrl="/auth/token")
 
 
-SECRET_KEY = "ef555b4c8637c33623fe8e91ba7256725e7e2a1bcc75fe84acb189bcaa6c8693"
-ALGORITHM = "HS256"
-ACCESS_TOKEN_EXPIRE_MINUTES = 30
-
-
 class AuthService:
     @staticmethod
     def verify_password(plain_password, hashed_password):
@@ -42,16 +38,20 @@ def create_access_token(
     ):
         to_encode = data.copy()
         expires_at = datetime.now(timezone.utc) + timedelta(
-            minutes=expires_delta_in_minutes or ACCESS_TOKEN_EXPIRE_MINUTES
+            minutes=expires_delta_in_minutes or Config.AUTH.ACCESS_TOKEN_EXPIRE_MINUTES
         )
         to_encode.update({"exp": expires_at})
-        encoded_jwt = jwt.encode(to_encode, SECRET_KEY, algorithm=ALGORITHM)
+        encoded_jwt = jwt.encode(
+            to_encode, Config.AUTH.SECRET_KEY, algorithm=Config.AUTH.ALGORITHM
+        )
         return encoded_jwt, expires_at
 
     # @staticmethod
     async def get_current_user(token: Annotated[str, Depends(oauth2_scheme)]):
         try:
-            payload = jwt.decode(token, SECRET_KEY, algorithms=[ALGORITHM])
+            payload = jwt.decode(
+                token, Config.AUTH.SECRET_KEY, algorithms=[Config.AUTH.ALGORITHM]
+            )
             username: Union[str, None] = payload.get("sub")
             if username is None:
                 raise CredentialsException()