fix: align setup diagnostics status handling

Use the shaped diagnostics view for setup status messaging and relax JS asset content-type assertions so the setup tests pass on both text/javascript and application/javascript responders.

Author: ArietidsZ

tests/test_api_setup.py

@@ -41,6 +41,10 @@ def _build_runtime(config: Config) -> AppRuntime:
     )
 
 
+def _is_javascript_content_type(content_type: str) -> bool:
+    return content_type.startswith(("text/javascript", "application/javascript"))
+
+
 def test_gui_and_setup_routes() -> None:
     config = Config()
     app = create_app(_build_runtime(config))
@@ -61,11 +65,11 @@ def test_gui_and_setup_routes() -> None:
 
     js = client.get("/static/setup.js")
     assert js.status_code == 200
-    assert js.headers["content-type"].startswith("text/javascript")
+    assert _is_javascript_content_type(js.headers["content-type"])
 
     setup_state = client.get("/static/setup_state.js")
     assert setup_state.status_code == 200
-    assert setup_state.headers["content-type"].startswith("text/javascript")
+    assert _is_javascript_content_type(setup_state.headers["content-type"])
 
     setup = client.get("/setup/config")
     assert setup.status_code == 200

tests/test_setup_studio_contract.py

@@ -44,6 +44,10 @@ def _build_runtime(config: Config) -> AppRuntime:
 client = TestClient(create_app(_build_runtime(Config())))
 
 
+def _is_javascript_content_type(content_type: str) -> bool:
+    return content_type.startswith(("text/javascript", "application/javascript"))
+
+
 def class_tokens_for_id(html: str, element_id: str) -> set[str]:
     tag_match = re.search(rf'<[^>]*\bid="{re.escape(element_id)}"[^>]*>', html)
     assert tag_match is not None
@@ -134,7 +138,7 @@ def test_setup_assets_expose_module_and_top_level_contracts() -> None:
 
     for response in (entry_js, api_js, state_js, view_models_js, views_js):
         assert response.status_code == 200
-        assert response.headers["content-type"].startswith("text/javascript")
+        assert _is_javascript_content_type(response.headers["content-type"])
 
     assert 'import { createSetupApi } from "./setup_api.js";' in entry_js.text
     assert 'import { createSetupState } from "./setup_state.js";' in entry_js.text
@@ -230,6 +234,8 @@ def test_setup_js_renders_shaped_setup_view_summaries_and_common_fixes() -> None
     assert "const diagnosticsView = toDiagnosticsView(report);" in entry_js.text
     assert "views.renderDiagnosticsSummary(diagnosticsView);" in entry_js.text
     assert "views.renderCommonFixes(diagnosticsView);" in entry_js.text
+    assert 'if (diagnosticsView.state === "ready") {' in entry_js.text
+    assert "if (report.ready) {" not in entry_js.text
     assert "const runtimeView = toRuntimeView(runtime);" in entry_js.text
     assert "renderRuntimeState(runtimeView, runtime);" in entry_js.text
     assert (

video_rss_aggregator/static/setup.js

@@ -129,7 +129,7 @@ async function handleDiagnostics() {
     outputs.diagnostics.textContent = JSON.stringify(report, null, 2);
     views.renderDiagnosticsSummary(diagnosticsView);
     views.renderCommonFixes(diagnosticsView);
-    if (report.ready) {
+    if (diagnosticsView.state === "ready") {
       views.setStatus(status.diagnostics, "All required dependencies are available.");
     } else {
       views.setStatus(status.diagnostics, "Some dependencies are missing or unreachable.", true);